From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C824EC433F5 for ; Tue, 18 Jan 2022 20:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zqqAQsEPxCJ4A/W80zSGXYcan/Oi9iCfuJBma2fP+pE=; b=G0PQCrYe0zlHjL ztNm2ymYYpuM6AtmgeJI6zz/cz8qg1lFBnFitAfTskR+647iVfOXHUrDT6lOLLTtOzPvJfS49OpD4 EojoaSUNmQUzLbesqHusRIzFjdFVJ8r2ijVvDoH7aml659a4PPt5ix8a+Y981T1c0m5VLljCH2pRL by1/4LK943iNY4KUhupIsZ048+wkAqYe1QoZoejD4yYk5rZAPrHxeEoN/H4zmG+fu9OABQzJ5ew0w zu10bzRNO/Bze1O4QAirIFUJ0V85Rkhr6YI+Bib5cmGR1BQ0AqpMF31Bz9lyJQvmtRbp5ukGfJnX8 HkRPRgxJzVp3/oJlU29Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9vUh-002wbe-Nz; Tue, 18 Jan 2022 20:54:20 +0000 Received: from smtprelay-out1.synopsys.com ([149.117.73.133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9vUe-002was-4H for linux-arm-kernel@lists.infradead.org; Tue, 18 Jan 2022 20:54:17 +0000 Received: from mailhost.synopsys.com (sv1-mailhost1.synopsys.com [10.205.2.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mailhost.synopsys.com", Issuer "SNPSica2" (verified OK)) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 8668F406E9; Tue, 18 Jan 2022 20:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1642539255; bh=PcqrgOq+GudbN8Fd+nWDwwC5UzR6hmHIegLExa7EAH0=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=JIrt9NkIVMZIhMSa1htvRuSrixnVaAeaQp0jgZEA5mEm5kg3M4xX24Wxl7Abgwh6E +d5sa7xoXF2gcitN4XWZBoPYCnLYqLyrw/EO+0ec7wVd4LCUchRkxHiW5xcdqN7Yy4 U0uC3gFRABS2L5QL+BXMlgZ0EPEryhMO1r4yrMWVaFXMoDmSIqCQXtkOrNK5pzZMLM 2VC3LmQMIw+jz6b1s9CR9jLYQQpodYDQ8ivV6L+iM8R7AZP5+goP5Eix+1pgoFab2c eBiXAratsopRXpTHqLi3PrirvihW+6LfeQu95SIzHNjtB3wj17SoKH+55X1dNmbHdu XitTbyXT721SA== Received: from o365relay-in.synopsys.com (sv2-o365relay1.synopsys.com [10.202.1.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "o365relay-in.synopsys.com", Issuer "Entrust Certification Authority - L1K" (verified OK)) by mailhost.synopsys.com (Postfix) with ESMTPS id 424FDA005F; Tue, 18 Jan 2022 20:54:14 +0000 (UTC) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2043.outbound.protection.outlook.com [104.47.51.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by o365relay-in.synopsys.com (Postfix) with ESMTPS id 59C494009D; Tue, 18 Jan 2022 20:54:13 +0000 (UTC) Authentication-Results: o365relay-in.synopsys.com; dmarc=pass (p=reject dis=none) header.from=synopsys.com Authentication-Results: o365relay-in.synopsys.com; spf=pass smtp.mailfrom=thinhn@synopsys.com Authentication-Results: o365relay-in.synopsys.com; dkim=pass (1024-bit key; unprotected) header.d=synopsys.com header.i=@synopsys.com header.b="SExtQDWx"; dkim-atps=neutral ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N4U6GHHqMO9/xyJpckg6fuZ8Ve2HXGM8A1nLiX4ajkJb8clPp6I2eVSCKUokycVezRuLKBVUNBe/zq8Y+/WJKsO2mlQgjt+OvP+KPrfmU6+h4sdff4kQzd/1CVSY8haK8FEceLRExLHVThSBdWIKR0bTkn0zFbCmDNIHqZFInu5xCqen8W+wlTxKPUAMQPPTiRT663wMCSmz3YL/yeCxkmRupBi9Om41pw/5jM84UtOGg6pCvMDRtX2l+Xwkv2VMYqza4XZvAV+1Af5vxb+N93Bzche6xcctF94gN9Rj1Ci5cEdEuOvmdMdg06SqMmnWZhYneizA/DkNZF4rZz0y4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PcqrgOq+GudbN8Fd+nWDwwC5UzR6hmHIegLExa7EAH0=; b=cI1i29a86NomtNU0+v17sPVYIIoDd6xU/xLsJbts8/Qfw+idMH688knT7yAvwXBOufgjRFgsIn+y8c07//PZPLZrKI5zhPHBlM6YY8pVi44IYw3rFrP8lOBP6MzWdBxpqr43FhSQ6GIAfA+qiPDEEnq9DsOdJF5HlGGGWYK0U2C9qq35KZda2PFrjZnTWfEYJfoAQfwT7JMLTKWJme7pJoo2vq1+52OXCpZx468D8Y402D5hLiKtm+mRF11msdu9zPm7+xFy0FMXZ1Xl8vbtsBAVoqGbm16jVy11PB8cnAgzRzyyTMOnwXd9/VLl7+aMYZcIIOuT+1DmdhVkrZaoyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=synopsys.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PcqrgOq+GudbN8Fd+nWDwwC5UzR6hmHIegLExa7EAH0=; b=SExtQDWxDoUaBZBVt3nOk2kY1vCciKmkOKxMmGiPtzk1jfXC5v68Lw0beQ6cqjWgrJtNDxEEsuhNoOhn2/FldUS0PwOvlWvtu/l25JyMvppvVbojGomayiphHgW8UqVbOe1gJCUNGUJ8To3sXGmsbRKH2Ld8tydc0Wqle/YldU8= Received: from BYAPR12MB4791.namprd12.prod.outlook.com (2603:10b6:a03:10a::12) by MN2PR12MB2960.namprd12.prod.outlook.com (2603:10b6:208:101::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Tue, 18 Jan 2022 20:54:09 +0000 Received: from BYAPR12MB4791.namprd12.prod.outlook.com ([fe80::8983:6493:8c38:d34a]) by BYAPR12MB4791.namprd12.prod.outlook.com ([fe80::8983:6493:8c38:d34a%3]) with mapi id 15.20.4888.014; Tue, 18 Jan 2022 20:54:09 +0000 X-SNPS-Relay: synopsys.com From: Thinh Nguyen To: Robert Hancock , "sean.anderson@seco.com" , Thinh Nguyen , "baruch@tkos.co.il" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "bjagadee@codeaurora.org" , "linux-arm-msm@vger.kernel.org" , "michal.simek@xilinx.com" , "balbi@kernel.org" , "bjorn.andersson@linaro.org" , "gregkh@linuxfoundation.org" , "linux-arm-kernel@lists.infradead.org" , "agross@kernel.org" Subject: Re: [PATCH 0/6] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Thread-Topic: [PATCH 0/6] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Thread-Index: AQHYCaAEN5xMDjPNv0iLO+Qwz2hVyaxnCOeAgAIr9wCAAAIIAIAAAf+AgAAKzwCAAAQeAA== Date: Tue, 18 Jan 2022 20:54:08 +0000 Message-ID: <076fae75-d6e7-41bf-d9e6-c77d08aa51c4@synopsys.com> References: <20220114233904.907918-1-sean.anderson@seco.com> <87iluifxy1.fsf@tarshish> <7831a4f7-7c3f-4a2a-be73-38f2c40a123c@synopsys.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=synopsys.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34740568-70d6-41c8-0157-08d9dac4ac7e x-ms-traffictypediagnostic: MN2PR12MB2960:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aGbbYVsxbU3ZIIx22290dJJj1i2dM3CS8YRWwiAu+otEImz78BP/2Sq6xNeknTgRE3E3CewH/YnP2ms+w96Z269qUe8DeTwOHjahSYxFcRIbrnyFQEviGcETHPksHFZgx5F+/qZtD1MkRAj+y4jEs9Kl/utnRqTjJBb8zB3gbHIdr/6buIbywHaaiL0qIiLdUKZshDC9oqqtdj3NA9EAGupYeSs2UweXipiH+gXQeV3/UKsOomI31jNRUm1MsSOVCsxgW4HOOXGhs9kIfh+x2LjW3DX9geITkJ29YzyWJgoouAItqkXmlx37JgaD0M+G1z9rBDGuttsUX9FYTDKjVoJNO0A6TL2g73o8VMI8y/26o3rpKYVy/UGQR+fG1phcIVEZJfypW+x8mbGaAVpLGnrOBJCRbWCkczKQe/7cbVoCRRn2yMn0r3Y+WogUwY2thYM38WuN7aSVMJdydjBy4kPeD/PReTl9CY+pjPwXuxc3HLCJszdnfOSm+LNgszf85BQWVqZF/w8DCo2he3h9FUlN7lZUfa1K5HPDfmToluV2/pBkdmU/eShRKTfrVIY2VC5yGz2HZYtjiL31fVr1qYJwzqCnztByQn18Mat0244WBoyXzP2kaPeRu5vZHV2c1IruAIXpwFDL17KSU0ZQIefF9plXEVPZRU6IrxcEkyGBeBnNXLYdQPq8HF7jmmhk752jflVqBEjlPczdCT7lpI9g7aKIfdsIv4vWsHwMRdnrqeRKrTnDKIi/H/tDyFDz7bk9+tp/KQunlZ4TBPxpJPhfv+HlGY/KurYfUB7A4EJJMSjhQE0MQND/Sm+BxpJTi3Y8ohYSbf05X16tazrxpwZg1VXZ4404q1JOcyAJnK4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB4791.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66446008)(83380400001)(64756008)(186003)(8936002)(110136005)(26005)(66556008)(66476007)(508600001)(2616005)(38070700005)(2906002)(54906003)(8676002)(316002)(31686004)(6486002)(966005)(7416002)(5660300002)(53546011)(6506007)(71200400001)(6512007)(86362001)(66946007)(36756003)(4326008)(38100700002)(31696002)(76116006)(122000001)(45980500001)(43740500002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SjJ6dC9xWUYvVllRbDA1NkUxMkVELzE1Uk1QL3BPMVAyeUtRR3ROaUljeFla?= =?utf-8?B?V01rZklTT0ZXWHRzMmp0UlpiVUIvTjRtdFNraWcxMmZZb0dNdjhTVXMxcWly?= =?utf-8?B?OTVJZ0lnZ3ZCVUhrTDBZRi9JdHM5dENDMnlxZEF3Y1lZZVQ5N25UcGxWQjJs?= =?utf-8?B?VnNnc2pRZ2hnY2Z3SUp1ZnB1NEJhQkdSdTBiUWJpd1JzL0RZcUc1YVIxYU1R?= =?utf-8?B?cm9oOFdyMEtTMEhMTWU1ZUVLSzROejRMb3V4NGYwdFE3RllxcG03NWY3QVM5?= =?utf-8?B?d0NrMm4zd0RLMC9DdEFCbi82UVhlRjI3TFJGWVJ6NTVKNXNDSm52eGkva0JC?= =?utf-8?B?bkRrSkowYXVCampVRUhQZnZpeUtJSzVLUWdyaXdvUUxkeW9aczZzZ2EzdXBD?= =?utf-8?B?a043S2E5TnVUeGh6cFpOd2NMdUVHSG9vbW9SOU51Y25RSXVZeEMxdnZrQmZT?= =?utf-8?B?a1B1dDFrWis4UGJRNmRUK0F4WVYxM1M3NU16eFhVeVQvRkJvTlluWlR2OVpr?= =?utf-8?B?ZEtia3VmQ2trSkJmbVR6SEYyelJlTHBQUWlNeGhxY0M2RVBqRFJDZ3ZJZkhm?= =?utf-8?B?ekhndXZTOVlBTFZJQ245RVRJTnpSYnpURy81akFNMEdmTzlSb0IvbXFnU1Mv?= =?utf-8?B?djMvMmUyMlpwd3JYcGpDL1pSZnNRV2xEMGJCSE5peUhzUGNoWmd1eWFhNENl?= =?utf-8?B?QnJQNms0YmQ3NVlRWlZXeVNEWFZXakNEMzFxQ2VsWjhUNnhUS0hpZkdkbFlN?= =?utf-8?B?S3I3eUNmVkJxbko5TmppUTY2QmU1S3dSRE1hb0ordU5SMml1Wm43REEyL2JH?= =?utf-8?B?M2VSNTd4R2JYMVFNeDZxUzFKYzlNenR6SmswTDZRQVpOQU9vM05FZEF0dGhU?= =?utf-8?B?MU8xNFgxaVNaYWxtakllNGtMc21HT0dXclBiS3pMc3RtWXR4bWNTRnFCWWcr?= =?utf-8?B?M2Jqd2J1aUE3aUJsblk5b0tsaDhEeE9TM2tSVGxqbDVjb2FkdkswYmNCYW5H?= =?utf-8?B?VVYyTmdiSW1TeE5WT2pPWWNtMHJBNThkMktxaXpOUTJGaEpoZGFYcjlkbG81?= =?utf-8?B?eFJONnF6QmhCK2hHV2dJcWJPSzRCUXpSeFhXWEI0S3FKQmZYVEZwZy90akRn?= =?utf-8?B?VzVxSUNoZU9yT1VZYklwZE42ajJqMjcyblpqTkNWV201Mm9abG54Mk5sVkU1?= =?utf-8?B?a1UzcHJzRE5UdUpoRkw0b1NsdDlmenpnWjRhbzRKSkJabHFyZTBxVHBtVk5E?= =?utf-8?B?Mm5ZSzhhbkU1dDVxZFNRaWh2ekRBKzVFeTUwRkt5MmlCWjkra0xuc0FXNEhZ?= =?utf-8?B?amY2eE1JN21aVElDNWFOVWVSUjNNTExHUFNEVTRYTUFEV2FzeUV6T1g0N2c4?= =?utf-8?B?NXZ2b1ZqVTU0Sjk0bkZOZW9qL1RYczJiMnlQZ005R2ozWFEyMEtjamJDdXRD?= =?utf-8?B?NDFNRWUxWFVqVE9VdXlQRU16RlMwTEc3WEM2YWZjd09tTklpT0trNHJteVFx?= =?utf-8?B?YndXcXBBMVd5cXdpWnZLem0reUJHSjZhU1g3VDI5ZzU5czdLaWJvMnJLSUUw?= =?utf-8?B?OFVwNzhNelhhbG5XV1NvME80Q3hnRk1kNmZoeE5zcWo3ZDMvSzBIK1pFc1dt?= =?utf-8?B?SDdSTEEyVHkwNnVzcXVJS2JXK2UxaXE0aDNrSjBZRTlNS3dBdFJMcHcxMGRD?= =?utf-8?B?SWhzR29MMXAzaEVuUUZyNXZmWXBVLzhrZmR4SkVSRE5xWjltZHZpZld0NFFK?= =?utf-8?B?K2VhQTc1RUxQSy9rM2h3U05zdnU0SERDWGplUkJsNWRpbFdWQ2V6TnhlTmo2?= =?utf-8?B?N0thTm9EOFA4M1IybXpZTGNPVnpKcWxQMlhCY1BaMkVnTnlSOVk1L25neFhn?= =?utf-8?B?L0cxd3Z3KzZQTmx0K05QWjBpbXRqZ3dmM3I0MDlWN0xCOVp6Yk1Ia3lHVFgx?= =?utf-8?B?TWRuNjUrdmJ1STdpYWlYRUU2RjBFRVFHWVF1T0RVbmtuRnVsYS82Y2FyemJq?= =?utf-8?B?TDJyb3F0TEVxalNtUWVDdmxZZDdhaTNvWHc5eWJMZm9nSzNQV2E1RWQ4VlBr?= =?utf-8?B?R1ppSXh6U1Fjc2huQWVoQUNqZFk0ODRHOXlMNmp3dzBsbExvMjlxV05NNHNm?= =?utf-8?B?K2FiRVhzSDBOK1VneXo3NUNCQ1VMSEtsdjFMNllxVmFWSUZ4ZGw5VlhZWWgy?= =?utf-8?B?L1E9PQ==?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: synopsys.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4791.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34740568-70d6-41c8-0157-08d9dac4ac7e X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2022 20:54:08.8426 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iRUGCkM7Jp2ercWANrOH3qKPmZm4L1mHtPG8cNHzFlscG84aCWp3bVSjDHZ+mIz+HdmvUf2kVk50V3wLd1ibTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2960 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_125416_290563_EAE5F0B8 X-CRM114-Status: GOOD ( 26.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Robert Hancock wrote: > On Tue, 2022-01-18 at 20:00 +0000, Thinh Nguyen wrote: >> Sean Anderson wrote: >>> Hi Thinh, >>> >>> On 1/18/22 2:46 PM, Thinh Nguyen wrote: >>>> Hi Sean, >>>> >>>> Baruch Siach wrote: >>>>> Hi Sean, Thinh, >>>>> >>>>> On Fri, Jan 14 2022, Sean Anderson wrote: >>>>>> This is a rework of patches 3-5 of [1]. It attempts to correctly >>>>>> program >>>>>> REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. >>>>>> Since >>>>>> we no longer need a special property duplicating this configuration, >>>>>> snps,ref-clock-period-ns is deprecated. >>>>>> >>>>>> Please test this! Patches 3/4 in this series have the effect of >>>>>> programming REFCLKPER and REFCLK_FLADJ on boards which already >>>>>> configure >>>>>> the "ref" clock. I have build tested, but not much else. >>>>>> >>>>>> [1] >>>>>> https://urldefense.com/v3/__https://lore.kernel.org/linux-usb/20220114044230.2677283-1-robert.hancock@calian.com/__;!!A4F2R9G_pg!M3zKxDZC9a_etqzXo7GSEMTHRWfc1wR_84wwM4-fShiA35CsGcxcTEffHPbprbdC4d2R$ >>>>>> >>>>> >>>>> Thinh, you suggested the dedicated DT property for the reference clock: >>>>> >>>>> >>>>> https://urldefense.com/v3/__https://lore.kernel.org/all/d5acb192-80b9-36f7-43f5-81f21c4e6ba0@synopsys.com/__;!!A4F2R9G_pg!M3zKxDZC9a_etqzXo7GSEMTHRWfc1wR_84wwM4-fShiA35CsGcxcTEffHPbprbpOFmvX$ >>>>> >>>>> >>>>> Can you comment on this series? >>>>> >>>> >>>> Unless there's a good way to pass this information for PCI devices, my >>>> opinion hasn't changed. (Btw, I don't think creating a dummy clock >>>> provider and its dummy ops is a good solution as seems to complicate and >>>> bloat the PCI glue drivers). >>> >>> Can you explain your situation a bit more? I'm not sure how you can >>> access a device tree property but not add a fixed-rate clock. >>> >>> --Sean >> >> Currently for dwc3 pci devices, we have glue drivers that create a >> platform_device with specific properties to pass to the dwc3 core >> driver. Without a ref clock property, we would need another way to pass >> this information to the core driver or another way for the dwc3 core >> driver to check for specific pci device's properties and quirks. > > We've used the device tree to instantiate/configure devices inside of a PCI > device, though obviously that only works on DT-based platforms, and for > hardware that's part of the board itself, not an add-in card. > > We've also used the MFD infrastructure to instantiate devices and device > properties inside a PCI device on x86, which can be used if the driver you are > instantiating uses the generic device property accessors and not the DT- > specific ones. That gets a bit dirty however - I don't think there's an easy > way to create properties that are references to other nodes, or more than a > single level deep heirarchy of nodes. > > For a use case like you're describing, it sounds like it would be better to > abstract away some of the core DWC3 code from reading the settings from DT > directly, so that the PCI devices can instantiate it and set the configuration > however they want, without having to worry about creating fake properties for > the core to read. I think that pattern has been used with some other drivers > such as AHCI? > Yes. It would be great if we can rework and abstract this. I'd need to review how AHCI handles it. It doesn't seem like a small task as it touches on multiple drivers. But if anyone can start this off, I can help further contribute/review. Thanks, Thinh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel