From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFF8C4338F for ; Fri, 6 Aug 2021 09:45:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAB5261040 for ; Fri, 6 Aug 2021 09:45:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EAB5261040 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=r0TMppIDJO12SpMw5+MnhRDcw0ECqwGVnYfLvzGVxNY=; b=rwdtTj809fzQr9HDNfpdLxsSUU S7BMeh29M8m6ZDCIFnBvhX2gOwFJsdbla2by3XglRoeDdAvQal8c81HaWMAA6kjVQ0YJJR0PhRiJG IwiEVPNFBY2jlMywOpn7PCTmSJzXLsFR0oLwFV8eWuaIHYdGJUdwU6EKguaP8CXeEzAE84DRSZ1nf sFUA+iEEcRmsM+5MLNTsm2BsRiEH4Znp4nzEAEfiEaIUg0w/GzfFV3Xlc/npL5O4/74oB/sGerO5w QzZr6n4zDDCYXEEw1H3baJ3386KZbWSxfsbKbG1bE5QiHngMIKjIEHRGAU1bfXKdRv8OM7SmZ8RJO 4+tEE0lQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBwOA-00C1Mq-Uy; Fri, 06 Aug 2021 09:43:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBwO7-00C1Ly-2O for linux-arm-kernel@lists.infradead.org; Fri, 06 Aug 2021 09:43:36 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D52F31B; Fri, 6 Aug 2021 02:43:29 -0700 (PDT) Received: from [10.57.40.41] (unknown [10.57.40.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 38AA43F719; Fri, 6 Aug 2021 02:43:27 -0700 (PDT) Subject: Re: [PATCH 6/6] perf cs-etm: Print the decoder name To: Leo Yan Cc: acme@kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, al.grant@arm.com, suzuki.poulose@arm.com, anshuman.khandual@arm.com, mike.leach@linaro.org, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org References: <20210721090706.21523-1-james.clark@arm.com> <20210721090706.21523-7-james.clark@arm.com> <20210731073037.GF7437@leoy-ThinkPad-X240s> From: James Clark Message-ID: <077ebe58-f692-9adb-9cb5-ed35a9b508c1@arm.com> Date: Fri, 6 Aug 2021 10:43:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210731073037.GF7437@leoy-ThinkPad-X240s> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210806_024335_208970_D4D02CB8 X-CRM114-Status: GOOD ( 14.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/07/2021 08:30, Leo Yan wrote: >> @@ -658,7 +658,7 @@ cs_etm_decoder__create_etm_decoder(struct cs_etm_decoder_params *d_params, >> >> return 0; >> } else if (d_params->operation == CS_ETM_OPERATION_PRINT) { >> - if (ocsd_dt_create_decoder(decoder->dcd_tree, decoder_name, >> + if (ocsd_dt_create_decoder(decoder->dcd_tree, decoder->decoder_name, >> OCSD_CREATE_FLG_PACKET_PROC, >> trace_config, &csid)) >> return -1; >> @@ -790,3 +790,8 @@ void cs_etm_decoder__free(struct cs_etm_decoder *decoder) >> decoder->dcd_tree = NULL; >> free(decoder); >> } >> + >> +const char *cs_etm_decoder__get_name(struct cs_etm_decoder *decoder) >> +{ >> + return decoder->decoder_name; >> +} > Maybe can consider to place this function into the header file with > "static inline" specifier. I tried this, but because the struct is defined in the .c file it can't be done without moving the struct to the header. It's also only used for the --dump-raw-trace path so performance isn't critical anyway. James > > Either way, this patch looks good to me: > > Reviewed-by: Leo Yan > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel