From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C9EC433E0 for ; Wed, 3 Jun 2020 13:43:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B1BE206C3 for ; Wed, 3 Jun 2020 13:43:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b5egB/dS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="DYVsXdCl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B1BE206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r1wRSjcbr8/knD+0gJDCRh5aAL7Db7I+le+vFeYtze4=; b=b5egB/dSrc4gAl3vBXJVpvrdD 6pDWfCHJh84P+uJE4YSodhw3PuStG0G9b4M5KFr8ZVicwTbyworax3mCOG9tcc3Rg46LzD8UJjgnh EEDwzW8Yy2xpkieNb7MHbqQTaK54S7K975ZS5d6r0qQ5iZ/00HOP3T0Dy8TOhd5ZZqIgHSzvNmnQP r+zdipE4uAFDfURARjcCTRDH21Osi8VTEe+PZAbAhn+GiuNTkS3GfUOfjV4Njl7i37+SqRmKa6XSg de3E8ePnx+2Ykz5SBMIFKBe8M/Dhn2iIu48hPSKZNAUYKYFYS8NELnzrRdMNaKmTXBuOAoPOT3Vs5 tKGMevpnA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgTfp-0006Z0-Rn; Wed, 03 Jun 2020 13:43:17 +0000 Received: from m43-7.mailgun.net ([69.72.43.7]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgTfm-0006YV-G9 for linux-arm-kernel@lists.infradead.org; Wed, 03 Jun 2020 13:43:16 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591191794; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=gowrDorcMB8/S/lw8VmQ9q/tzijZLKpas7NugxtZK+k=; b=DYVsXdCl2x4cyUcFZ07Pop98X0SoIrwf5rggfXVJOi86iI/H6qGc0U+hJ0Xy891igIRC/ApW p/2UpnIwUFfZZMc9yNGNp3Q7JQhWr5Qg5bOQbptKciLyW1/fpAx5cVh+E0Wn9X+sPoRoYih3 5nzZ9Howw2SSWSPmL/mUiJ/BSNQ= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n13.prod.us-west-2.postgun.com with SMTP id 5ed7a8efeca06aba7e4770b1 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 03 Jun 2020 13:43:11 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CAFBDC433A0; Wed, 3 Jun 2020 13:43:11 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id E6128C433C6; Wed, 3 Jun 2020 13:43:10 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 03 Jun 2020 19:13:10 +0530 From: Sai Prakash Ranjan To: Robin Murphy , Mike Leach Subject: Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF In-Reply-To: <1a5a6a6d-b86d-df45-cf91-7081e70d88a3@arm.com> References: <28123d1e19f235f97555ee36a5ed8b52d20cbdea.1590947174.git.saiprakash.ranjan@codeaurora.org> <20200601212858.GB24287@xps15> <6d759cc28628ea72767c1304883630eb@codeaurora.org> <4a09cd2e054836d85f2e024ca4435e91@codeaurora.org> <1a5a6a6d-b86d-df45-cf91-7081e70d88a3@arm.com> Message-ID: <07851ea3d1abfe60bb6c1761bf19f62f@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200603_064314_850012_201AAC78 X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Poirier , Suzuki K Poulose , linux-arm-msm@vger.kernel.org, Coresight ML , Linux Kernel Mailing List , Stephen Boyd , linux-arm-kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mike, On 2020-06-03 19:04, Robin Murphy wrote: > On 2020-06-03 14:22, Mike Leach wrote: >> Hi Sai, >> >> On Wed, 3 Jun 2020 at 13:14, Sai Prakash Ranjan >> wrote: >>> >>> Hi Mike, >>> >>> On 2020-06-03 16:57, Mike Leach wrote: >>>> Hi, >>>> >>>> On Wed, 3 Jun 2020 at 11:24, Sai Prakash Ranjan >>>> wrote: >>>>> >>>>> Hi Mike, >>>>> >>>>> Thanks again for looking at this. >>>>> >>>>> On 2020-06-03 03:42, Mike Leach wrote: >>>>> [...] >>>>> >>>>>>> >>>>>>> SMMU/IOMMU won't be able to do much here as it is the client's >>>>>>> responsiblity to >>>>>>> properly shutdown and SMMU device link just makes sure that >>>>>>> SMMU(supplier) shutdown is >>>>>>> called only after its consumers shutdown callbacks are called. >>>>>> >>>>>> I think this use case can be handled slightly differently than the >>>>>> general requirements for modular CoreSight drivers. >>>>>> >>>>>> What is needed here is a way of stopping the underlying ETR >>>>>> hardware >>>>>> from issuing data to the SMMU, until the entire device has been >>>>>> shut >>>>>> down, in a way that does not remove the driver, breaking existing >>>>>> references and causing a system crash. >>>>>> >>>>>> We could introduce a new mode to the ETR driver - e.g. >>>>>> CS_MODE_SHUTDOWN. >>>>>> >>>>>> At the end of the block tmc_shutdown(struct amba_device *adev), >>>>>> set >>>>>> drvdata->mode to CS_MODE_SHUTDOWN & remove the >>>>>> coresight_unregister(). >>>>>> This new mode can be used to prevent the underlying hardware from >>>>>> being able to restart until the device is re-powered. >>>>>> >>>>>> This mode can be detected in the code that enables / disables the >>>>>> ETR >>>>>> and handled appropriately (updates to tmc_enable_etr_sink and >>>>>> tmc_disable_etr_sink). >>>>>> This mode will persist until the device is re-started - but >>>>>> because we >>>>>> are on the device shutdown path this is not an issue. >>>>>> >>>>>> This should leave the CoreSight infrastructure stable until the >>>>>> drivers are shut down normally as part of the device power down >>>>>> process. >>>>>> >>>>> >>>>> Sounds good to me, but if the coresight_unregister() is the trouble >>>>> point >>>>> causing these crashes, then can't we just remove that from >>>>> tmc_shutdown() >>>>> callback? This would be like maintaining the same behaviour as now >>>>> where >>>>> on reboot/shutdown we basically don't do anything except for >>>>> disabling >>>>> ETR. >>>> >>>> No - the new mode prevents race conditions where the thread shutting >>>> down the SMMU does the ETR shutdown, but then another thread happens >>>> to be trying to start trace and restarts the ETR. >>>> It also prevents the condition Mathieu discussed where a thread >>>> might >>>> be attempting to shutdown trace - this could try to disable the >>>> hardware again re-releasing resources/ re-flushing and waiting for >>>> stop. >>>> >>> >>> I do not think there will a race between SMMU shutdown and ETR >>> shutdown. >>> Driver core takes care of calling SMMU shutdown after its consumer >>> shutdown callbacks via device link, otherwise there would already be >>> bugs in all other client drivers. >>> >> >> I am not saying there could be a race between tmc_shutdowm and >> Smmu_shutdown - there may be a case if the coresight_disable_path >> sequence is running and gets to the point of disabling the ETR after >> the SMMU callback has disabled it. > > I'm confused now - there is no "SMMU callback", we're talking about > the system-wide cleanup from kernel_shutdown_prepare() or > kernel_restart_prepare(). As far as I'm aware userspace should be long > gone by that point, so although trace may have been left running, the > chance of racing against other driver operations seems pretty > unlikely. > As Robin said, it is not SMMU callback but the normal reboot/shutdown flow and race is unlikely at that point. tmc_shutdown() platform_drv_shutdown() device_shutdown() kernel_restart_prepare() kernel_restart() If I am not clear enough, first all the consumer shutdown callbacks of SMMU are called like above tmc_shutdown() and then we call the arm_smmu_device_shutdown(), this ordering is ensured by the device links. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel