From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A351C6FA82 for ; Thu, 22 Sep 2022 09:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aoHmwM1JD7JMaO/ZvGczcGxj59Bd4TwZqmyakUAhZRo=; b=H4h5JI3eRJuIkh 1X6b3aJbHOgVk5RqDvi3C8Q/WBRwoYYtEamm61bSnFsFe535gozQ9uSeHFZvvnM90qBtZsUjVt2gP ScgbHhmMdflMUwiULa3YjUkxJfMT0qfyjpmEG0ve7JfNlvlyANkzJsy1izUAUiIjS3SvRZE88BPYu RtPQ+XI2rFPO5HIfx3PJg2mrHAWNidzY0wYu/QNgyd0HB9+4K3t10wu8oaJjG4QdZlqF+F9PfvbHm AXHH0E0v7mV/RwdJWD3Xe3EP2vuB+VX3gfVNUgh9cuUZ6tYUipICXGYFae1k1D40gZucthRSBZpC/ ptAihOIP0iioCszsoauQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obIR4-00EQrx-VG; Thu, 22 Sep 2022 09:24:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obI81-00ELIF-B1 for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 09:04:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EBF8106F; Thu, 22 Sep 2022 02:04:19 -0700 (PDT) Received: from [10.57.1.91] (unknown [10.57.1.91]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 464263F73D; Thu, 22 Sep 2022 02:04:11 -0700 (PDT) Message-ID: <07d37df2-246e-70ea-4a9f-e33354d8864d@arm.com> Date: Thu, 22 Sep 2022 10:04:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/1] arm64: defconfig: Add Coresight as module Content-Language: en-US To: Mathieu Poirier , Mark Brown Cc: coresight@lists.linaro.org, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, linux-kernel@vger.kernel.org, Will Deacon References: <20220921140535.152627-1-james.clark@arm.com> <20220921140535.152627-2-james.clark@arm.com> <20220921164622.GA1124503@p14s> From: James Clark In-Reply-To: <20220921164622.GA1124503@p14s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_020417_507592_8247FFA7 X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/09/2022 17:46, Mathieu Poirier wrote: > On Wed, Sep 21, 2022 at 04:26:59PM +0100, Mark Brown wrote: >> On Wed, Sep 21, 2022 at 03:05:35PM +0100, James Clark wrote: >> >>> +CONFIG_CORESIGHT_CTI=m >>> +CONFIG_CORESIGHT_CTI_INTEGRATION_REGS=y >> > > I agree - integration registers should not be enabled by default. > >> Do we want this turned on by default? According to the >> description it's a bit dangerous and it's exposed via sysfs >> rather than debugfs. > > Should I disable just CONFIG_CORESIGHT_CTI_INTEGRATION_REGS or CONFIG_CORESIGHT_CTI as well? There are other writable registers exposed via sysfs outside of these two options, so I wanted to check if it's just the integration registers that are the issue. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel