Re: [PATCH 1/1] dt-bindings: input: touchscreen: convert lpc32xx-tsc.txt to yaml format

[Vladimir Zapolskiy <vz@mleia.com>]

On 6/24/25 23:11, Frank Li wrote:
> Convert lpc32xx-tsc.txt to yaml format.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>   .../input/touchscreen/lpc32xx-tsc.txt         | 16 --------
>   .../input/touchscreen/nxp,lpc3220-tsc.yaml    | 39 +++++++++++++++++++
>   2 files changed, 39 insertions(+), 16 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
>   create mode 100644 Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt b/Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
> deleted file mode 100644
> index 41cbf4b7a670d..0000000000000
> --- a/Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -* NXP LPC32xx SoC Touchscreen Controller (TSC)
> -
> -Required properties:
> -- compatible: must be "nxp,lpc3220-tsc"
> -- reg: physical base address of the controller and length of memory mapped
> -  region.
> -- interrupts: The TSC/ADC interrupt
> -
> -Example:
> -
> -	tsc@40048000 {
> -		compatible = "nxp,lpc3220-tsc";
> -		reg = <0x40048000 0x1000>;
> -		interrupt-parent = <&mic>;
> -		interrupts = <39 0>;
> -	};
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml
> new file mode 100644
> index 0000000000000..34cb8b68216aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/nxp,lpc3220-tsc.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/nxp,lpc3220-tsc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP LPC32xx SoC Touchscreen Controller (TSC)
> +
> +maintainers:
> +  - Frank Li <Frank.Li@nxp.com>
> +
> +properties:
> +  compatible:
> +    const: nxp,lpc3220-tsc
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts

"clocks" property is mandatory, the old scheme is broken in this sense.

Please either fix the old scheme before conversion, or at least mention
the difference between the old scheme and the new one in the commit
message, and please add "clocks" to the list of required properties.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    touchscreen@40048000 {
> +        compatible = "nxp,lpc3220-tsc";
> +        reg = <0x40048000 0x1000>;
> +        interrupt-parent = <&mic>;
> +        interrupts = <39 0>;
> +    };

--
Best wishes,
Vladimir