linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: S5PV210: Remove camera support from mach-goni.c
Date: Fri, 02 May 2014 15:07:28 +0900	[thread overview]
Message-ID: <081001cf65cc$cbef8700$63ce9500$@samsung.com> (raw)
In-Reply-To: <1397583272-28295-2-git-send-email-s.nawrocki@samsung.com>

Sylwester Nawrocki wrote:
> 
> S5PV210 is going to get DT support, so we can remove the camera
> bits from the only board using camera on S5PV210. This allows to
> clean the exynos4-is driver by dropping code for non-dt platforms.
> This patch can be dropped if a patch removing the whole board
> file is applied first.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>

Hi Sylwester,

Cleanup is always welcome ;-)

I think, when this series is ready for mainline, this will be handled in
media tree. So,

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Thanks,
Kukjin

> ---
>  arch/arm/mach-s5pv210/mach-goni.c |   51
---------------------------------
> ----
>  1 file changed, 51 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-
> s5pv210/mach-goni.c
> index b41a38a..6c719ec 100644
> --- a/arch/arm/mach-s5pv210/mach-goni.c
> +++ b/arch/arm/mach-s5pv210/mach-goni.c
> @@ -49,11 +49,6 @@
>  #include <plat/clock.h>
>  #include <plat/samsung-time.h>
>  #include <plat/mfc.h>
> -#include <plat/camport.h>
> -
> -#include <media/v4l2-mediabus.h>
> -#include <media/s5p_fimc.h>
> -#include <media/noon010pc30.h>
> 
>  #include "common.h"
> 
> @@ -285,14 +280,6 @@ static void __init goni_tsp_init(void)
>  /* USB OTG */
>  static struct s3c_hsotg_plat goni_hsotg_pdata;
> 
> -static void goni_camera_init(void)
> -{
> -	s5pv210_fimc_setup_gpio(S5P_CAMPORT_A);
> -
> -	/* Set max driver strength on CAM_A_CLKOUT pin. */
> -	s5p_gpio_set_drvstr(S5PV210_GPE1(3), S5P_GPIO_DRVSTR_LV4);
> -}
> -
>  /* MAX8998 regulators */
>  #if defined(CONFIG_REGULATOR_MAX8998) ||
> defined(CONFIG_REGULATOR_MAX8998_MODULE)
> 
> @@ -825,34 +812,6 @@ static void goni_setup_sdhci(void)
>  	s3c_sdhci2_set_platdata(&goni_hsmmc2_data);
>  };
> 
> -static struct noon010pc30_platform_data noon010pc30_pldata = {
> -	.clk_rate	= 16000000UL,
> -	.gpio_nreset	= S5PV210_GPB(2), /* CAM_CIF_NRST */
> -	.gpio_nstby	= S5PV210_GPB(0), /* CAM_CIF_NSTBY */
> -};
> -
> -static struct i2c_board_info noon010pc30_board_info = {
> -	I2C_BOARD_INFO("NOON010PC30", 0x60 >> 1),
> -	.platform_data = &noon010pc30_pldata,
> -};
> -
> -static struct fimc_source_info goni_camera_sensors[] = {
> -	{
> -		.mux_id		= 0,
> -		.flags		= V4L2_MBUS_PCLK_SAMPLE_FALLING |
> -				  V4L2_MBUS_VSYNC_ACTIVE_LOW,
> -		.fimc_bus_type	= FIMC_BUS_TYPE_ITU_601,
> -		.board_info	= &noon010pc30_board_info,
> -		.i2c_bus_num	= 0,
> -		.clk_frequency	= 16000000UL,
> -	},
> -};
> -
> -static struct s5p_platform_fimc goni_fimc_md_platdata __initdata = {
> -	.source_info	= goni_camera_sensors,
> -	.num_clients	= ARRAY_SIZE(goni_camera_sensors),
> -};
> -
>  /* Audio device */
>  static struct platform_device goni_device_audio = {
>  	.name = "smdk-audio",
> @@ -874,10 +833,6 @@ static struct platform_device *goni_devices[]
> __initdata = {
>  	&s5p_device_mixer,
>  	&s5p_device_sdo,
>  	&s3c_device_i2c0,
> -	&s5p_device_fimc0,
> -	&s5p_device_fimc1,
> -	&s5p_device_fimc2,
> -	&s5p_device_fimc_md,
>  	&s3c_device_hsmmc0,
>  	&s3c_device_hsmmc1,
>  	&s3c_device_hsmmc2,
> @@ -946,14 +901,8 @@ static void __init goni_machine_init(void)
>  	/* FB */
>  	s3c_fb_set_platdata(&goni_lcd_pdata);
> 
> -	/* FIMC */
> -	s3c_set_platdata(&goni_fimc_md_platdata,
> sizeof(goni_fimc_md_platdata),
> -			 &s5p_device_fimc_md);
> -
>  	s3c_hsotg_set_platdata(&goni_hsotg_pdata);
> 
> -	goni_camera_init();
> -
>  	/* SPI */
>  	spi_register_board_info(spi_board_info, ARRAY_SIZE(spi_board_info));
> 
> --
> 1.7.9.5

  reply	other threads:[~2014-05-02  6:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 17:34 [PATCH 0/5] Exynos4 SoC camera subsystem driver cleanups Sylwester Nawrocki
2014-04-15 17:34 ` [PATCH 1/5] ARM: S5PV210: Remove camera support from mach-goni.c Sylwester Nawrocki
2014-05-02  6:07   ` Kukjin Kim [this message]
2014-05-08 16:09     ` Sylwester Nawrocki
2014-04-15 17:34 ` [PATCH 2/5] exynos4-is: Fix compilation for !CONFIG_COMMON_CLK Sylwester Nawrocki
2014-04-15 17:34 ` [PATCH 3/5] exynos4-is: Remove support for non-dt platforms Sylwester Nawrocki
2014-04-15 17:34 ` [PATCH 4/5] exynos4-is: Remove requirement for "simple-bus" compatible Sylwester Nawrocki
2014-04-16 15:34   ` Rob Herring
     [not found]     ` <534EBB88.9020109@samsung.com>
     [not found]       ` <CAL_JsqKH8o-0H4+2jv-6xh96Twh9UCXZV+LtmiUGHJmhUxCUVA@mail.gmail.com>
2014-04-17  9:29         ` Sylwester Nawrocki
2014-04-15 17:34 ` [PATCH 5/5] ARM: dts: exynos4: Remove simple-bus compatible from camera subsystem nodes Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='081001cf65cc$cbef8700$63ce9500$@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).