From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06305C67861 for ; Fri, 5 Apr 2024 10:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=35Etbxc2laL92T7K2Ii9kXChMG0ossEYAEwkwVvl3ug=; b=KcI1SfLEFF0mQW QSiAGrG0BrwFT+z9DrvIDi/4+oHuEypOIRrK+NjSBy7snBele5ksNnjmCP/ArHLVd0m92VbdRfqV3 cjzt7AhNi/sgm4RUGcappLwO+j8qNz4kZXpBbN3pJI6/xWD6OdSjB51HbMt94d7oC5NH8hRhiLXlG u44ozlkaILpCZfb7OgRGXRK4LPZDxBrSN4lGp1YVR+utFIuSHuJx1j+L/RVM1eHh5J01f8UYhQigH /6sEIxAQwtr+CWkXqN7objV9UnZtfok2750CQBHgmaekbbHdqz34V6/qX+1GopQvvb7vjcBhQnPI2 3AMaDXoQ//TamS/qW0Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsgyG-00000006TUc-3OcW; Fri, 05 Apr 2024 10:38:56 +0000 Received: from mail-108-mta169.mxroute.com ([136.175.108.169]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsgyC-00000006TTH-2Ktx for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 10:38:54 +0000 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta169.mxroute.com (ZoneMTA) with ESMTPSA id 18eadd248db0003bea.009 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 05 Apr 2024 10:33:43 +0000 X-Zone-Loop: ad1e1a1c4ed428a3bc8ef403338d807482026e6e9285 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vfGoyAWCyKZOHSAUcGDkEoz4paY7t5qH+0okM64n3Do=; b=pATTLDVLYKydxuA4/oMU+IXM8X evupdRWiPyqRs4QJYB3u83H2KriInjeFUXtv7UFyjn6jkcDdJywE8kQQFpc+NqypqFdtPp/GqgeSd /JArjSTKWOw4SHSRhZtEcsmwMEB27salHAMo/GhT7wMAzmOnETj//CUNv+jnhskVyBq40F4+UH5UH 7OJ7pX+RVUagog04vV55RXxUCrj1Yzra14eOEvWyRmA7JrKFBfxmFmQE8Ra7esLdGtQ/ZyM94ymdX Ztl/Ad9Q6l8RKhYyN45hZ/K36FNA5jhYIhMrhkxuoUbDzmOduRhdl/cAIENpmkLIPPR9hNlD+gaZK UpvwQaAw==; Message-ID: <082190a8-7ac5-4240-9a16-6b9168c67d57@luigi311.com> Date: Fri, 5 Apr 2024 04:33:38 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 21/25] drivers: media: i2c: imx258: Use macros To: Sakari Ailus Cc: linux-media@vger.kernel.org, dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pavel@ucw.cz, phone-devel@vger.kernel.org, Ondrej Jirman References: <20240403150355.189229-1-git@luigi311.com> <20240403150355.189229-22-git@luigi311.com> Content-Language: en-US From: Luis Garcia In-Reply-To: X-Authenticated-Id: git@luigi311.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_033852_753587_24688845 X-CRM114-Status: GOOD ( 19.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/4/24 00:46, Sakari Ailus wrote: > On Wed, Apr 03, 2024 at 01:17:26PM -0600, Luigi311 wrote: >> On 4/3/24 10:23, Sakari Ailus wrote: >>> Hi Luis, >>> >>> On Wed, Apr 03, 2024 at 09:03:50AM -0600, git@luigi311.com wrote: >>>> From: Luis Garcia >>>> >>>> Use understandable macros instead of raw values. >>>> >>>> Signed-off-by: Ondrej Jirman >>>> Signed-off-by: Luis Garcia >>>> --- >>>> drivers/media/i2c/imx258.c | 434 ++++++++++++++++++------------------- >>>> 1 file changed, 207 insertions(+), 227 deletions(-) >>>> >>>> diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c >>>> index e2ecf6109516..30352c33f63c 100644 >>>> --- a/drivers/media/i2c/imx258.c >>>> +++ b/drivers/media/i2c/imx258.c >>>> @@ -33,8 +33,6 @@ >>>> #define IMX258_VTS_30FPS_VGA 0x034c >>>> #define IMX258_VTS_MAX 65525 >>>> >>>> -#define IMX258_REG_VTS 0x0340 >>>> - >>>> /* HBLANK control - read only */ >>>> #define IMX258_PPL_DEFAULT 5352 >>>> >>>> @@ -90,6 +88,53 @@ >>>> #define IMX258_PIXEL_ARRAY_WIDTH 4208U >>>> #define IMX258_PIXEL_ARRAY_HEIGHT 3120U >>>> >>>> +/* regs */ >>>> +#define IMX258_REG_PLL_MULT_DRIV 0x0310 >>>> +#define IMX258_REG_IVTPXCK_DIV 0x0301 >>>> +#define IMX258_REG_IVTSYCK_DIV 0x0303 >>>> +#define IMX258_REG_PREPLLCK_VT_DIV 0x0305 >>>> +#define IMX258_REG_IOPPXCK_DIV 0x0309 >>>> +#define IMX258_REG_IOPSYCK_DIV 0x030b >>>> +#define IMX258_REG_PREPLLCK_OP_DIV 0x030d >>>> +#define IMX258_REG_PHASE_PIX_OUTEN 0x3030 >>>> +#define IMX258_REG_PDPIX_DATA_RATE 0x3032 >>>> +#define IMX258_REG_SCALE_MODE 0x0401 >>>> +#define IMX258_REG_SCALE_MODE_EXT 0x3038 >>>> +#define IMX258_REG_AF_WINDOW_MODE 0x7bcd >>>> +#define IMX258_REG_FRM_LENGTH_CTL 0x0350 >>>> +#define IMX258_REG_CSI_LANE_MODE 0x0114 >>>> +#define IMX258_REG_X_EVN_INC 0x0381 >>>> +#define IMX258_REG_X_ODD_INC 0x0383 >>>> +#define IMX258_REG_Y_EVN_INC 0x0385 >>>> +#define IMX258_REG_Y_ODD_INC 0x0387 >>>> +#define IMX258_REG_BINNING_MODE 0x0900 >>>> +#define IMX258_REG_BINNING_TYPE_V 0x0901 >>>> +#define IMX258_REG_FORCE_FD_SUM 0x300d >>>> +#define IMX258_REG_DIG_CROP_X_OFFSET 0x0408 >>>> +#define IMX258_REG_DIG_CROP_Y_OFFSET 0x040a >>>> +#define IMX258_REG_DIG_CROP_IMAGE_WIDTH 0x040c >>>> +#define IMX258_REG_DIG_CROP_IMAGE_HEIGHT 0x040e >>>> +#define IMX258_REG_SCALE_M 0x0404 >>>> +#define IMX258_REG_X_OUT_SIZE 0x034c >>>> +#define IMX258_REG_Y_OUT_SIZE 0x034e >>>> +#define IMX258_REG_X_ADD_STA 0x0344 >>>> +#define IMX258_REG_Y_ADD_STA 0x0346 >>>> +#define IMX258_REG_X_ADD_END 0x0348 >>>> +#define IMX258_REG_Y_ADD_END 0x034a >>>> +#define IMX258_REG_EXCK_FREQ 0x0136 >>>> +#define IMX258_REG_CSI_DT_FMT 0x0112 >>>> +#define IMX258_REG_LINE_LENGTH_PCK 0x0342 >>>> +#define IMX258_REG_SCALE_M_EXT 0x303a >>>> +#define IMX258_REG_FRM_LENGTH_LINES 0x0340 >>>> +#define IMX258_REG_FINE_INTEG_TIME 0x0200 >>>> +#define IMX258_REG_PLL_IVT_MPY 0x0306 >>>> +#define IMX258_REG_PLL_IOP_MPY 0x030e >>>> +#define IMX258_REG_REQ_LINK_BIT_RATE_MBPS_H 0x0820 >>>> +#define IMX258_REG_REQ_LINK_BIT_RATE_MBPS_L 0x0822 >>>> + >>>> +#define REG8(a, v) { a, v } >>>> +#define REG16(a, v) { a, ((v) >> 8) & 0xff }, { (a) + 1, (v) & 0xff } >>> >>> The patch is nice but these macros are better replaced by the V4L2 CCI >>> helper that also offers register access functions. Could you add a patch to >>> convert the driver to use it (maybe after this one)? >>> >> >> Ohh perfect, using something else would be great. Ill go ahead and see >> if I can get that working. > > Thanks. It may be easier to just do it in this one actually. Up to you. > I've made the swap but looks like its not playing nice with my ppp, its causing a crash and showing a call trace as soon as it does its first read to check the identity. I went in and dropped the cci_read and left it with the original implementation and I'm getting a very similar crash with cci_write too so it looks like its not liking how I'm implementing it. Looking at the few other drivers that were swapped over to use that, I don't seem to be missing anything. It's a big change so its not really something I can describe what I've changed but I do have the change on my github here https://github.com/luigi311/linux/commit/840593acb20eee87ce361e6929edf51eefbbe737 if you can provide some guidance, if not I can skip this change all together and we can do a separate attempt at swapping over to it. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel