From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A554DC433E1 for ; Wed, 15 Jul 2020 10:25:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7281920657 for ; Wed, 15 Jul 2020 10:25:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fOdyQRGi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=toradex.com header.i=@toradex.com header.b="TIo6NaLV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7281920657 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=toradex.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U+yKS2hR5OXq92sk/nO3bn6uDyJA3zTHY8JWXeu3Gyo=; b=fOdyQRGitaLSpoUK0s1AIJFK7 8s0a1SNGSkmK4oVxvq0YNi7hI2Z34ieqvAzvM3P3CNnehpx8wMEVc7c7l/oo78Y9zoyugnzAEiWvj VAHYFrUg83FgS6EA6e7T4UKU4QiuxgrJnWqRkVbWAPP+QyGqZ07c9Q6uWDs0fQ2CTtCBp2etqudQm eaguHZhX9jpT91jiENp5oX/yktuy1he7YdTyVdm8bA6w0O+i7jO+NusDOi4Q527e6MjXpOEz630UP iN2R50H64/5nUuUYsrzVn9yryXpZ+fea3sbx9K4W15FCKuiy/d2XE7sxQIIgbQKO832hcGbewV+p7 vPXqgTm1w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jveZr-00077W-Pd; Wed, 15 Jul 2020 10:23:51 +0000 Received: from mail-vi1eur05on2115.outbound.protection.outlook.com ([40.107.21.115] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jveZp-00076S-7z for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 10:23:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vh+OnCKXlojKRuydC92DXV0ZAPsuGLgG4FD/ldfaTSi8YMC0RtWTyiMceME5l05EVvDpcp+tMWSVNcQ2987ClufccQDbUQAaQhVJV8oYN3Z3rriQbz1Z92Y6CQE27Tvr5tQCaup4DqI4QC80eapCxVlWFs07QkFnkcThwU9k5SKD0+a/oUqfMd7YwoCjvB02sZyFOIVnxTZYD7F7NpboLpwpJHBvonRZXjrOb4yWHYPBrXkkqyokMCFbYzI7M9sC75fmBPbvUx19bLL1Ep9znRYFpAlXlxw6gg0AkALAoG5dWlDewsjygnIPQr7lXR4sE2zqbFEyC7i/gyVvxPqOlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sfNsCcycx6W0X5eCr6pm+4h6ep2HJ2ebNkTLYTRaZqs=; b=DYG2mLobBEACFuSuuoatX8ZaFEKObjT1OjDHEY3f/55HS3AFeOtCPzQ9CjGPeWnuupEnxjzfTJbfO2683e89pMgFqutPZVqSV9z+SjHYyVsGeJ2OnrhPzM9RKT9dSU4D+xooY+LZ12kvleaUf0/vUY2yr2ZtwBcZt7zT8Bbf3YANB3QgnUiuyDshVf8JQ+S5Qgf/xBjDHHJEN6u+DybGrJtH2b7XuYL+PxTpZUjr7WpHRNaTvBOZM+kpOw5z8ik2YvDNk0ko5J17Pxjieq1yu3bkIXbIeQBbzuQ1U3suHZsSh8ctMAu+keXO9hMZ38x9Rt3JBpxIYCoM29bNAIz19w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=toradex.com; dmarc=pass action=none header.from=toradex.com; dkim=pass header.d=toradex.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toradex.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sfNsCcycx6W0X5eCr6pm+4h6ep2HJ2ebNkTLYTRaZqs=; b=TIo6NaLVDehlIn8PmLWVwsYIqMXpbz3gkAGUlTWeI1yicBdMqxOReY62NsKb3oAmZorEAPBfNhJAbEIibTQ1yhoLZ+bEPqRSbPdZEWrKk02cXItfggkloKPBESy/3xMFGbUYMGc1AyCGtjEF6kkurV3C7dl4XFThAUVCSc7O6JM= Received: from AM6PR05MB6120.eurprd05.prod.outlook.com (2603:10a6:20b:a8::25) by AM6PR05MB5799.eurprd05.prod.outlook.com (2603:10a6:20b:93::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Wed, 15 Jul 2020 10:23:45 +0000 Received: from AM6PR05MB6120.eurprd05.prod.outlook.com ([fe80::1d81:6a9b:8c26:3b7d]) by AM6PR05MB6120.eurprd05.prod.outlook.com ([fe80::1d81:6a9b:8c26:3b7d%4]) with mapi id 15.20.3195.018; Wed, 15 Jul 2020 10:23:45 +0000 From: Philippe Schenker To: "peter.chen@nxp.com" , "devicetree@vger.kernel.org" , "linux-usb@vger.kernel.org" , "shawnguo@kernel.org" , "robh+dt@kernel.org" Subject: Re: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm Thread-Topic: [PATCH v2 2/3] usb: chipidea: imx: support disabling runtime-pm Thread-Index: AQHWWfIMLexdmM4+M0C6zPGY8HP2U6kH0FqAgACfygA= Date: Wed, 15 Jul 2020 10:23:45 +0000 Message-ID: <08251297f72fe745be43205d0a73631f009681cc.camel@toradex.com> References: <20200714151822.250783-1-philippe.schenker@toradex.com> <20200714151822.250783-2-philippe.schenker@toradex.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.3 authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=toradex.com; x-originating-ip: [31.10.206.124] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c899d077-cda1-471a-057f-08d828a927c6 x-ms-traffictypediagnostic: AM6PR05MB5799: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LFzGRkqCDUgqS6tadD+6DaeocC2hjDn3iiCeJcMIdqxYFPjGm6qOdbijCMeJJcRX+Xo2Z9Sph/Kg6P2qyW6iVktxbVcgxu2XMPbaFZzMMSf5agJd1Z9PjICxKuP1IE/jhQGamgPZpvg/7R5ugRXYO2wybqVT43tQavNSqBzvHjvDw6gV+1QP8cSZH5EIPxximMSqEIA0imQdCt4IRX9CC8HKuvLSgW2D+6Nz4jesmFmgtLkQuThePoCFKENDkw0LgMxwW15BdRyscOe6UZ0KnLNcfEasivBvlwPD6Kx0E4423e3JgkawpLhZCNG5NkvaovZp0WBcEJLaxsMwbMJV9g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB6120.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(39850400004)(366004)(346002)(376002)(36756003)(6486002)(110136005)(54906003)(5660300002)(8936002)(6506007)(44832011)(316002)(7416002)(86362001)(2906002)(66946007)(4326008)(66476007)(64756008)(66446008)(2616005)(91956017)(478600001)(8676002)(83380400001)(186003)(6512007)(26005)(76116006)(66556008)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: LqPrDxD3LFgSg7OFXm23NnnezDo6jW4uQrGv9DrKmo6wv1b9JD3+3CNYWCKQ5om45GFdWiRHs1dNZqurhsJ1ebfNksKH4YlxFUK619LuE6obr5NaspinRaHy13p5NqRUjCtfCZZqjiONXbrcRnqPToTiWrhyZ4A4Ax9wHIwh6ZEkT3HTGbRCm3h2tPCEsONFFlS8/j6peJWx4qHXyUbLFGKODB8r+7zAcUCjdNtZ9jroWbfFeCBH4Hkns+jMkza/iS96Xu3dptPB7NICuEAXDDWbmvrEKMoNR1oBlgWSj/OF5X4z6QrS2CpVb3kFSCevkZL0J5e7d+MRluvubEbBE/0RpbXpS98BCRfNdE0H85ghHHvL5c4tzoIwxYdREmKO1EdE0MSYebB8oDby68JiS0TsZzP3/F8oS1ALKIKBo2svhPAT3Hf51XK08AZKlCmbF6doaA8fCgLDBaGIi/M8fIU5ui+pzB0l4R8IaCfFX40= x-ms-exchange-transport-forked: True Content-ID: MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR05MB6120.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c899d077-cda1-471a-057f-08d828a927c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2020 10:23:45.3798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kDsL+PVHs/D/yvIXmQ51JDdhNU0mxhAA+UoiYpf/5IzxXNNGezwB+mp1snYKgQ1U8wKnNFYzks/8272Oj/Afwrj+8qsFdqBa32L/bDgW+oA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5799 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_062349_421757_D703AC89 X-CRM114-Status: GOOD ( 25.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "gregkh@linuxfoundation.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "linux-imx@nxp.com" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-07-15 at 00:51 +0000, Peter Chen wrote: > > > The Toradex Colibri iMX6ULL board has a special USB hardware design. > > With runtime-pm enabled USB reset itself continuously. Furthermore > > the OTG port > > is also not enumerating devices if the Chipidea IP is in runtime > > sleep mode and a > > device or host gets plugged in. > > > > Hi Philippe, > > You may describe the detail what's the special USB hardware design for > your board, If I only knew the root-cause of that problem - unfortunately I don't. That's also why I have such a hard time to describe it. > and why it causes the problem, and why disable runtime pm could fix > this issue, then, I cannot provide the 'why' part yet. I'll try something more and hope I can provide you guys with the exact description. > the other users could know if it could apply to their platforms or not > in future. I only found out about it because you were pointing me in that direction. I debugged for hours now and didn't came to the root-cause of the issue. I think to really understand it I would need to know much more about the Chipidea IP. I'll get back to you guys with a proposal for a new description. Philippe > > Peter > > > This patch adds the opportunity to disable Runtime Power Management > > from > > devicetree > > > > Signed-off-by: Philippe Schenker > > > > --- > > > > Changes in v2: > > - Change commit message to tell the use case for Colibri iMX6ULL > > > > drivers/usb/chipidea/ci_hdrc_imx.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c > > b/drivers/usb/chipidea/ci_hdrc_imx.c > > index 5ae16368a0c7..5078d0695eb7 100644 > > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c > > @@ -434,6 +434,9 @@ static int ci_hdrc_imx_probe(struct > > platform_device *pdev) > > usb_phy_init(pdata.usb_phy); > > } > > > > + if (of_property_read_bool(np, "disable-runtime-pm")) > > + pdata.flags &= ~CI_HDRC_SUPPORTS_RUNTIME_PM; > > + > > if (pdata.flags & CI_HDRC_SUPPORTS_RUNTIME_PM) > > data->supports_runtime_pm = true; > > > > -- > > 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel