linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Samsung: Move fimc plat. device from board files to plat-samsung
Date: Fri, 14 Oct 2011 16:13:50 +0900	[thread overview]
Message-ID: <085e01cc8a40$d31a54c0$794efe40$%kim@samsung.com> (raw)
In-Reply-To: <1318433485-1757-1-git-send-email-s.nawrocki@samsung.com>

Sylwester Nawrocki wrote:
> 
> Move the platform device definitions from boards code to plat-samsung
> to avoid multiple instances when multiple board support is compiled in.
> The boards should select at least S5P_DEV_FIMC0 to enable FIMC support.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Hi Kgene,
> 
> To decrease overall diff size, if it's not too late yet, you might want to
> squash parts of this patch with previous commits:
> 
Hi Sylwester,

Sorry it's late to rebase following which are included in
next-samsung-devel-2 branch and already it has been sent to arm-soc.

> 0513218 ARM: S5PV210: Add support for M-5MOLS image sensor on
> UNIVERSAL_C210
> 39aefab ARM: S5PV210: Add support for NOON010PC30 sensor on GONI board
> 
> Here is the optional new patch summary:
> 
> ARM: Samsung: Add fimc platform device for s5p-fimc media device driver
> 
> The s5p-fimc driver now creates an aggregate media device which is bound
> to "s5p-fimc-md" platform device. This patch adds such a platform device
> instance to be registered by each board that requires FIMC device support.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> 
> Sorry for the noise.
> 
> Regards,
> Sylwester
> ---
>  arch/arm/mach-exynos4/mach-universal_c210.c |    5 -----
>  arch/arm/mach-s5pv210/mach-goni.c           |    5 -----
>  arch/arm/plat-samsung/devs.c                |    5 +++++
>  arch/arm/plat-samsung/include/plat/devs.h   |    1 +
>  4 files changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos4/mach-universal_c210.c b/arch/arm/mach-
> exynos4/mach-universal_c210.c
> index 18cf5c7..2096c8b 100644
> --- a/arch/arm/mach-exynos4/mach-universal_c210.c
> +++ b/arch/arm/mach-exynos4/mach-universal_c210.c
> @@ -920,11 +920,6 @@ static struct s5p_platform_fimc fimc_md_platdata = {
>  	.num_clients	= ARRAY_SIZE(universal_camera_sensors),
>  };
> 
> -struct platform_device s5p_device_fimc_md = {
> -	.name	= "s5p-fimc-md",
> -	.id	= -1,
> -};
> -
>  static struct gpio universal_camera_gpios[] = {
>  	{ GPIO_CAM_LEVEL_EN(1),	GPIOF_OUT_INIT_HIGH,
> "CAM_LVL_EN1" },
>  	{ GPIO_CAM_LEVEL_EN(2),	GPIOF_OUT_INIT_LOW,
> "CAM_LVL_EN2" },
> diff --git a/arch/arm/mach-s5pv210/mach-goni.c
b/arch/arm/mach-s5pv210/mach-
> goni.c
> index 01e4867..61da205 100644
> --- a/arch/arm/mach-s5pv210/mach-goni.c
> +++ b/arch/arm/mach-s5pv210/mach-goni.c
> @@ -849,11 +849,6 @@ struct s5p_platform_fimc goni_fimc_md_platdata
> __initdata = {
>  	.num_clients	= ARRAY_SIZE(goni_camera_sensors),
>  };
> 
> -struct platform_device s5p_device_fimc_md = {
> -	.name		= "s5p-fimc-md",
> -	.id		= -1,
> -};
> -
>  static struct platform_device *goni_devices[] __initdata = {
>  	&s3c_device_fb,
>  	&s5p_device_onenand,
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index cb6fd9e..4ca8b57 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -204,6 +204,11 @@ struct platform_device s5p_device_fimc0 = {
>  		.coherent_dma_mask	= DMA_BIT_MASK(32),
>  	},
>  };
> +
> +struct platform_device s5p_device_fimc_md = {
> +	.name	= "s5p-fimc-md",
> +	.id	= -1,
> +};
>  #endif /* CONFIG_S5P_DEV_FIMC0 */
> 
>  #ifdef CONFIG_S5P_DEV_FIMC1
> diff --git a/arch/arm/plat-samsung/include/plat/devs.h b/arch/arm/plat-
> samsung/include/plat/devs.h
> index 8f19241..ab633c9 100644
> --- a/arch/arm/plat-samsung/include/plat/devs.h
> +++ b/arch/arm/plat-samsung/include/plat/devs.h
> @@ -77,6 +77,7 @@ extern struct platform_device s5p_device_fimc0;
>  extern struct platform_device s5p_device_fimc1;
>  extern struct platform_device s5p_device_fimc2;
>  extern struct platform_device s5p_device_fimc3;
> +extern struct platform_device s5p_device_fimc_md;
>  extern struct platform_device s5p_device_fimd0;
>  extern struct platform_device s5p_device_hdmi;
>  extern struct platform_device s5p_device_i2c_hdmiphy;
> --
> 1.7.7

Applied.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2011-10-14  7:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-07 13:53 [PATCH] ARM: EXYNOS4: Add support for M-5MOLS camera on Nuri board Sylwester Nawrocki
2011-10-10  4:28 ` Kukjin Kim
2011-10-10  9:29   ` [PATCH v2] " Sylwester Nawrocki
2011-10-10  9:38     ` Kukjin Kim
2011-10-12 15:31       ` [PATCH] ARM: Samsung: Move fimc plat. device from board files to plat-samsung Sylwester Nawrocki
2011-10-14  7:13         ` Kukjin Kim [this message]
2011-10-12 12:43     ` [PATCH v2] ARM: EXYNOS4: Add support for M-5MOLS camera on Nuri board Kukjin Kim
2011-10-12 14:04       ` Sylwester Nawrocki
2011-10-12 15:38       ` [PATCH v3] " Sylwester Nawrocki
2011-10-14  7:13         ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='085e01cc8a40$d31a54c0$794efe40$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).