From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF325C6FA82 for ; Tue, 20 Sep 2022 21:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jZhExiKpcKbDTPwmBfj2cKuULTuOKRXYkXqr4pb2nRc=; b=Ku7+0zMKdFd1elSBTwlhI29Ipu 29XlL1O25ezVlgkuUBFPYRD2eFrEfzF2yHbdVtpH9cqS+sOv2HIgjb5xRlnpS/gy8NdCxkIDgvKtY mD4+kC0JuBME6czcmjoiAB+6tuEQNIt/Y2oNT+r+PT6bp/gsL/DTDh5r6K6tSn6kzmTNJw5B7YHHM 2skKRQLZQonEzD1pBlG2kCHYPNZNwogW1eyoIlvlsiC4WrtK203yOG3dzFIFCBSCSE2rpPU0SAmxA HMlPtnVfsA0aTjchYMJJZ9f9vaLQptis8RBfWygNE5F2I0zeVV3o3SK5Off5C6UURcr4gDSzqJife Jr6iUFUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oakpv-006vU0-V3; Tue, 20 Sep 2022 21:31:24 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oakpr-006tny-P2; Tue, 20 Sep 2022 21:31:21 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id E87CF18845FF; Tue, 20 Sep 2022 21:29:12 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id D3A51250007B; Tue, 20 Sep 2022 21:29:12 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id C5ED9A0A1E65; Tue, 20 Sep 2022 21:29:12 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Tue, 20 Sep 2022 23:29:12 +0200 From: netdev@kapio-technology.com To: Ido Schimmel Cc: Vladimir Oltean , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Christian Marangi , Daniel Borkmann , Yuwei Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests In-Reply-To: References: <5cee059b65f6f7671e099150f9da79c1@kapio-technology.com> <8dfc9b525f084fa5ad55019f4418a35e@kapio-technology.com> <20220908112044.czjh3xkzb4r27ohq@skbuf> <152c0ceadefbd742331c340bec2f50c0@kapio-technology.com> <20220911001346.qno33l47i6nvgiwy@skbuf> <15ee472a68beca4a151118179da5e663@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: <086704ce7f323cc1b3cca78670b42095@kapio-technology.com> X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_143120_190789_9176F64C X-CRM114-Status: GOOD ( 31.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-09-12 11:08, Ido Schimmel wrote: > On Sun, Sep 11, 2022 at 11:23:55AM +0200, netdev@kapio-technology.com > wrote: >> On 2022-09-11 02:13, Vladimir Oltean wrote: >> > On Fri, Sep 09, 2022 at 03:11:56PM +0200, netdev@kapio-technology.com >> > wrote: >> > > > > > On Wed, Sep 07, 2022 at 11:10:07PM +0200, netdev@kapio-technology.com wrote: >> > > > > > > I am at the blackhole driver implementation now, as I suppose that the >> > > > > > > iproute2 command should work with the mv88e6xxx driver when adding blackhole >> > > > > > > entries (with a added selftest)? >> > > > > > > I decided to add the blackhole feature as new ops for drivers with functions >> > > > > > > blackhole_fdb_add() and blackhole_fdb_del(). Do you agree with that approach? >> > > > > > >> > > > > > I assume you are talking about extending 'dsa_switch_ops'? >> > > > > >> > > > > Yes, that is the idea. >> > > > > >> > > > > > If so, it's up to the DSA maintainers to decide. >> > > > >> > > > What will be the usefulness of adding a blackhole FDB entry from user >> > > > space? >> > > >> > > With the software bridge it could be used to signal a untrusted host >> > > in >> > > connection with a locked port entry attempt. I don't see so much use >> > > other >> > > that test purposes with the driver though. >> > >> > Not a huge selling point, to be honest. Can't the blackhole flag remain >> > settable only in the device -> bridge direction, with user space just >> > reading it? >> >> That is possible, but it would of course not make sense to have >> selftests of >> the feature as that would not work unless there is a driver with this >> capability (now just mv88e6xxx). > > The new "blackhole" flag requires changes in the bridge driver and > without allowing user space to add such entries, the only way to test > these changes is with mv88e6xxx which many of us do not have... I am now building from new system (comp), and the kernel selftests are not being installed correctly, so I haven't been able to run the selftests yet. I have made a blackhole selftest, which looks like this: test_blackhole_fdb() { RET=0 check_blackhole_fdb_support || return 0 tcpdump_start $h2 $MZ $h1 -q -t udp -a $h1 -b $h2 tcpdump_stop tcpdump_show | grep -q udp check_err $? "test_blackhole_fdb: No packet seen on initial" tcpdump_cleanup bridge fdb add `mac_get $h2` dev br0 blackhole bridge fdb show dev br0 | grep -q "blackhole" check_err $? "test_blackhole_fdb: No blackhole FDB entry found" tcpdump_start $h2 $MZ $h1 -q -t udp -a $h1 -b $h2 tcpdump_stop tcpdump_show | grep -q udp check_fail $? "test_blackhole_fdb: packet seen with blackhole fdb entry" tcpdump_cleanup bridge fdb del `mac_get $h2` dev br0 blackhole bridge fdb show dev br0 | grep -q "blackhole" check_fail $? "test_blackhole_fdb: Blackhole FDB entry not deleted" tcpdump_start $h2 $MZ $h1 -q -t udp -a $h1 -b $h2 tcpdump_stop tcpdump_show | grep -q udp check_err $? "test_blackhole_fdb: No packet seen after removing blackhole FDB entry" tcpdump_cleanup log_test "Blackhole FDB entry test" } the setup is simple and is the same as in bridge_sticky_fdb.sh. Does the test look sound or is there obvious mistakes? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel