From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCF1BC3DA64 for ; Wed, 31 Jul 2024 14:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QpzGqPZNogg7gfb8tMWXYKRLjjvoWBSL6FCUeY/FuoI=; b=3sL8+LETLto7SeFNQr/YIBgDHt jvdL2on/hOPbJAOhLeQYqpZgl7L+Lh6nfkGe84aidrFjib70eiTzo3iK5WjmYmdGOnucOd0H2OqcC Br45zSqrUktWN51Z0Cuk0pcZPRERhLkTyvLdFyzFfGWdM9ixbW2IktziVy7uGlyzovgr6/KOdmldb 5puFMvEdWLprlAQbZMNZXxwyk0bSv8qSz4gHAqn3k8cKIKhV1DjYKypG194BWP8Nvu9p/Y0RSJKuP brjM+UmM1ZRXWjpLQgsu+3QimOM7c4eSXNvannD8LvYL333EKAE3Y6jiF5jsS53KhXP+bQo5xf8iw 7EpVNgbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZASl-00000001Vyb-2Ysu; Wed, 31 Jul 2024 14:37:59 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZASH-00000001VpC-2C6V for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 14:37:31 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 46VEbO72052518; Wed, 31 Jul 2024 09:37:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1722436644; bh=QpzGqPZNogg7gfb8tMWXYKRLjjvoWBSL6FCUeY/FuoI=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=dPqui2rZu1RfCO16r3Ige6SnhRZsBQWrEtJInfEB4RrgUUOieoAUWKv0o+o6Mxbv4 kZAPzfG4HxvQnDnX0tPUpADZ2qKzppK8afgyXhNZ3MaumwECBMdk4ZTfRymEskgcyE Z7VAg0JRd7/3t7+rHsHLmkJ5WLmgex3YqeGSeU6U= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 46VEbOA6128110 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 31 Jul 2024 09:37:24 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 31 Jul 2024 09:37:24 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 31 Jul 2024 09:37:24 -0500 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 46VEbNK2065889; Wed, 31 Jul 2024 09:37:24 -0500 Message-ID: <087ee9e2-50ec-4791-a534-b3ebbf594fe6@ti.com> Date: Wed, 31 Jul 2024 09:37:23 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] arm64: dts: ti: Introduce J742S2 SoC family To: Manorit Chawdhry , Nishanth Menon CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Udit Kumar , Neha Malcom Francis , Aniket Limaye References: <20240730-b4-upstream-j742s2-v2-0-6aedf892156c@ti.com> <20240730-b4-upstream-j742s2-v2-2-6aedf892156c@ti.com> <20240730123343.mqafgpj4zcnd5vs4@plaything> <20240731041916.stcbvkr6ovd7t5vk@uda0497581> <20240731110607.7fb42mgcsf2apodv@unshaven> <20240731135714.p53lki7mihzxcyk2@uda0497581> Content-Language: en-US From: Andrew Davis In-Reply-To: <20240731135714.p53lki7mihzxcyk2@uda0497581> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_073729_691127_6B7ADF37 X-CRM114-Status: GOOD ( 15.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/31/24 8:57 AM, Manorit Chawdhry wrote: > Hi Nishanth, > > On 06:06-20240731, Nishanth Menon wrote: >> On 09:49-20240731, Manorit Chawdhry wrote: >>>>> + */ >>>>> + >>>>> +#include "k3-j784s4.dtsi" >>>>> + >>>>> +/ { >>>>> + model = "Texas Instruments K3 J742S2 SoC"; >>>>> + compatible = "ti,j742s2"; >>>>> + >>>>> + cpus { >>>>> + cpu-map { >>>>> + /delete-node/ cluster1; >>>>> + }; >>>>> + }; >>>>> + >>>>> + /delete-node/ cpu4; >>>>> + /delete-node/ cpu5; >>>>> + /delete-node/ cpu6; >>>>> + /delete-node/ cpu7; >>>> >>>> I suggest refactoring by renaming the dtsi files as common and split out >>>> j784s4 similar to j722s/am62p rather than using /delete-node/ >>>> >>> >>> I don't mind the suggestion Nishanth if there is a reason behind it. >>> Could you tell why we should not be using /delete-node/? >>> >> >> Maintenance, readability and sustenance are the reasons. This is a >> optimized die. It will end up having it's own changes in property >> and integration details. While reuse is necessary, modifying the >> properties with overrides and /delete-nodes/ creates maintenance >> challenges down the road. We already went down this road with am62p >> reuse with j722s, and eventually determined split and reuse is the >> best option. See [1] for additional guidance. >> >> >> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n189 > > Thank you for giving some reasoning, would do the needful! > This refactor will require some interesting naming for the common SoC files. Based on your name for the EVM, I'm guessing you will go with k3-j784s4-common.dtsi included from the real k3-j784s4.dtsi and the new k3-j742s2.dtsi? Too bad the Jacinto SoC names don't use a hierarchical naming. :( J7.. Andrew > Regards, > Manorit > >> >> -- >> Regards, >> Nishanth Menon >> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D >