From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB977C433DB for ; Wed, 10 Feb 2021 01:34:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98C6C64E2A for ; Wed, 10 Feb 2021 01:34:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98C6C64E2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f9fUd6OfbNbYXTtj3L8BRgNKCVOb2qd9lzMUnsJGg1k=; b=p7SnPPgc3JcWxfo2i4r1dET9Y E8rUlkv8Vwn3vTJ/GLuRTz1Br6IwXLC37usn4LiHrOQ355rX8UNCXQEEjfZrEdCBCgUmN1/b1xcN6 o3FkPYi8Qn/T9iOlCMq46Ws8IWPRJciVBYpS77aTdidd1KrIHZqDbg3+FTL0iuZgnmr8FMMVjSWkJ 55ntOkE/8jD9dzCfSoKUlc8iTKrfCb1V0Mmj7SOqFVjQlwgD0J7QF5oTd/uvhPbVRiCcGudjb8fBG 6xxdZOIjRPetnIC42hSb0D6n23YFKLxZddyeUl9uWmmkpuVKGAuWxdYfuBaasqlewWxEQFKCBtnK3 ACdIHJyWA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9eNH-00064m-4Z; Wed, 10 Feb 2021 01:32:59 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9eNE-00063K-H3; Wed, 10 Feb 2021 01:32:57 +0000 Received: by mail-pl1-x62f.google.com with SMTP id e12so324122pls.4; Tue, 09 Feb 2021 17:32:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t6voKTk6/OdOzOuPgN0xYWNzCZPSi7LG5qfSMC9hkY0=; b=Ump3YhBMnDO6jOwbzAYdSdwi+bxYNZoVhs1d7kKrZcMxTs6PGLNTpwTuNk5bOETuA8 USrvPZo9BBRCr3cLqHbLUCN9nB4DT253/NxqYBg7aKS5ugqRK8Dwtkh4wImZq36FXFtf BqKr8byaMDB6nQ4RDMNrWYGqCA4zqvo6BrZ4PKLtwOg7WSuN070wpz8zBisKU619vV8O dCos8kBnDXRkLJPpXZl7r+QzYwZyBuYfT3gXOCn1LY34XuQoe9jx+j2FygwYhAH99cWT 47/fysUZ1Zw+CUE4jc5VQjOAQd8bEP/s4pyip5P54E0yNb3aXmS+jODmJrys7qKaxl3S j5rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t6voKTk6/OdOzOuPgN0xYWNzCZPSi7LG5qfSMC9hkY0=; b=VF6qXbwQLcuL5AaZpM/oBbtoiJx0LqAL0vQR7nm8MgnKl/cAfQ4AF3s3CyCrw4PvaU dvfO90wywc/WpjvCL4rLg6nJH/7OGC4lwOCdZNhtN+2KLqarkQRNX/7ghCRasmtMjSN5 EYCVpyvgC2QY0rQyhXS5xsH6jNbNLoupF7Yr7U59eVDZ4g1SIbi6nG2Ut1meCzhdLLbP guLXr32LbbmIWpoHz9T+O7RRAzuSsGisHRuyuYScJmX+tdcLVMlhAhNPnsvOczcbK3+B PgDdb5thqMDA0MhytQR/5ZYZEF97Pjd5QV0L08xmTGXRLkwCebJNsNZCy9xxMsEnJagZ xqGw== X-Gm-Message-State: AOAM532qsWKv7CDHvVQTMhKXl2xHabHvzqd67sU/o3xKK/XCXtX8pddE h1sCjIImGwsawjDUZIJ1Xq2ZgXe1MK8= X-Google-Smtp-Source: ABdhPJy0b5I+6N64Xz+iZbhDKWK6dK9Y1pDcCQk5IKibjCBxqEqKr19ueYXRPBYMH2BvpSeGuwYceQ== X-Received: by 2002:a17:90a:cd06:: with SMTP id d6mr731958pju.86.1612920772287; Tue, 09 Feb 2021 17:32:52 -0800 (PST) Received: from [10.230.29.30] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id z22sm171027pfa.41.2021.02.09.17.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Feb 2021 17:32:51 -0800 (PST) Subject: Re: [PATCH v2] hwrng: bcm2835 - remove redundant null check To: Tian Tao , sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, nsaenzjulienne@suse.de References: <1612919698-60261-1-git-send-email-tiantao6@hisilicon.com> From: Florian Fainelli Message-ID: <08a9cc3c-2bee-4fce-ff79-05499b11f903@gmail.com> Date: Tue, 9 Feb 2021 17:32:54 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <1612919698-60261-1-git-send-email-tiantao6@hisilicon.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_203256_655121_B3E2D8F9 X-CRM114-Status: UNSURE ( 9.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/9/2021 5:14 PM, Tian Tao wrote: > clk_prepare_enable() and clk_disable_unprepare() will check > NULL clock parameter, so It is not necessary to add additional checks. > > Signed-off-by: Tian Tao Acked-by: Florian Fainelli Thanks for the quick spin! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel