From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1202AC433E0 for ; Fri, 26 Jun 2020 13:15:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE75B2080C for ; Fri, 26 Jun 2020 13:15:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s3Bl6Jay" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE75B2080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZiUxCoukp5sEWqFQ1dbQT4e26ZBgXa8ykLH+jmYAnjA=; b=s3Bl6JayE7K6rJhQ26SmLFJqc usn4DUKjxZ7qni7mwKnQ79tW87XZ3lQMNdVw+oSRJyGGgIwUbLU+wz5NoNoq21CspFENSzhjqB6w3 JJ3EQ1bkpXpI2Az0FEyhfQXL8b+57sy5mcYx2WeuYAFJXguNMnK2W3uAcxE6vMR//TykPkmoRkyci Hpj6AHWMhqIpjbHDjvPbT5agT8q0wjbVFbefA8t/x9OELt0JBpWdPks+s7hMyNmgKtXG5zFRHc0XK +jm4IP+46yP8613yAJ27ybsoQ9kA+9HmpQjHmd/tbSo5/4JM6neSjYOx6/DhA3mKFqcRVAdeAJ8Oe iMz53JKtw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jooBV-0006iu-GY; Fri, 26 Jun 2020 13:14:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jooBS-0006hR-7k for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:14:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E20EDD6E; Fri, 26 Jun 2020 06:14:17 -0700 (PDT) Received: from [192.168.0.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B1FF43F6CF; Fri, 26 Jun 2020 06:14:15 -0700 (PDT) Subject: Re: [PATCH v2 05/17] KVM: arm64: Use TTL hint in when invalidating stage-2 translations To: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org References: <20200615132719.1932408-1-maz@kernel.org> <20200615132719.1932408-6-maz@kernel.org> From: Alexandru Elisei Message-ID: <08ad46a7-b676-a889-7e48-63367dcf453b@arm.com> Date: Fri, 26 Jun 2020 14:14:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200615132719.1932408-6-maz@kernel.org> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kernel-team@android.com, Suzuki K Poulose , Andre Przywara , Christoffer Dall , Dave Martin , George Cherian , James Morse , Andrew Scull , "Zengtao \(B\)" , Catalin Marinas , Will Deacon , Jintack Lim , Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 6/15/20 2:27 PM, Marc Zyngier wrote: > Since we often have a precise idea of the level we're dealing with > when invalidating TLBs, we can provide it to as a hint to our > invalidation helper. > > Reviewed-by: James Morse > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_asm.h | 3 ++- > arch/arm64/kvm/hyp/tlb.c | 5 +++-- > arch/arm64/kvm/mmu.c | 29 +++++++++++++++-------------- > 3 files changed, 20 insertions(+), 17 deletions(-) > > [..] I checked that we use the correct level hints where appropriate (for example, that we use the S2_PMD_LEVEL hint in stage2_dissolve_pmd()). From what I could tell, we use hints only where we know for sure that we are invalidating a PUD or PMD block mapping, or a PTE entry. FWIW: Reviewed-by: Alexandru Elisei Thanks, Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel