linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Claudiu.Beznea@microchip.com (m18063)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM
Date: Mon, 27 Mar 2017 17:05:58 +0300	[thread overview]
Message-ID: <08b1036a-bb4d-5ae2-1a68-68ccdc0b3fef@microchip.com> (raw)
In-Reply-To: <20170327131530.ifexyrgrp5egtbtr@piout.net>


On 27.03.2017 16:15, Alexandre Belloni wrote:
> On 27/03/2017 at 15:02:37 +0200, Boris Brezillon wrote:
>> Hi Claudiu,
>>
>> On Wed, 22 Mar 2017 15:29:34 +0200
>> Claudiu Beznea <claudiu.beznea@microchip.com> wrote:
>>
>>>  static const struct platform_device_id atmel_pwm_devtypes[] = {
>>>  	{
>>>  		.name = "at91sam9rl-pwm",
>>> -		.driver_data = (kernel_ulong_t)&atmel_pwm_data_v1,
>>> +		.driver_data = (kernel_ulong_t)&atmel_pwm_regs_v1,
>>>  	}, {
>>>  		.name = "sama5d3-pwm",
>>> -		.driver_data = (kernel_ulong_t)&atmel_pwm_data_v2,
>>> +		.driver_data = (kernel_ulong_t)&atmel_pwm_regs_v2,
>>>  	}, {
>>>  		/* sentinel */
>>>  	},
>> Unrelated to this series, but can you prepare a patch to get rid of
>> this platform id table (AT91 platforms have completely switched to DT
>> for quite some time now).
>>
> Please, don't until AVR32 is gone.

Sure, I will wait for it.

>
>> You can also get rid of the "if (pdev->dev.of_node)" condition in
>> atmel_pwm_probe() since it's guaranteed to be true, otherwise the
>> ->probe() method wouldn't be called.
>>
>> Thanks,
>>
>> Boris

  reply	other threads:[~2017-03-27 14:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 13:29 [PATCH v3 0/2] switch to atomic PWM Claudiu Beznea
2017-03-22 13:29 ` [PATCH v3 1/2] drivers: pwm: pwm-atmel: " Claudiu Beznea
2017-03-27 12:57   ` Boris Brezillon
2017-03-27 13:02   ` Boris Brezillon
2017-03-27 13:15     ` Alexandre Belloni
2017-03-27 14:05       ` m18063 [this message]
2017-03-22 13:29 ` [PATCH v3 2/2] drivers: pwm: pwm-atmel: enable PWM on sama5d2 Claudiu Beznea
2017-03-27 13:03   ` Boris Brezillon
2017-04-06 14:33 ` [PATCH v3 0/2] switch to atomic PWM Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08b1036a-bb4d-5ae2-1a68-68ccdc0b3fef@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).