From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0646CC4742C for ; Thu, 5 Nov 2020 14:14:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 882F12071A for ; Thu, 5 Nov 2020 14:14:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vcMtS0b+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 882F12071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FXmtAY5/nWZl5GilnnLPujmlZv16gbw38mUWpSXvG4c=; b=vcMtS0b+WKswdgrlKrPDihas6 BTvsBt/ef6A+MJTfentzzKC6kNn7xLLtcbntkzQePd3ZkQdHnz6YJUTkT/Us3uC1Vy774HSjNF/wK q2TSO2aHZrWByvqHUbxcPtDmPc4xJKjBSu/uNjd9z4hclmlklB4v7eoanzbTHsO71bStCZJ8DwMKE 4Rx+bDAq1wN7vh+nn9Qjl18ml5lXqVLPLjaLoQ0lDkXpQO0h9+ZQoatTRfr35F3ume8XtfWlFQAqr 1nJoiam5MhhDFS9wXG4DQkfBOu2pz5LcOhX6u+o0m4y3Rptw4E16sjrfGUcHtKgHhvQ8AgchE/Qvt XEZpT2M0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kag1e-0000y9-S9; Thu, 05 Nov 2020 14:14:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kag1b-0000wx-NK for linux-arm-kernel@lists.infradead.org; Thu, 05 Nov 2020 14:14:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 894BA14BF; Thu, 5 Nov 2020 06:14:02 -0800 (PST) Received: from [10.37.12.41] (unknown [10.37.12.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C55673F719; Thu, 5 Nov 2020 06:13:59 -0800 (PST) Subject: Re: [PATCH v8 30/43] arm64: kasan: Allow enabling in-kernel MTE To: Andrey Konovalov References: <5e3c76cac4b161fe39e3fc8ace614400bc2fb5b1.1604531793.git.andreyknvl@google.com> <58aae616-f1be-d626-de16-af48cc2512b0@arm.com> <1ef3f645-8b91-cfcf-811e-85123fea90fa@arm.com> From: Vincenzo Frascino Message-ID: <090ab218-8566-772b-648f-00001413fef2@arm.com> Date: Thu, 5 Nov 2020 14:17:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201105_091403_824220_92D1CA6D X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Marco Elver , Catalin Marinas , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Linux Memory Management List , Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/5/20 12:14 PM, Andrey Konovalov wrote: > On Thu, Nov 5, 2020 at 12:39 PM Vincenzo Frascino > wrote: >> >> On 11/5/20 11:35 AM, Andrey Konovalov wrote: >>> This will work. Any preference on the name of this function? >>> >> >> I called it in my current iteration mte_enable(), and calling it from >> cpu_enable_mte(). >> >>> Alternatively we can rename mte_init_tags() to something else and let >>> it handle both RRND and sync/async. >> >> This is an option but then you need to change the name of kasan_init_tags and >> the init_tags indirection name as well. I would go for the simpler and just >> splitting the function as per above. >> >> What do you think? > > OK, let's split. mte_enable() as a name sounds good to me. Both > functions will still be called one right after another from > kasan_init_hw_tags (as it's now called) though. I think the name > works, as it means initializing the hw_tags mode, not just the tags. > I agree. When you finish with v9, could you please provide a tree with both the sets on top similar to [1]? I would like to repeat the tests (ltp + kselftests) and even to rebase my async code on top of it since we are aligning with the development. [1] https://github.com/xairy/linux/tree/up-boot-mte-v1 > Will do in v9. > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel