From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B858DFA372B for ; Fri, 13 Sep 2024 08:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:References:In-Reply-To:Message-Id:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DmcgopRalHSpfJSJRp6mInfsDTCIb/u1Ocp84sQ/qnU=; b=ajt2M0Vb7g7jpx7hJMPUFP2nOW IbrTYuGN5oNsXivWDU8sGZ9OtokhY30cev9I96ZrIr/aw4NRIqiUAo8xi7fq2P3As5ctWX7D+YMNk bd7kxAD9Yy4h82i02aPXQpzWXXfqJHsIdp2WSbSL7+MpcJWfzEg4mSUce9J3478MuY+p1g1tMdH5t tPc3VxEz8wL3J4tHk8awBug7bzeJwbC750dwlcuT2WV9Yu+x15Z5Heg9c7bka5M5ZprvcTsKAYgKt zONF8XFGVZ0eFai4W4C4/Gna6CfXcyk7JgylMHjFdsSiw5mkBwmlcSaME65L6hp5mg8xXG34nmc/v hGufQtPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp1Uw-0000000FJXf-1YHh; Fri, 13 Sep 2024 08:17:46 +0000 Received: from fhigh3-smtp.messagingengine.com ([103.168.172.154]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp1Ts-0000000FJQt-1uCJ for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2024 08:16:41 +0000 Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 1B3BF114035D; Fri, 13 Sep 2024 04:16:39 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 13 Sep 2024 04:16:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1726215399; x=1726301799; bh=DmcgopRalHSpfJSJRp6mInfsDTCIb/u1Ocp84sQ/qnU=; b= Ok8aBhxcdy41m2qJVVQMYWIcphGssuqlUGNvzQ/IUWwyqp6VR1+bwB9SMladGuUy UPHsYcREVDUrOTtUvCWsT1AxCd/Z+L3s/amU9tDi7Iec55mEtuVSUMCOpBk8Br4j J3IMf0iIcxkgqCm69YQ4hRfXXOBCzSL37+3Jc6Tgsg/jQcRIe23Jq2v3Da7B8fEX VQI30waKr1UskN1Wo+FmpUKIrq80+mNWunww+DtCCiEiyscapw7Xkfz3z21Ia9aL uKMun/MGJNAzSHIHYXOzN2w8njMI0IckHZmrUy3C2oqEmNHkrpmTevuSnW8sdQV6 1aOuv+iwrDChzTTIeXsSPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726215399; x= 1726301799; bh=DmcgopRalHSpfJSJRp6mInfsDTCIb/u1Ocp84sQ/qnU=; b=i zHokdNRANzOrerLBZp/qLoKsF7KBrsH92bUrALhxIiLDC6R2XudTO0m1NLlHvdOa ooNuqSdpEWhOoNN5fr0izIl8kFlY+RTXm+eYk4ZTwLHQBqA7cZCo5mqXUfN6nqQh 0usmEYX+qomlvUvRDAfCbTPEDxvYxJKWchnOWGmzMsWA5LYubiEaElcYXUSJ/cmV g6nFX4xEWylr6/UsEemks0pXl9wosLOEALXbeTu+lgbprTsAY5WZBM7p1fMmkZcd JOas1U+Bh6oLfV+aSqLVmmRHLvQl2pN7wjltYqO+ZfRqd0mgPifQcWffnfFp4jI8 +xQZC/vbi71i7VGElUmGA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejjecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffrtefo kffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsuc dlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfh rhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqe enucggtffrrghtthgvrhhnpefhtdfhvddtfeehudekteeggffghfejgeegteefgffgvedu geduveelvdekhfdvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopedvkedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepuhhtshgrvhdrrghgrghrfigrlhesrghnrg hlohhgrdgtohhmpdhrtghpthhtoheprggushhpqdhlihhnuhigsegrnhgrlhhoghdrtgho mhdprhgtphhtthhopegrrhhtuhhrshdrrghrthgrmhhonhhovhhssegrnhgrlhhoghdrtg homhdprhgtphhtthhopegtrghtrghlihhnrdhmrghrihhnrghssegrrhhmrdgtohhmpdhr tghpthhtohepmhhtuhhrqhhuvghtthgvsegsrgihlhhisghrvgdrtghomhdprhgtphhtth hopegsrhhglhessghguggvvhdrphhlpdhrtghpthhtoheprghnughirdhshhihthhisehk vghrnhgvlhdrohhrghdprhgtphhtthhopegtohhnohhrodgutheskhgvrhhnvghlrdhorh hgpdhrtghpthhtohepjhhirhhishhlrggshieskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 37D86222006F; Fri, 13 Sep 2024 04:16:38 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Fri, 13 Sep 2024 08:16:16 +0000 From: "Arnd Bergmann" To: arturs.artamonovs@analog.com, "Catalin Marinas" , "Will Deacon" , "Greg Malysa" , "Philipp Zabel" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Utsav Agarwal" , "Michael Turquette" , "Stephen Boyd" , "Linus Walleij" , "Bartosz Golaszewski" , "Thomas Gleixner" , "Andi Shyti" , "Greg Kroah-Hartman" , "Jiri Slaby" , "Olof Johansson" , soc@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, adsp-linux@analog.com, "Nathan Barrett-Morrison" Message-Id: <0929c49e-d906-4885-8e4f-b380358ec6c6@app.fastmail.com> In-Reply-To: <20240912-test-v1-1-458fa57c8ccf@analog.com> References: <20240912-test-v1-0-458fa57c8ccf@analog.com> <20240912-test-v1-1-458fa57c8ccf@analog.com> Subject: Re: [PATCH 01/21] arm64: Add ADI ADSP-SC598 SoC Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240913_011640_639100_F4AE184B X-CRM114-Status: GOOD ( 18.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 12, 2024, at 18:24, Arturs Artamonovs via B4 Relay wrote: > From: Arturs Artamonovs > > Add ADSP-SC598 platform. > > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -292,6 +292,19 @@ config ARCH_ROCKCHIP > This enables support for the ARMv8 based Rockchip chipsets, > like the RK3368. > > +config ARCH_SC59X_64 > + bool "ADI 64-bit SC59X Platforms" > + select TIMER_OF > + select GPIOLIB > + select PINCTRL > + select COMMON_CLK_ADI_SC598 > + select PINCTRL_ADSP > + select ADI_ADSP_IRQ > + select COUNTER You can remove the 'select' statements above and just make your drivers 'default ARCH_SC59X_64'. It may also help to pick a more generic name for the platform in case someone wants to add support for SC57x/SC58x later, assuming these use some of the same drivers,. The Kconfig change can normally go into the same patch as the MAINTAINERS file update, but should be separate from any of the drivers. > --- /dev/null > +++ b/drivers/soc/adi/Makefile > @@ -0,0 +1,5 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +# todo modularize; already depends on CONFIG_ARCH_SC59X_64 though > + > +obj-y += system.o > diff --git a/drivers/soc/adi/system.c b/drivers/soc/adi/system.c I'm confused about the purpose of this driver. Please split this out into a separate patch and add a detailed description of how it is actually being used, since it does not interact with any of the normal subsystems. > diff --git a/include/linux/soc/adi/adsp-gpio-port.h > b/include/linux/soc/adi/adsp-gpio-port.h > --- /dev/null > +++ b/include/linux/soc/adi/cpu.h > --- /dev/null > +++ b/include/linux/soc/adi/rcu.h > @@ -0,0 +1,55 @@ > diff --git a/include/linux/soc/adi/sc59x.h > b/include/linux/soc/adi/sc59x.h > --- /dev/null > +++ b/include/linux/soc/adi/sc59x.h I don't see these files being included in the driver you add here, maybe they got added by accident here? Arnd