From: Valerio Setti <vsetti@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 6/7] ASoC: meson: gx-card: add support for audin FIFO
Date: Tue, 17 Nov 2026 00:06:40 +0100 [thread overview]
Message-ID: <0949591a-63cb-4bb3-a7de-cf59ddbaafb7@baylibre.com> (raw)
In-Reply-To: <CAFBinCA12FvOi=9gB1xj3MDvNWstx1N4TtyyrrndJ_JT5eLX=Q@mail.gmail.com>
On 11/15/26 10:28 PM, Martin Blumenstingl wrote:
> On Sun, Oct 18, 2026 at 12:18 PM Valerio Setti <vsetti@baylibre.com> wrote:
> [...]
>> + if (gx_card_cpu_identify(dai_link->cpus, DT_PREFIX "gxbb-audin", "FIFO"))
>> + return meson_card_set_fe_link(card, dai_link, np, false);
> I suggest using the "audin" prefix. AIU / audin seem close enough on
> all supported SoCs that we don't need a SoC generation prefix in
> there to handle this differently.
Do you mean using "meson,audin" instead of "meson,gxbb-audin" for the
compatible?
If so I'm not sure this is allowed nowadays. As far as I understood
"meson,aiu" is a sort of legacy naming. 'writing-binidings.rst' says
"DO use a SoC-specific compatible for all SoC devices [...]"
--
Valerio
next prev parent reply other threads:[~2026-11-16 23:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 10:17 [PATCH v5 0/7] ASoC: meson: gx: add base support for I2S audio input Valerio Setti
2026-10-18 10:17 ` [PATCH v5 1/7] ASoC: dt-bindings: add amlogic,gxbb-audin Valerio Setti
2026-11-15 21:03 ` Martin Blumenstingl
2026-11-16 22:24 ` Valerio Setti
2026-10-18 10:17 ` [PATCH v5 2/7] ASoC: meson: build gx-formatter as a separate module Valerio Setti
2026-11-15 21:04 ` Martin Blumenstingl
2026-10-18 10:18 ` [PATCH v5 3/7] ASoC: meson: aiu-encoder-i2s: ensure clk divider gets disabled in hw_free Valerio Setti
2026-11-15 21:09 ` Martin Blumenstingl
2026-10-18 10:18 ` [PATCH v5 4/7] ASoC: meson: add AUDIN driver Valerio Setti
2026-11-15 21:26 ` Martin Blumenstingl
2026-10-18 10:18 ` [PATCH v5 5/7] ASoC: meson: aiu: add I2S Capture DAI Valerio Setti
2026-11-15 21:27 ` Martin Blumenstingl
2026-10-18 10:18 ` [PATCH v5 6/7] ASoC: meson: gx-card: add support for audin FIFO Valerio Setti
2026-11-15 21:28 ` Martin Blumenstingl
2026-11-16 23:06 ` Valerio Setti [this message]
2026-10-18 10:18 ` [PATCH v5 7/7] arm64: dts: amlogic: gx: add AUDIN node Valerio Setti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0949591a-63cb-4bb3-a7de-cf59ddbaafb7@baylibre.com \
--to=vsetti@baylibre.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox