From: Tinghan Shen <tinghan.shen@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Wenbin Mei <wenbin.mei@mediatek.com>
Cc: <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<ryder.lee@kernel.org>, <wenst@chromium.org>,
<chunfeng.yun@mediatek.com>
Subject: Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems
Date: Wed, 30 Mar 2022 15:33:16 +0800 [thread overview]
Message-ID: <094d261cf7621b2e68e53a0aaef8e7eaa9965a7e.camel@mediatek.com> (raw)
In-Reply-To: <32931f81-5615-8156-4c67-bb4260488185@gmail.com>
Hi Matthias,
On Tue, 2022-03-29 at 16:27 +0200, Matthias Brugger wrote:
>
> On 29/03/2022 13:45, Tinghan Shen wrote:
> > Add optional host top register base for the reg binding description.
> >
>
> Is this based a on a new version of the IP? Shall we make the second reg
> mandatory for the new HW? If I remember correctly the reg needs to be restored
> after power save event. So I suppose mmc won't work if that's not done. So
> optional wouldn't be the right approach.
>
> Can you please clarify if that's the case.
Yes. This change is introduced since mt8183, and the host top register
is required for mt8183.
We'll try to describe this change clearly in bindings in next version.
Best regards,
Tinghan
>
> Thanks,
> Matthias
>
> > Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 7032f7adf3ca..6d41bcec900f 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -40,7 +40,8 @@ properties:
> > - const: mediatek,mt8183-mmc
> >
> > reg:
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 2
> >
> > clocks:
> > description:
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-30 7:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 11:45 [PATCH v12 0/3] Add basic SoC support for mediatek mt8195 Tinghan Shen
2022-03-29 11:45 ` [PATCH v12 1/3] dt-bindings: mmc: mtk-sd: fix yamllint error Tinghan Shen
2022-03-29 12:47 ` AngeloGioacchino Del Regno
2022-03-30 2:55 ` Tinghan Shen
2022-03-29 11:45 ` [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems Tinghan Shen
2022-03-29 12:43 ` AngeloGioacchino Del Regno
2022-03-29 19:10 ` Rob Herring
2022-03-30 8:20 ` AngeloGioacchino Del Regno
2022-03-29 14:27 ` Matthias Brugger
2022-03-30 7:33 ` Tinghan Shen [this message]
2022-03-29 20:38 ` Rob Herring
2022-03-30 7:25 ` Tinghan Shen
2022-03-29 11:45 ` [PATCH v12 3/3] arm64: dts: Add mediatek SoC mt8195 and evaluation board Tinghan Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=094d261cf7621b2e68e53a0aaef8e7eaa9965a7e.camel@mediatek.com \
--to=tinghan.shen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chaotian.jing@mediatek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox