From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E15ABEE6456 for ; Thu, 12 Sep 2024 07:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lh7l9YoHy4qkgvE49qc+r/MAsmVlGzV7/aids6D1De4=; b=uaOw7qv60o35N2Y+62vaUAK+Vz nOvgQaBcT9JlNR3Dmm8hYEb+uvB2s6Hubnw5PwyI38NMOHmKaPoMg/GTRqMrRLN5TOd10SOLLIDuV j1ssxeJIzxczp28FRzHRq6Rh12tdEjTUQ22x2y9n9JExGmaac3HG7U3Kay2tKeor0/tVmev9QWWXr +hhVBKT1WfpIeeQgLqewYrt9ad0IUGbwMWr36K5EZrDgEeZo2V9JTL2pS3UXAaWypEIoJgUxlQ43V SeUb62YSO9kd9OYAdKivXpFr+/8yxOAxQH1sTD+wG41JIe7duwoUBJGHljizowilqsV5y39yZ7cRp /++fWcXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soe5G-0000000C8qq-1nj5; Thu, 12 Sep 2024 07:17:42 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soe4C-0000000C8fh-47cV for linux-arm-kernel@bombadil.infradead.org; Thu, 12 Sep 2024 07:16:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=lh7l9YoHy4qkgvE49qc+r/MAsmVlGzV7/aids6D1De4=; b=iSUfEpqIdWDH09kx8bb6xX2hPK 59ZmjNEG5I3AhfqOFU9jo99WnncpcKX7iVw/7PhbOhynm63aYiaMTW5K+5ciI+xbn+ZTcag7W3HtR G+BjeVMMjAtttW9gwWDSWH/F/afTRELO0rPvcCMbADHv3CuDs2FooqnQ/+NOg4l2MvNgth8UF6op1 A0M/ZHh/bWJJc1nK9yFD3Y4+f7hgMB2rVp/eaSrPcRUfXMzwDgE3dVp1nNWlMfSPl1u/7i9x2il8I bxHyn1UwJZzqPIGT6KMMTsqoKqu9Ctv0u4jIuERufEAwzwyBDW6Rt28/5ecIRJX/DQWUTP8m2oDO5 dTiJ0UkQ==; Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1soe49-00000000OY7-2Ct0 for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 07:16:35 +0000 Received: by mail-pl1-x643.google.com with SMTP id d9443c01a7336-206bd1c6ccdso6576755ad.3 for ; Thu, 12 Sep 2024 00:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1726125390; x=1726730190; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lh7l9YoHy4qkgvE49qc+r/MAsmVlGzV7/aids6D1De4=; b=NGPpyaE3Tiq6tVRntkmADw916bFmMgSzh1OMg1XvCucTj8Dy8y/pNeExi9ZieeYPjj COnG+j7RShb+p0JRbcPYpx/sMryg/lPIkIk0I41bdk5zXLQqYh/F9f2/MV2mpzWezw07 DaUdBFhrVt+6WkWYKViA2oC1EbWo9oy40DPx8k3CWH3zI08tFQaBwP/nNJoupu0oeNyM ebNRGh17q9GMmuVC0UfDYSi6/T8roSUwqvSeoqAt5fCEZO+EdNpD7dP5mpxOl960FLx5 d26FMQZ0+fhU+BtrDE3sXLMz5tK9to/aVPYRPCWU2SRs29BE5RMdFoUtJvFkk3UDiI7B JHcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726125390; x=1726730190; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lh7l9YoHy4qkgvE49qc+r/MAsmVlGzV7/aids6D1De4=; b=nNo17fzb28ArNR5PdBS+INuGV+ik9lBym5fcjLJ36NNxekFVFvtR4sj5syMe6EjeeM RA3uUS5fIyuuPmgClCptMNWvr6ueCRxs9xiwt5IZ+6WWn8dnoYbv7DSEfdBwFO73givU x8dX2GvChFNLHm0tAxrPfrYu//+Mn+9snaQoUnjVwBHrh80LoRpYFkI5G1d8pfve8Quo pkQ1KJjeFCFZGPAGv2KMGHXmrh2D0edNmlxxTFZi7enS0VRbvrY2K3/H/LLDNV2M7Tjq AyLxZMEdavuK0Bdu3jUfgwB8FCNDSlWeVoKqMgn41XFixn5bjVO+n4IVa2UnDMoFim/O BrNA== X-Forwarded-Encrypted: i=1; AJvYcCX9P9JkBcSPCKUCXeqyC1tLsmoRnTKjw0KltoD9Y50plRwszPFeyGe20/fhU9abUndFGY0pQxFiyz6AjGqNYqBX@lists.infradead.org X-Gm-Message-State: AOJu0YzpfigO2Do3ToCmpWrLoMc7j5bKiQZNBT301To0ZULooRzuZKXw X6c50V7roN6jCHxJ1WRJ9Ii7PC4jUiQ6L+Nt1zHcipjm7LdEWMuY5NdIDHIj7g== X-Google-Smtp-Source: AGHT+IEgQUUi+YQfcBvAAIBX3uJLnFXqg+luxeETvddbtjlQ/UH/tax/cuWaglJLbLCWUuuqRX2lvQ== X-Received: by 2002:a17:902:da88:b0:206:b250:1e1 with SMTP id d9443c01a7336-2076e4239fdmr32667795ad.45.1726125389908; Thu, 12 Sep 2024 00:16:29 -0700 (PDT) Received: from [172.16.118.100] ([103.15.228.94]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dadb42e6fasm11951226a91.0.2024.09.12.00.16.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 00:16:29 -0700 (PDT) Message-ID: <097159c7-1602-4e32-8e6f-9cd023d62238@beagleboard.org> Date: Thu, 12 Sep 2024 12:46:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 8/8] addon_boards: mikrobus: Add GPS3 Click Content-Language: en-US To: Greg Kroah-Hartman , Ayush Singh Cc: fabien.parent@linaro.org, d-gole@ti.com, lorforlinux@beagleboard.org, jkridner@beagleboard.org, robertcnelson@beagleboard.org, Andrew Davis , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240911-mikrobus-dt-v1-0-3ded4dc879e7@beagleboard.org> <20240911-mikrobus-dt-v1-8-3ded4dc879e7@beagleboard.org> <2024091149-vocalize-composite-6e48@gregkh> <44039255-159a-4284-abd8-a0f558ad006d@gmail.com> <2024091151-unworldly-dance-9a80@gregkh> From: Ayush Singh In-Reply-To: <2024091151-unworldly-dance-9a80@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_081633_792977_6BCD7B14 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/12/24 01:34, Greg Kroah-Hartman wrote: > On Wed, Sep 11, 2024 at 09:26:06PM +0530, Ayush Singh wrote: >> On 9/11/24 20:28, Greg Kroah-Hartman wrote: >> >>> On Wed, Sep 11, 2024 at 07:57:25PM +0530, Ayush Singh wrote: >>>> - GPS3 Click is a UART MikroBUS addon Board >>>> >>>> Link: https://www.mikroe.com/gps-3-click >>>> >>>> Signed-off-by: Ayush Singh >>>> --- >>>> addon_boards/mikrobus/Makefile | 1 + >>>> addon_boards/mikrobus/mikroe-1714.dtso | 28 ++++++++++++++++++++++++++++ >>> Odd top-level directory for the kernel, are you sure this is correct? >>> >>> thanks, >>> >>> greg k-h >>> >> Well, it is kinda a temporary location, since well, I could not find a good >> place for board overlays but a top-level location seems better than putting >> them in any arch specific location. I am open to moving them to a more >> suitable location if we have one. > top-level location is not ok for something so tiny and "special". Just > put it where all other dtso files go. > > thanks, > > greg k-h So here are the directories where dtso files currently go: ❯ find . -type f -name "*.dtso" -printf "%h\n" | sort -u ./arch/arm64/boot/dts/amlogic ./arch/arm64/boot/dts/freescale ./arch/arm64/boot/dts/mediatek ./arch/arm64/boot/dts/qcom ./arch/arm64/boot/dts/renesas ./arch/arm64/boot/dts/rockchip ./arch/arm64/boot/dts/ti ./arch/arm64/boot/dts/xilinx ./arch/arm/boot/dts/nxp/imx ./arch/arm/boot/dts/ti/omap ./drivers/clk ./drivers/of ./drivers/of/unittest-data Out of these, `drivers/of` and `drivers/of/unittest-data` contain unittest dtso, so probably not the place. And the `arch/arm` and `arch/arm64` are for arch specific stuff. MikroBUS is supported in RISC-V boards as well (BeagleV-Ahead). So probably not the correct location either. Maybe something like `arch/common/addon_boards` would be better? Ayush Singh