Re: [PATCH 2/2] arm64: dts: imx8mp: Add support for DH electronics i.MX8M Plus DHCOM and PDK2

[Marek Vasut <marex@denx.de>]

On 6/12/22 03:01, Shawn Guo wrote:

[...]

>> +/*
>> + * PDK2 carrier board has KSZ9021 PHY populated and connected to SoM FEC
>> + * ethernet RGMII interface. The SoM is not populated with second FEC PHY.
>> + */
>> +/delete-node/ &ethphy1f;
>> +
>> +&fec {	/* Second ethernet */
>> +	phy-handle = <&ethphypdk>;
>> +
>> +	mdio {
>> +		ethphypdk: ethernet-phy@7 { /* KSZ 9021 */
>> +			compatible = "ethernet-phy-ieee802.3-c22";
>> +			pinctrl-0 = <&pinctrl_ethphy1>;
>> +			pinctrl-names = "default";
>> +			interrupt-parent = <&gpio4>;
>> +			interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>> +			max-speed = <100>;
>> +			reg = <7>;
>> +			reset-assert-us = <1000>;
>> +			reset-deassert-us = <1000>;
>> +			reset-gpios = <&gpio4 2 GPIO_ACTIVE_LOW>;
>> +			rxc-skew-ps = <3000>;
>> +			rxd0-skew-ps = <0>;
>> +			rxd1-skew-ps = <0>;
>> +			rxd2-skew-ps = <0>;
>> +			rxd3-skew-ps = <0>;
>> +			rxdv-skew-ps = <0>;
>> +			txc-skew-ps = <3000>;
>> +			txd0-skew-ps = <0>;
>> +			txd1-skew-ps = <0>;
>> +			txd2-skew-ps = <0>;
>> +			txd3-skew-ps = <0>;
>> +			txen-skew-ps = <0>;
> 
> Do we have a binding doc for these?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt#n46

>> +		};
>> +	};
>> +};
>> +
>> +&flexcan1 {
>> +	status = "okay";
>> +};
>> +
>> +&usb3_1 {
>> +	fsl,over-current-active-low;
> 
> Could you point me the bindings doc for this?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml#n64


>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi
>> new file mode 100644
>> index 0000000000000..a616eb3780025
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi

[...]

>> +	reg_eth_vio: regulator-eth-vio {
>> +		compatible = "regulator-fixed";
>> +		gpio = <&gpio2 10 GPIO_ACTIVE_LOW>;
>> +		pinctrl-0 = <&pinctrl_enet_vio>;
>> +		pinctrl-names = "default";
>> +		regulator-always-on;
> 
> You want this to be unmanaged and always-on?

Yes, this supplies the magnetics and there is no consumer in DT to model 
this. So for now, this regulator has to be always on.

>> +		regulator-boot-on;
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		regulator-name = "eth_vio";
>> +		vin-supply = <&buck4>;
>> +	};

[...]

The rest should be fixed in V2.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel