From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 743C5CA0FE0 for ; Fri, 30 Aug 2024 11:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gmv0Xnj2pecBxTVsbE2jx6EEH+ToOIyzUfmgybuly0Q=; b=BLRBi3Db2y//P7puM7UvHsPEEr Z/Z1Bf+pt+JxxZ38vMW1gAkAUEw5Vqnd3ku3epPuHXQY+XrfVj8xYBclcaKYQDITBzYgBis3PQ5U+ FAMiQnci8DorD/87C/jx79hrONwfL8nq7yLbjtG9efdrVP3uEyQjK/py2wxtIfyE3I7O7xm7hB/xB vmb3Wh1X5ItQ4+q98ueqTbd7RqC5Dy/I+43i5hRGyNgL81WUf+fxbljjNmnYK3Xp7WcNsTCjmGp3M N7dsmcQ/Xcfwa82Wyl6zPumJIxkEgxnl6TrlbhZR9EEgAKeYZwXi/oc+Qz0RdbtoYaObQqQEhQcfN 9T95X39Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjzQy-00000005xL8-0Ycx; Fri, 30 Aug 2024 11:04:52 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjzQ3-00000005x1G-0d7b; Fri, 30 Aug 2024 11:03:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 50B5AA44583; Fri, 30 Aug 2024 11:03:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 729DBC4CEC2; Fri, 30 Aug 2024 11:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725015834; bh=usFsqN8rw6jJgzE3LoXO1ibr/w7v/sbbk6GzQgZo84s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=h4Pelg4OuZmSA+H86fQvajI5AX/6qqQwKsU/N0SkPzu8x7Qv6XnYd0tO0fKZM8dtG 5OqqQ7YrT00eEyzkCd8+8kGcK07XgHLnFEQozGB+RS56vrwWjTDLLrX2jJ5wGHiG/T 6ZURzv67kaNMHHQ7RnWe+qlXsD40z1eQrTfqa7EtstMZyYRXqbE/9U7d5XQ+XTEAm0 2uJSYRnDIS6MyYsd9k4RYh6K3U5x6sfXbKUM8nwnVKjB6BNK3dH6XGCNo/13wuEVcu wvfpJvIrCs6oTlOosRd29bpl11gPAkhkxpzaatMlsKuKQ0OPnr4nPvLexVSlFWqVkP u4p9trkLVAJmw== Message-ID: <09aa43d6-9e8c-4f6e-ab49-dc4a9571e832@kernel.org> Date: Fri, 30 Aug 2024 13:03:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: airoha: Add EN7581 pinctrl controller To: Conor Dooley , Lorenzo Bianconi Cc: Christian Marangi , Rob Herring , Lorenzo Bianconi , Conor Dooley , Benjamin Larsson , Linus Walleij , Krzysztof Kozlowski , Conor Dooley , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, upstream@airoha.com References: <66c8c50f.050a0220.d7871.f209@mx.google.com> <20240826-kinsman-crunching-e3b75297088c@spud> <66ce1b04.df0a0220.a2131.6def@mx.google.com> <66d187f1.050a0220.3213d8.ad53@mx.google.com> <2c9aafdd-000b-4e8f-b599-4f57e7eb0ca7@kernel.org> <20240830-payphone-unexposed-75eed532c14d@wendy> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240830-payphone-unexposed-75eed532c14d@wendy> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_040355_355161_C3D2B011 X-CRM114-Status: GOOD ( 17.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/08/2024 13:01, Conor Dooley wrote: > On Fri, Aug 30, 2024 at 12:55:32PM +0200, Lorenzo Bianconi wrote: >> [...] >> >>>>>> >>>>>> Hi Rob, thanks a lot for the hint, I hope we can finally find a solution >>>>>> on how to implement this. >>>>>> >>>>>> In Documentation the block is called GPIO Controller. As explained it does >>>>>> expose pinctrl function AND pwm (with regs in the middle) >>>>>> >>>>>> Is this semplification really needed? It does pose some problem driver >>>>>> wise (on where to put the driver, in what subsystem) and also on the >>>>> >>>>> Sorry, but no, dt-bindings do not affect the driver at all in such way. >>>>> Nothing changes in your driver in such aspect, no dilemma where to put >>>>> it (the same place as before). >>>>> >>>> >>>> Ok, from the proposed node structure, is it problematic to move the >>>> gpio-controller and -cells in the pinctrl node? And also the pwm-cells >>>> to the pwm node? >>> >>> The move is just unnecessary and not neat. You design DTS based on your >>> drivers architecture and this is exactly what we want to avoid. >>> >>>> This is similar to how it's done by broadcom GPIO MFD [1] that also >>> >>> There are 'reg' fields, which is the main problem here. I don't like >>> that arguments because it entirely misses the discussions - about that >>> binding or other bindings - happening prior to merge. >>> >>>> expose pinctrl and other device in the same register block as MFD >>>> childs. >>>> >>>> This would be the final node block. >>>> >>>> mfd@1fbf0200 { >>>> compatible = "airoha,en7581-gpio-mfd"; >>>> reg = <0x0 0x1fbf0200 0x0 0xc0>; >>>> >>>> interrupt-parent = <&gic>; >>>> interrupts = ; >>>> >>>> pio: pinctrl { >>>> compatible = "airoha,en7581-pinctrl"; >>>> >>>> gpio-controller; >>>> #gpio-cells = <2>; >>>> >>>> interrupt-controller; >>>> #interrupt-cells = <2>; >>> >>> No resources here... >> >> ack. iiuc, all the properties will be in the parent node (mfd) and we will >> have just the compatible strings in the child ones, right? Something like: >> >> mfd@1fbf0200 { >> compatible = "airoha,en7581-gpio-mfd"; >> reg = <0x0 0x1fbf0200 0x0 0xc0>; >> gpio-controller; >> #gpio-cells = <2>; >> >> ... >> #pwm-cells = <3>; >> >> pio: pinctrl { >> compatible = "airoha,en7581-pinctrl"; >> }; >> >> pwm: pwm { >> compatible = "airoha,en7581-pwm"; >> }; >> }; > > > Didn't Rob basically tell you how to do it earlier in the thread? > What you've got now makes no sense, the compatibles only exist in that > to probe drivers, which you can do from the mfd driver with > mfd_add_devices() or w/e that function is called. Yep, we are making circles. I will repeat: "The move is just unnecessary and not neat. You design DTS based on your drivers architecture and this is exactly what we want to avoid." Best regards, Krzysztof