From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1EC7C433EF for ; Thu, 23 Dec 2021 14:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gWf6pKu5ToH+9omAeP2k9V4Xsx2X61UWwU1Pimf7rJo=; b=zeB1wbDDynWun2 w/tJ4dCT3CjJh53imRLKeeegfO6s4NFB7b4pdbdhkDENgpx6b8jS1goqoHCXZE2lVUuSHusAniq+9 1okvajq4y9svsaNjjCEune0A/aw9HpEJ4+r3On+xDyWC5nuqGtWCORDv1KS+RVRLS6JcJS9dmlRge g13kfnEu/dTkbiPXZMximXzorzo8B+LtGikNnMGRl3WLfAypIdOb6yyi9N8GucLq2g5VT0PD4H2C1 CwzEeNUUjWsQHgyi+0aoSBAwmkExO6MW807wR1lrBpcNzVv8shaRDjiXAw2q0FhHyiSFslxEvgj1v +uI9BpfOgcYnE4D7BpIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0OwS-00CsoZ-9i; Thu, 23 Dec 2021 14:19:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0OwP-00Csnt-1l for linux-arm-kernel@lists.infradead.org; Thu, 23 Dec 2021 14:19:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D186D6E; Thu, 23 Dec 2021 06:19:32 -0800 (PST) Received: from [10.57.66.229] (unknown [10.57.66.229]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E41FB3F5A1; Thu, 23 Dec 2021 06:19:29 -0800 (PST) Message-ID: <09bf1d0a-44d8-b382-2e08-e0c79f4fbbaf@arm.com> Date: Thu, 23 Dec 2021 14:19:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 2/2] iommu/arm-smmu: Propagate errors from platform_get_irq() Content-Language: en-GB To: Lad Prabhakar , Will Deacon , Joerg Roedel , Rob Clark , linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org Cc: Xin Tan , Sai Prakash Ranjan , "Isaac J. Manjarres" , Rob Herring , linux-kernel@vger.kernel.org, Prabhakar References: <20211223130046.9365-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211223130046.9365-3-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Robin Murphy In-Reply-To: <20211223130046.9365-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211223_061933_172323_C8E724A7 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-12-23 13:00, Lad Prabhakar wrote: > The driver overrides the error code returned by platform_get_irq() to > -ENODEV. Switch to propagating the error code upstream so that errors > such as -EPROBE_DEFER are handled. I wouldn't usually expect an SMMU to be wired up to a secondary interrupt controller that could cause deferral, but on the other hand I don't think there's any good reason *not* to propagate the original error anyway, so sure, why not. Reviewed-by: Robin Murphy > Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq") > Signed-off-by: Lad Prabhakar > --- > drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c > index 4844cd075644..6cf5612efcda 100644 > --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c > @@ -2129,7 +2129,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > int irq = platform_get_irq(pdev, i); > > if (irq < 0) > - return -ENODEV; > + return irq; > smmu->irqs[i] = irq; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel