Re: [PATCH v5 05/27] ARM: at91: pm: add sam9x7 SoC init config

[<Varshini.Rajendran@microchip.com>]

Hi Alexandre,

On 03/07/24 4:25 pm, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 03/07/2024 15:57:02+0530, Varshini Rajendran wrote:
>> Add SoC init config for sam9x7 family.
>>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>> ---
>> Changes in v5:
>> - Removed unnecessary header file.
>> - Added a space in the return type for clarity.
>> ---
>>   arch/arm/mach-at91/Makefile |  1 +
>>   arch/arm/mach-at91/sam9x7.c | 33 +++++++++++++++++++++++++++++++++
>>   2 files changed, 34 insertions(+)
>>   create mode 100644 arch/arm/mach-at91/sam9x7.c
>>
>> diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile
>> index 794bd12ab0a8..7d8a7bc44e65 100644
>> --- a/arch/arm/mach-at91/Makefile
>> +++ b/arch/arm/mach-at91/Makefile
>> @@ -7,6 +7,7 @@
>>   obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o
>>   obj-$(CONFIG_SOC_AT91SAM9)   += at91sam9.o
>>   obj-$(CONFIG_SOC_SAM9X60)    += sam9x60.o
>> +obj-$(CONFIG_SOC_SAM9X7)     += sam9x7.o
>>   obj-$(CONFIG_SOC_SAMA5)              += sama5.o sam_secure.o
>>   obj-$(CONFIG_SOC_SAMA7)              += sama7.o
>>   obj-$(CONFIG_SOC_SAMV7)              += samv7.o
>> diff --git a/arch/arm/mach-at91/sam9x7.c b/arch/arm/mach-at91/sam9x7.c
>> new file mode 100644
>> index 000000000000..e1ff30b5b09b
>> --- /dev/null
>> +++ b/arch/arm/mach-at91/sam9x7.c
>> @@ -0,0 +1,33 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * Setup code for SAM9X7.
>> + *
>> + * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries
>> + *
>> + * Author: Varshini Rajendran <varshini.rajendran@microchip.com>
>> + */
>> +
>> +#include <linux/of.h>
>> +#include <linux/of_platform.h>
>> +
>> +#include <asm/mach/arch.h>
>> +
>> +#include "generic.h"
>> +
>> +static void __init sam9x7_init(void)
>> +{
>> +     of_platform_default_populate(NULL, NULL, NULL);
> 
> Can you check whether this call is actually needed to boot the platform?
> 
Though the system boots, I can see many failures in crucial devices 
getting probed.

>> +
>> +     sam9x7_pm_init();
>> +}
>> +
>> +static const char * const sam9x7_dt_board_compat[] __initconst = {
>> +     "microchip,sam9x7",
>> +     NULL
>> +};
>> +
>> +DT_MACHINE_START(sam9x7_dt, "Microchip SAM9X7")
>> +     /* Maintainer: Microchip */
>> +     .init_machine   = sam9x7_init,
>> +     .dt_compat      = sam9x7_dt_board_compat,
>> +MACHINE_END
>> --
>> 2.25.1
>>
> 
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-- 
Thanks and Regards,
Varshini Rajendran.