From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61069C282DE for ; Mon, 10 Mar 2025 17:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KEBYcpGn1n6RrVtFHlaz6mqXjlV/ALIYQSMdCZe2f10=; b=M1A031WDVPy59HDmWeMkyOe2dH g1wD/ZEivgkiemhT1rLd6rCfIqeMQtDLJDs5PD6RPfrKuashU9UTAJOGCOSP4XEOpchLORIwVZ/aO MGioBcgQUPG51lAQs2RC7kCw9BR7TTRlot0ej6Wg1bePIL8mzoAyFRKWOiirVp1S9r0pVW7HHRye6 h3jnHZTPt+riogih/P1Ay6p15eHfBsjMCIyDlFFBEplAQOmyB3PUlkYm1fkAjlSiJW61yJdPZah8/ 7z9rHRuExSkoGODK4DhfeprBzLdVZNXZYrvW3/Q8zbnvxxvtYeY1B/a9JzcZWQxT6Kk+po3j2L2ZG XmeSdWFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1trh9x-00000003WEX-2y7A; Mon, 10 Mar 2025 17:43:25 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1trh8L-00000003WBB-1gZg for linux-arm-kernel@bombadil.infradead.org; Mon, 10 Mar 2025 17:41:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=KEBYcpGn1n6RrVtFHlaz6mqXjlV/ALIYQSMdCZe2f10=; b=Re/qWjcpblZ31FbpIhkYZemJok mn/Uu26PJKLVuZ5j/azus1oWYADNHkHvTqeCXpnjpsHdf6iV2zFT8krjQSsavyAaPS34kBHulMQ35 iNcaTa1rKsgcxt4SJ/5Bf3tppd0I+FBbLBfJghy6enjLAz6sc3rIciPN8rHFDD9NxGMbbmIK98ku6 /j4JQKjo+7xC/TTZd6iyQfyj973TVYp8R8iUvLlj/fIy7G8lpflO4ciEs2fOrezqJKogwD0Q1/P8n xdGZedFsYWbaPUvCHu4gpmN0GZHBudcatt4yyrpjdFoLiwx+Du2QdERyOIKpjs4HnlhxMf58yAdHY VlYXVFSg==; Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1trh8I-00000001zik-2cvm for linux-arm-kernel@lists.infradead.org; Mon, 10 Mar 2025 17:41:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id BC81BA41C25; Mon, 10 Mar 2025 17:35:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD8CCC4CEEC; Mon, 10 Mar 2025 17:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741628439; bh=/HSXNv6jjAsvPNyHRljUMfbh7KlOC2ngXOFs6zAfk84=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VvF1LjyN6hol5ApChxSIKL9i1sN5DyrBVGAP1DW7djfZER1h39Fftx9arwwUTH8iv ebhegtRdiAweL6n/sKFSQM9jnZz6PNuBH08e2okZB7dVzJ6NmwfM7RH0lmgua8/JvS 6apFviR4/5lcXx6xh2OtzlrE2kOeoXL0vSC2bE4hxBfe7dQMtBlMmc7+lW/h7D6vkw 2C+LGsAsfHI9rMwJ+wMpvV0b8gxzFS6k1RXc7qUxHQz1CPbMylZWpD+BFSm6u9Ro9K w/P5HthKbOvlQOdIsod7A3CTeOsKFfh78jN5LBcCxVOcDbj/s3zxr4DLvCqUFcrVPC l4pGFCRZPaVNw== Message-ID: <09d4966a-5804-40a4-9c5f-356a954a7704@kernel.org> Date: Mon, 10 Mar 2025 18:40:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hyperv-next v5 07/11] dt-bindings: microsoft,vmbus: Add interrupts and DMA coherence To: Roman Kisel Cc: arnd@arndb.de, bhelgaas@google.com, bp@alien8.de, catalin.marinas@arm.com, conor+dt@kernel.org, dave.hansen@linux.intel.com, decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com, joey.gouly@arm.com, krzk+dt@kernel.org, kw@linux.com, kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org, mark.rutland@arm.com, maz@kernel.org, mingo@redhat.com, oliver.upton@linux.dev, rafael@kernel.org, robh@kernel.org, ssengar@linux.microsoft.com, sudeep.holla@arm.com, suzuki.poulose@arm.com, tglx@linutronix.de, wei.liu@kernel.org, will@kernel.org, yuzenghui@huawei.com, devicetree@vger.kernel.org, kvmarm@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, apais@microsoft.com, benhill@microsoft.com, bperkins@microsoft.com, sunilmut@microsoft.com References: <20250307220304.247725-1-romank@linux.microsoft.com> <20250307220304.247725-8-romank@linux.microsoft.com> <20250310-demonic-ferret-of-judgment-5dbdbf@krzk-bin> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250310_174142_903469_86A8C8DF X-CRM114-Status: GOOD ( 25.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/03/2025 18:05, Roman Kisel wrote: > > > On 3/10/2025 2:28 AM, Krzysztof Kozlowski wrote: >> On Fri, Mar 07, 2025 at 02:02:59PM -0800, Roman Kisel wrote: >>> To boot on ARM64, VMBus requires configuring interrupts. Missing >>> DMA coherence property is sub-optimal as the VMBus transations are >>> cache-coherent. >>> >>> Add interrupts to be able to boot on ARM64. Add DMA coherence to >>> avoid doing extra work on maintaining caches on ARM64. >> >> How do you add it? >> > > I added properties to the node. Should I fix the description, or I am > misunderstanding the question? I saw interrupts in the schema, but I did not see dma-coherence. I also did not see any DTS patches here, so I don't understand what node you are referring to. > >>> >>> Signed-off-by: Roman Kisel >>> --- >>> .../devicetree/bindings/bus/microsoft,vmbus.yaml | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml b/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml >>> index a8d40c766dcd..3ab7d0116626 100644 >>> --- a/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml >>> +++ b/Documentation/devicetree/bindings/bus/microsoft,vmbus.yaml >>> @@ -28,13 +28,16 @@ properties: >>> required: >>> - compatible >>> - ranges >>> + - interrupts >>> - '#address-cells' >>> - '#size-cells' >>> >>> -additionalProperties: false >>> +additionalProperties: true >> >> This is neither explained in commit msg nor correct. >> > > Not explained, as there is no good explanation as described below. > >> Drop the change. You cannot have device bindings ending with 'true' >> here - see talks, example-bindings, writing-schema and whatever resource >> is there. >> > > Thanks, I'll put more effort into bringing this into a better form! > If you have time, could you comment on the below? > > The Documentation says > > * additionalProperties: true > Rare case, used for schemas implementing common set of properties. > Such schemas are supposed to be referenced by other schemas, which then > use 'unevaluatedProperties: false'. Typically bus or common-part schemas. > > This is a bus so I added that line to the YAML, and I saw it in many If this is a bus, then where is schema using it for bus-attached-devices? You cannot have bus without devices. You *must* fulfill that part: "Such schemas are supposed to be referenced by other schemas, which then" instead of calling it bus... Please upstream bindings for the bus devices and extend the example here with these devices. Or this is not bus (calling something vmpony does not make it a pony). Best regards, Krzysztof