Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Cc: alim.akhtar@samsung.com, bhelgaas@google.com,
	jingoohan1@gmail.com, kwilczynski@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, lpieralisi@kernel.org,
	mani@kernel.org, peter.griffin@linaro.org, robh@kernel.org
Subject: Re: [PATCH v8] PCI: exynos: Handle PCIe PHY initialization errors
Date: Thu, 19 Nov 2026 13:10:14 +0100	[thread overview]
Message-ID: <0a3b7886-3800-42ee-8e22-80944114dfcf@kernel.org> (raw)
In-Reply-To: <20261031073548.3916-1-sreekuttan2156239@gmail.com>

On 31/10/2026 08:35, Sreeraj S Kurup wrote:
> Check the return values of phy_init() and phy_power_on() to avoid
> continuing PCIe host initialization when PHY setup fails.
> 
> Track PHY initialization, PHY power, and regulator enable state
> across probe, remove, suspend, and resume to ensure cleanup is
> performed only when appropriate and to prevent unbalanced
> reference counts.
> 
> Assert core reset on probe failure after PHY initialization has
> been reached, and handle cleanup errors during teardown and
> suspend.
> 
> Also check the return value of exynos_pcie_host_init() during
> resume and abort the resume sequence if PHY initialization fails.
> 
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
> ---
> v8:
>  - Fix state desynchronization in exynos_pcie_phy_exit() by returning
>    early if phy_power_off() fails, preventing calls to phy_exit() on a
>    still-powered PHY
>  - Prevent PM core desynchronization and orphaned controller states
>    during suspend-abort sequences in exynos_pcie_suspend_noirq() by
>    logging teardown errors and returning 0 instead of aborting system
>    suspend
> v7:

How many of these are you going to send (even the same day...) till you
get it right? The process is not random punching review system till you
get it past it. Sending random code till bot stops to complain only
proves that you do not understand what you sent.

I have zero confidence that you understand what you are doing and all
this looks like LLM slop sent to us. Why would we want LLM slop?

Best regards,
Krzysztof


  reply	other threads:[~2026-11-19 12:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 13:10 [PATCH] PCI: exynos: Handle PHY initialization errors Sreeraj S Kurup
2026-10-29 17:54 ` [PATCH v2] PCI: exynos: Handle PCIe " Sreeraj S Kurup
2026-10-30 15:17 ` [PATCH v3] " Sreeraj S Kurup
2026-10-30 16:36 ` [PATCH v4] " Sreeraj S Kurup
2026-10-30 17:23 ` [PATCH v5] " Sreeraj S Kurup
2026-10-30 18:09 ` [PATCH v6] " Sreeraj S Kurup
2026-10-31  7:01 ` [PATCH v7] " Sreeraj S Kurup
2026-10-31  7:35 ` [PATCH v8] " Sreeraj S Kurup
2026-11-19 12:10   ` Krzysztof Kozlowski [this message]
2026-10-31  9:49 ` [PATCH v9] " Sreeraj S Kurup
2026-11-19 10:52   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a3b7886-3800-42ee-8e22-80944114dfcf@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=bhelgaas@google.com \
    --cc=jingoohan1@gmail.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=sreekuttan2156239@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox