From: Marc Zyngier <maz@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH 1/2] irqchip/gic: Handle non-standard SGI deactivation on Samsung's Franken-GIC
Date: Tue, 15 Sep 2020 15:52:15 +0100 [thread overview]
Message-ID: <0a9212ef8a350bb78a145dab704a580e@kernel.org> (raw)
In-Reply-To: <d1301d9c-5529-0089-f163-2a728055712c@samsung.com>
On 2020-09-15 15:06, Marek Szyprowski wrote:
> On 15.09.2020 15:39, Marc Zyngier wrote:
>> The GIC available on some of Samsung's A9-based platform is
>> thankfully one of a kind. On top of not presenting a banked
>> programing model (each CPU has its own base addresses for both
>> distributor and CPU interface), it also encodes the source CPU
>> for SGIs in the INTID read from IAR, and requires this exact
>> value to be written back to EOI.
>>
>> Without this, interrupts are never deactivated, and the kernel
>> grinds to a halt.
>>
>> Work around it by stashing the INTID for in-flight SGIs, and
>> using that value on EOI. This only works because we don't nest
>> SGIs.
>>
>> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Fixes: ac063232d4b0 ("irqchip/gic: Configure SGIs as standard
>> interrupts")
>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>
> Works fine, thanks!
>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Thanks for having reported the failure, and your patience with testing
all kind of random things! ;-)
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-15 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 13:39 [PATCH 0/2] irqchip/gic: Fix handling of Samsung's non-standard GIC Marc Zyngier
2020-09-15 13:39 ` [PATCH 1/2] irqchip/gic: Handle non-standard SGI deactivation on Samsung's Franken-GIC Marc Zyngier
2020-09-15 14:06 ` Marek Szyprowski
2020-09-15 14:52 ` Marc Zyngier [this message]
2020-09-15 13:39 ` [PATCH 2/2] irqchip/gic: Cleanup Franken-GIC handling Marc Zyngier
2020-09-15 14:06 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a9212ef8a350bb78a145dab704a580e@kernel.org \
--to=maz@kernel.org \
--cc=jason@lakedaemon.net \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).