From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF3DC43219 for ; Fri, 3 May 2019 14:39:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A24CF2075E for ; Fri, 3 May 2019 14:39:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CbZIqje0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A24CF2075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Ui2PFTMKVUEvim0JHBDIx6mzQIolO9FcS94/PUr92s=; b=CbZIqje0lvdbp+ DpI8Vd0zyJnlN4LvSC6ZEH80g8M78pI0TsHzY6Yw71kwD5Epj31CqMW0Fn9FdpBuY8KImWQ2yjDIy 4eQgP0+bEKwKIC4LWoOjSwtZDbbaOcsCT0n8ZKDodBCT3lUtu/dH4KVBzO7wIhUKdct+SQ1gqbVmq vc8H34qsCSU4NjqZy6fkTW5A1MBPKKuJr2GcTAk2mu5CcmyeNA6v3fazBtsKUnoHeaZkzySCorPXF tadHk3WaAR3mYKWqEHwwTYQOSz1ZIZe6+FlSJV+CP0WWrcN5+Scq/8zUTAGSVnreIVylt5Trej3cF zw3dRSWeEc4h9mNNxtbQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMZLl-0006q9-L3; Fri, 03 May 2019 14:39:45 +0000 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMZLi-0006pd-9M for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2019 14:39:43 +0000 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-113-LyrG2MGFMYeVaRNCuyPBFw-1; Fri, 03 May 2019 15:39:35 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b::d117) by AcuMS.aculab.com (fd9f:af1c:a25b::d117) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 3 May 2019 15:39:32 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Fri, 3 May 2019 15:39:32 +0100 From: David Laight To: 'Philippe Schenker' , "linux-iio@vger.kernel.org" , Jonathan Cameron , "Stefan Agner" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Subject: RE: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible Thread-Topic: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible Thread-Index: AQHVAbg3A7HWDrzd+kO5dj2pSSFp8qZZeDWw Date: Fri, 3 May 2019 14:39:32 +0000 Message-ID: <0aab3e91bb9644acb430a8beba927b5a@AcuMS.aculab.com> References: <20190503135725.9959-1-dev@pschenker.ch> <20190503135725.9959-2-dev@pschenker.ch> In-Reply-To: <20190503135725.9959-2-dev@pschenker.ch> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: LyrG2MGFMYeVaRNCuyPBFw-1 X-Mimecast-Spam-Score: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190503_073942_620141_A4915F58 X-CRM114-Status: UNSURE ( 7.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Krummenacher , Alexandre Torgue , "linux-kernel@vger.kernel.org" , Philippe Schenker , Maxime Coquelin , Lee Jones , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Philippe Schenker > Sent: 03 May 2019 14:57 > In some cases, the wait_completion got interrupted. This caused the > error-handling to mutex_unlock the function. The before turned on > interrupt then got called anyway. In the ISR then completion() > was called causing problems. > > Making this wait_completion non interruptible solves the problem. Won't the same thing happen if the interrupt occurs just after the timeout? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel