From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AC55EB64D7 for ; Fri, 30 Jun 2023 05:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YjuyXm9O9BSMHdljYCY5iwHSakiuZgD1wc8xASp4pno=; b=levq2lhnyveNsf ASpDjiWYkY/6fMDVYfVJEM+lapH0FG9JoWTN02en9tCP69fzlhGywXmN+mho35dYLE5eiSvPDaAAA P/l6M448TSWv/EwfpuTWRKKgJaYJ/Kp76erFvVtt0hfN2bpWJcLRkO6pxc9dn+f8uz6NkHJ+aL/vm IVSQkb5ukPIHr5x2bOtIUTujpGPI19GpEo+SGeBDEzEbANmo3gZM8vw2pfc1zC82sdV0Zoe5VSQqN vaj7ybgXjlvxBqx0fXb0FXCKBEc9Vl5stetYVxo+z5m++912HWo0GMc4LRWtl7CDlKUl/aj4s3zQ7 IF0qXY9+xnYqbFXBe9uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qF6e7-002vSB-2Y; Fri, 30 Jun 2023 05:26:15 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qF6e4-002vRg-11 for linux-arm-kernel@lists.infradead.org; Fri, 30 Jun 2023 05:26:13 +0000 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35U5O1Zr014109; Fri, 30 Jun 2023 05:25:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=HFQXNzIcvaGV8VLNOglVGjxnRqTQMHy3qp9WNXgE8fw=; b=IsyOnS5raZ1GJglVGuGBhJhzEUxls0AnM50+kxJeEromMzlxvzuNznVo+qxLkLTgOB0u JQ/KYM7IGrvrZ5x1k4ixfXrguYSoDn+afoImKvhXznwj0PPU21ozwHD7nFxlCt4XwWME cRC/jC4UsisD+BVjt1j9a635fg5rR99/vmJtLNF6MVY3pjsbIZqtACkQAdA9Mr7ZynmL 0w0wtoWmAqmTFWhQEoz7ZH4gT/JbHWzcHh3u3aqg2dj1LQH7p33YsBLKgKw4b+sZl6yA pBC6qVjkvwbBStQIya0P0AzL0TjI81aVouqyECFzJnLCEws9dzk75patM2WTMIKvo4me 1w== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rh2ks2kj4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 05:25:54 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35U5PrmQ009221 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 05:25:53 GMT Received: from hu-pkondeti-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.7; Thu, 29 Jun 2023 22:25:46 -0700 Date: Fri, 30 Jun 2023 10:55:39 +0530 From: Pavan Kondeti To: Mukesh Ojha CC: , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 20/21] firmware: qcom_scm: Refactor code to support multiple download mode Message-ID: <0ac3e4cd-485e-43a4-ae76-4c462a8145ed@quicinc.com> References: <1687955688-20809-1-git-send-email-quic_mojha@quicinc.com> <1687955688-20809-21-git-send-email-quic_mojha@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1687955688-20809-21-git-send-email-quic_mojha@quicinc.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: aNMQl7VkIbhpDKzXPC8P1qvAgPDdSJEs X-Proofpoint-ORIG-GUID: aNMQl7VkIbhpDKzXPC8P1qvAgPDdSJEs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-30_02,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306300046 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230629_222612_363494_4AD5AEAC X-CRM114-Status: GOOD ( 33.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 28, 2023 at 06:04:47PM +0530, Mukesh Ojha wrote: > Currently on Qualcomm SoC, download_mode is enabled if > CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT is selected. > > Refactor the code such that it supports multiple download > modes and drop CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT config > instead, give interface to set the download mode from > module parameter. > > Signed-off-by: Mukesh Ojha > --- > drivers/firmware/Kconfig | 11 --------- > drivers/firmware/qcom_scm.c | 56 +++++++++++++++++++++++++++++++++++++++------ > 2 files changed, 49 insertions(+), 18 deletions(-) > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index b59e3041fd62..ff7e9f330559 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -215,17 +215,6 @@ config MTK_ADSP_IPC > config QCOM_SCM > tristate > > -config QCOM_SCM_DOWNLOAD_MODE_DEFAULT > - bool "Qualcomm download mode enabled by default" > - depends on QCOM_SCM > - help > - A device with "download mode" enabled will upon an unexpected > - warm-restart enter a special debug mode that allows the user to > - "download" memory content over USB for offline postmortem analysis. > - The feature can be enabled/disabled on the kernel command line. > - > - Say Y here to enable "download mode" by default. > - > config SYSFB > bool > select BOOT_VESA_SUPPORT > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index a9ff77d16c42..946cb0f76a17 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -18,13 +18,13 @@ > #include > #include > #include > +#include > #include > #include > > #include "qcom_scm.h" > > -static bool download_mode = IS_ENABLED(CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT); > -module_param(download_mode, bool, 0); > +static u32 download_mode; > > #define SCM_HAS_CORE_CLK BIT(0) > #define SCM_HAS_IFACE_CLK BIT(1) > @@ -82,6 +82,11 @@ static const char * const qcom_scm_convention_names[] = { > [SMC_CONVENTION_LEGACY] = "smc legacy", > }; > > +static const char * const download_mode_name[] = { > + [QCOM_DOWNLOAD_NODUMP] = "off", > + [QCOM_DOWNLOAD_FULLDUMP] = "full", > +}; > + > static struct qcom_scm *__scm; > > static int qcom_scm_clk_enable(void) > @@ -442,8 +447,9 @@ static int __qcom_scm_set_dload_mode(struct device *dev, bool enable) > return qcom_scm_call_atomic(__scm->dev, &desc, NULL); > } > > -static void qcom_scm_set_download_mode(bool enable) > +static void qcom_scm_set_download_mode(u32 download_mode) > { > + bool enable = !!download_mode; > bool avail; > int val; > int ret = 0; > @@ -454,7 +460,7 @@ static void qcom_scm_set_download_mode(bool enable) > if (avail) { > ret = __qcom_scm_set_dload_mode(__scm->dev, enable); > } else if (__scm->dload_mode_addr) { > - val = (enable ? QCOM_DOWNLOAD_FULLDUMP : QCOM_DOWNLOAD_NODUMP); > + val = download_mode; > val <<= QCOM_DOWNLOAD_MODE_SHIFT; > ret = qcom_scm_io_update_field(__scm->dload_mode_addr, > QCOM_DOWNLOAD_MODE_MASK, val); > @@ -1425,6 +1431,42 @@ static irqreturn_t qcom_scm_irq_handler(int irq, void *data) > return IRQ_HANDLED; > } > > +static int get_download_mode(char *buffer, const struct kernel_param *kp) > +{ > + if (download_mode >= ARRAY_SIZE(download_mode_name)) > + return sysfs_emit(buffer, "unknown mode\n"); > + > + return sysfs_emit(buffer, "%s\n", download_mode_name[download_mode]); > +} > + > +static int set_download_mode(const char *val, const struct kernel_param *kp) > +{ > + u32 old = download_mode; > + int ret; > + > + ret = sysfs_match_string(download_mode_name, val); > + if (ret < 0) { > + download_mode = old; > + pr_err("qcom_scm: unknown download mode: %s\n", val); > + return -EINVAL; > + } minor nit: %s/-EINVAL/ret > + > + download_mode = ret; > + if (__scm) > + qcom_scm_set_download_mode(download_mode); > + > + return 0; > +} > + > +static const struct kernel_param_ops download_mode_param_ops = { > + .get = get_download_mode, > + .set = set_download_mode, > +}; > + > +module_param_cb(download_mode, &download_mode_param_ops, NULL, 0644); > +MODULE_PARM_DESC(download_mode, > + "download mode: off/full are acceptable values"); > + Since we are adding a sysfs file under /sys/module/qcom_scm/ , does it need to be documented under ABI? Thanks, Pavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel