From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74AABC30653 for ; Thu, 4 Jul 2024 04:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V0bROoDmShRfYVJWcxUuDLMgaTkSSIsgbDg3S3gFNUs=; b=jnv42DI6yf7glvLUH6uEAlrPPE R+T8KObGfYB04Up8U5FoREbf0gEDnUcYpBUmKelDMO1OYDfcUY/f2kdygDBAgGflIEt5N3W2K+VMC Twiqln6b0EksonYHFqwA5lUhBnCagx6lNa1WbABQ1XCH4eUh0TKgE90WPRGCvMo6JLAD9ye61ERLl Us1Vxnn3h6Wwgy8GHh2dK3Vt6HBZj6hVMS/RpfFuPOj/5aK2DbITlnBYLAFVdmJb3WeMFLpMofsIw HzzTmb8fm8B9sDF9Gh/GCkkgRor5fjV1oj0Vtaa8Q2xpcFws0nmNdZQq50n4JJREWN6m54GMI14wm N1Mk+lRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPEQL-0000000CASA-0O8K; Thu, 04 Jul 2024 04:50:25 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPEQ7-0000000CAR0-3ACZ for linux-arm-kernel@lists.infradead.org; Thu, 04 Jul 2024 04:50:13 +0000 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2ebe6495aedso1975311fa.0 for ; Wed, 03 Jul 2024 21:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720068609; x=1720673409; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V0bROoDmShRfYVJWcxUuDLMgaTkSSIsgbDg3S3gFNUs=; b=R2jjN1ec3PLcLVuTUZzXwDv/CFvLW+K13EGrgJKxGZwGDaDAAl1zTLw1VjWMtUzsvU qkiLHiSDQAZwLQgUVlDolFAHo6n0q87LfUcKedBgFBeV7T2fISnMYvpG41b25ojrelw9 3adAuhasTuG1DnYjKjBN3UMZ8z4pr4RF8hgIe6o/BJR7pNaj7sFUWOtnimxmkYv9cKC2 IldIs4sRcUXHIjbRnra9Ca9yj7b/9e4mJa8reBQMICsbjj4P4mnH/Kw+hKg+aO7aEIEK Vm7ExhqgdjR8cwJ73GO3hMJW+W6diSP2VEgBQZTFxQWfZ+2q8fi5a64ZtDJnWKHshNJr 7R/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720068609; x=1720673409; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V0bROoDmShRfYVJWcxUuDLMgaTkSSIsgbDg3S3gFNUs=; b=kZLFzsqgvgUcbV8i/z2qh1UcmuOYBpU05tgQiNTG27XkjBUpo6LR6JCcU0k29xF2XG 78hamjfXdmnLgB839PKo8AeEeMOM2cBXbu60a0i112ia3pp1l2Nvkqo1MiHClH62/wYv 2hV474MNMIs3lMvjCPp65zyZBVshtICf3SFyxpdH9XreWo1un+Km+CZLNVfTCxOg9TFr B6KIIBb5z7VGVKcwSOLQIUWxskXzWnNhMoXLKrhY/u6qssL8x0tHSPbo4hYzimfUAein RJXK0OKqSipHvu+vOVQ1DHD10a9+pFJQh8Q4B80XNzy3Pr8OdEGA/PCJ7b0hnGXZnD6A LhFA== X-Forwarded-Encrypted: i=1; AJvYcCWDbpiwzmpUCQvX3OvcuAEgOk6osjvot0pj6nvjp78S6YG4rky80nyd1bHMHJ+tF8FptRagtL+vgnDxFSQ39ziuh/urmlso3EQsCXcaUUkTDsL5rZ4= X-Gm-Message-State: AOJu0YxvfMGZD4Mx5bKwWGO07yoDAJwpRNJ9suiR2cFrPHAhhOrYVYNK eOEh9WzDkPeH1q5m8EFxSdyNzfgO4d9sfk6d+zgrESQ5nMD3gWpe X-Google-Smtp-Source: AGHT+IEHJ/ykgTHYMcUkN63qNzxJ9bqb6cfleOPZzzFBtF0u/7T8g8zQl8zXAPBuMB/j6J0C6id8ug== X-Received: by 2002:a2e:a497:0:b0:2ee:8777:f868 with SMTP id 38308e7fff4ca-2ee8edc2deemr2275391fa.35.1720068608661; Wed, 03 Jul 2024 21:50:08 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8cfe:d6e7:6701:9dfd? ([2a10:a5c0:800d:dd00:8cfe:d6e7:6701:9dfd]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ee871e7a66sm3138181fa.82.2024.07.03.21.50.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jul 2024 21:50:07 -0700 (PDT) Message-ID: <0acd9da5-80ec-4a45-b00a-8e28ab4e345a@gmail.com> Date: Thu, 4 Jul 2024 07:50:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] mfd: rohm-bd9576: Constify struct regmap_config To: Javier Carrasco , Support Opensource , Lee Jones , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Xu Yilun , Tom Rix Cc: linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20240703-mfd-const-regmap_config-v1-0-aa6cd00a03bd@gmail.com> <20240703-mfd-const-regmap_config-v1-6-aa6cd00a03bd@gmail.com> Content-Language: en-US, en-GB From: Matti Vaittinen In-Reply-To: <20240703-mfd-const-regmap_config-v1-6-aa6cd00a03bd@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240703_215011_834813_B8A89E45 X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/3/24 18:37, Javier Carrasco wrote: > `bd957x_regmap` is not modified and can be declared as const > to move its data to a read-only section. > > Signed-off-by: Javier Carrasco > --- > drivers/mfd/rohm-bd9576.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c > index 3a9f61961721..634c65c7d108 100644 > --- a/drivers/mfd/rohm-bd9576.c > +++ b/drivers/mfd/rohm-bd9576.c > @@ -57,7 +57,7 @@ static const struct regmap_access_table volatile_regs = { > .n_yes_ranges = ARRAY_SIZE(volatile_ranges), > }; > > -static struct regmap_config bd957x_regmap = { > +static const struct regmap_config bd957x_regmap = { > .reg_bits = 8, > .val_bits = 8, > .volatile_table = &volatile_regs, > Thanks a ton Javier. This looks good to me but if you feel like going an extra mile while you are at it... Do you think this could be extended to: diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c index 3a9f61961721..17323ae39803 100644 --- a/drivers/mfd/rohm-bd9576.c +++ b/drivers/mfd/rohm-bd9576.c @@ -57,7 +57,7 @@ static const struct regmap_access_table volatile_regs = { .n_yes_ranges = ARRAY_SIZE(volatile_ranges), }; -static struct regmap_config bd957x_regmap = { +static const struct regmap_config bd957x_regmap = { .reg_bits = 8, .val_bits = 8, .volatile_table = &volatile_regs, @@ -65,7 +65,7 @@ static struct regmap_config bd957x_regmap = { .cache_type = REGCACHE_MAPLE, }; -static struct regmap_irq bd9576_irqs[] = { +static const struct regmap_irq bd9576_irqs[] = { REGMAP_IRQ_REG(BD9576_INT_THERM, 0, BD957X_MASK_INT_MAIN_THERM), REGMAP_IRQ_REG(BD9576_INT_OVP, 0, BD957X_MASK_INT_MAIN_OVP), REGMAP_IRQ_REG(BD9576_INT_SCP, 0, BD957X_MASK_INT_MAIN_SCP), @@ -76,7 +76,7 @@ static struct regmap_irq bd9576_irqs[] = { REGMAP_IRQ_REG(BD9576_INT_SYS, 0, BD957X_MASK_INT_MAIN_SYS), }; -static struct regmap_irq_chip bd9576_irq_chip = { +static const struct regmap_irq_chip bd9576_irq_chip = { .name = "bd9576_irq", .irqs = &bd9576_irqs[0], .num_irqs = ARRAY_SIZE(bd9576_irqs), Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~