From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D660C10F04 for ; Mon, 4 Dec 2023 10:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RLzEGFleWXq1MxPu9uwFkUNDU/20V97utgo2JmCegXY=; b=mCLMHscovzpiSj /5d4ngfkng5t/Cx6zJWncUd3dlQaCmLpDxw4e8pOYySFmRrUwrj5k4ThtsZOgkDPL0seSA6Onmcrh 4bAGnXbXr4uo8pS5MhpY7yzSLobdfq1/aqNNO9JT1ldvSzz1ryRYfhUYH1u58wPEL08QrPrM+LOTX kXeKFPiLWhou6PdQiKzA/BgMuCJiKyJE+7CCTcjHueo9iPj/P9VJM9Ek6IIeRbmUH0+QjvGcr/UzP Hk4cFIm0x0eQuWw6fRsoI3e9w0RCdBLJLf1ZpaYC87DsvZEGBSUUbfzrrm4WUCAq1OHEuzbwWKWFX UGZNrg/FKudApHM1fcGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA67J-003WyK-0T; Mon, 04 Dec 2023 10:23:57 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA67E-003Wy1-1z for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 10:23:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C06E16F8; Mon, 4 Dec 2023 02:24:38 -0800 (PST) Received: from [192.168.1.3] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F1F73F6C4; Mon, 4 Dec 2023 02:23:49 -0800 (PST) Message-ID: <0adc3a16-0fc4-2a25-cd48-4667881b9490@arm.com> Date: Mon, 4 Dec 2023 10:23:49 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH V2 6/7] coresight: stm: Move ACPI support from AMBA driver to platform driver Content-Language: en-US To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com Cc: Lorenzo Pieralisi , Sudeep Holla , Mike Leach , Maxime Coquelin , Alexandre Torgue , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-stm32@st-md-mailman.stormreply.com References: <20231201062053.1268492-1-anshuman.khandual@arm.com> <20231201062053.1268492-7-anshuman.khandual@arm.com> From: James Clark In-Reply-To: <20231201062053.1268492-7-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_022352_872946_9C86B6FB X-CRM114-Status: GOOD ( 13.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/12/2023 06:20, Anshuman Khandual wrote: > Add support for the stm devices in the platform driver, which can then be > used on ACPI based platforms. This change would now allow runtime power > management for ACPI based systems. The driver would try to enable the APB > clock if available. > > Cc: Lorenzo Pieralisi > Cc: Sudeep Holla > Cc: Suzuki K Poulose > Cc: Mike Leach > Cc: James Clark > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: linux-acpi@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: coresight@lists.linaro.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Signed-off-by: Anshuman Khandual > --- [...] > > -module_amba_driver(stm_driver); > +static int stm_platform_probe(struct platform_device *pdev) > +{ > + struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + int ret = 0; > + > + pm_runtime_get_noresume(&pdev->dev); > + pm_runtime_set_active(&pdev->dev); > + pm_runtime_enable(&pdev->dev); > + > + ret = __stm_probe(&pdev->dev, res, NULL); Very minor nit, but this used to print this: coresight stm0: STM500 initialized And now it prints this: coresight stm0: (null) initialized (null) kind of makes it look a little bit like something has gone wrong. Maybe we could just put "initialised" if you don't have a string from ACPI? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel