From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25818C2BD09 for ; Thu, 27 Jun 2024 10:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jp3zHacmQoBcTyN4+dUpDe+hiyP9FkaBpQYiQTMcfUs=; b=xQuF9DX/pA8ZMTblwnrInjcfh1 6ieX1ax3wH54s9cr9NwZHxKJiLed0L26TMBYz4k5uuHNmeuKS/eIIBv9t0NUNRVVOawt3XKDXy6yV xtW0bR222UCLTlSszPXXzT2X/SVP1K7cu+PqTvELv6gEq1mc5Rjvl023ocw5ZCRQpZv223sxapx7B 61Vk5ZUl/JBLLLhfxu3P70qb4avIkiOmJ8eShpRpeW7GFmPGAi3M1h6XmXgcpytPasJ+PrqomWLq7 XswQK1Q/98Yi7T6366MJlqO1zE7DRwRQT9iDKwMM+yat2Z1+A2ZkBtrF2YAyX+/5M4DkPCl/mcvuf YtFgkFsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMlz4-00000009s4v-1Uhm; Thu, 27 Jun 2024 10:04:06 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMlyg-00000009s2g-1Cnz for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 10:03:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1719482619; bh=ZCTzlpwLsWbTLztEOQEh4XVwMCM6VQF1qZuE0NLxfhE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ggGaWUs/rmGhBU9s8SMuOMuju8gA2dG+j5aPFpDSYcSu08CDg56hKXiKOCrVB9JSK 0UmEMDDyiX/Y2exM7GBGdWg6tmTwOXUqf0tDmbKE9k07jWdvRkeDXnHOicH03ciiQs 0IP/dARslsQaMwJ8hwBDgEs6gcorsIAjHcyTJE1NyPiBvURc2dbwJKwipbExB7/8QL /jDRAEIzuuwPzeKlO2Rv+oP1z2h4ngyedmU/rO5+hEHomwPSMvZrf6uOG0C++yf5ov ZHm6o3Z2H5nhGqs3rEV9nj1sXkHxnd3iuA8YA7IxmAyfbHsS9SOOFe0/lsgk0c3jwu yvDulUL//grjA== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id E54963782181; Thu, 27 Jun 2024 10:03:38 +0000 (UTC) Message-ID: <0ae5ff1c-1abe-4b45-a1dd-4599a867f8c8@collabora.com> Date: Thu, 27 Jun 2024 12:03:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: clock: airoha: Add reset support to EN7581 clock binding To: Conor Dooley Cc: Lorenzo Bianconi , linux-clk@vger.kernel.org, p.zabel@pengutronix.de, mturquette@baylibre.com, sboyd@kernel.org, lorenzo.bianconi83@gmail.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, nbd@nbd.name, john@phrozen.org, dd@embedd.com, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com References: <20240627-vending-lisp-4e1cf45e552c@wendy> <20240627-undying-overcoat-192e5aa20c55@wendy> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240627-undying-overcoat-192e5aa20c55@wendy> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_030342_508382_D5B017C5 X-CRM114-Status: GOOD ( 20.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 27/06/24 11:57, Conor Dooley ha scritto: > On Thu, Jun 27, 2024 at 11:53:00AM +0200, AngeloGioacchino Del Regno wrote: >> Il 27/06/24 11:47, Conor Dooley ha scritto: >>> On Thu, Jun 27, 2024 at 11:33:47AM +0200, AngeloGioacchino Del Regno wrote: >>>> Il 13/06/24 14:47, Lorenzo Bianconi ha scritto: >>>>> Introduce reset capability to EN7581 device-tree clock binding >>>>> documentation. >>>>> >>>>> Signed-off-by: Lorenzo Bianconi >>>>> --- >>>>> .../bindings/clock/airoha,en7523-scu.yaml | 25 ++++++- >>>>> .../dt-bindings/reset/airoha,en7581-reset.h | 66 +++++++++++++++++++ >>>>> 2 files changed, 90 insertions(+), 1 deletion(-) >>>>> create mode 100644 include/dt-bindings/reset/airoha,en7581-reset.h >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>>>> index 3f4266637733..84353fd09428 100644 >>>>> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>>>> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml >>>>> @@ -35,7 +35,7 @@ properties: >>>>> reg: >>>>> minItems: 2 >>>>> - maxItems: 3 >>>>> + maxItems: 4 >>>>> "#clock-cells": >>>>> description: >>>>> @@ -43,6 +43,10 @@ properties: >>>>> clocks. >>>>> const: 1 >>>>> + '#reset-cells': >>>>> + description: ID of the controller reset line >>>>> + const: 1 >>>>> + >>>>> required: >>>>> - compatible >>>>> - reg >>>>> @@ -60,6 +64,8 @@ allOf: >>>>> - description: scu base address >>>>> - description: misc scu base address >>>>> + '#reset-cells': false >>>>> + >>>>> - if: >>>>> properties: >>>>> compatible: >>>>> @@ -70,6 +76,7 @@ allOf: >>>>> items: >>>>> - description: scu base address >>>>> - description: misc scu base address >>>>> + - description: reset base address >>>> >>>> Are you sure that the indentation is correct? :-) >>>> >>>> After fixing the indentation, >>>> >>>> Reviewed-by: AngeloGioacchino Del Regno >>>> >>>>> - description: pb scu base address >>> >>> The indentation actually looks okay when I apply this locally, but how is >>> it backwards compatible to add this register in the middle of the list?? >> >> It's not, and this is actually something done on purpose - there is no DT using >> this binding yet (here, nor uboot), and Lorenzo acknowledged the mistake before >> it was too late... >> >> At least this time, it wasn't a misattention :-P > > The rationale for this being okay really should be in the commit > message... > >> Btw, as far as I know, the reset base address is in between misc scu and pb scu, >> that's why it was put there in the middle. > > ...but I don't really see why this needs to be done incompatibly at all > in the first place. Just put it at the end of the list, there's no rule > that the order of reg properties needs to match the MMIO addresses. > It's just a perfection thing... but whatever, if that's unacceptable for you, putting it at the end of the list isn't a huge deal anyway. Your call - it's okay for me either way. Cheers, Angelo