From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49BE1C0015E for ; Wed, 19 Jul 2023 22:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UQ84ygRpKsbwbRFg8nH9jiw2pXSEi6RIzAoEho85LkQ=; b=x6259/+CLE46V0 ZjhBAmSDzr4iw/ZdA8bsL2Z4VFKEGinsFBaW9HeZBgP8Tbef0MUn0lUSQ/hmq13OSOLsVdjH/i8yD 7kle8gj8ZcvBqzmUwLpoOFvdgyPUHO1ygnlOskGO1PKgOrzxJiBCq6NERL3uJAcfZ89Z9tCqM8kgm Fc8YwsitEXZzbVSHclxNpCC/MWTP47b1fc6kqsH5Z0TUIM6hNo40nPyC8fGIaZWlA7xtoWnfHYWiv 3sVXZz6XJErWbHNNoKsWIXSHYp15CfBW+66OacbzxW4vhReN8aSl2yy4aigIgI/Qzs4vE6oqHkMzs AFYt1/XOkU5rWpUXUW+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMFPh-0094jx-34; Wed, 19 Jul 2023 22:12:53 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMFPe-0094jW-2A for linux-arm-kernel@lists.infradead.org; Wed, 19 Jul 2023 22:12:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2438F61841; Wed, 19 Jul 2023 22:12:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C274C433C7; Wed, 19 Jul 2023 22:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689804769; bh=y09nBU1a2RBKCYB7+lcvQJXNyrWzUKg/1LzTZgitiLg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=IyWwv7JCS4RatE9B7Y6kJd8NeTQSU5Y1o12Si3q7OnlQzyICZFSjyztsZLYdBpIE1 I179KnYsuNVjMSsTOsxyLu2v4EGvb5eq48EmA8y8XDIaJ4X7kXOKs+5wzb0bqspYRh g3u5OBV+dmfFvZCFbhud/71Akqan0kr0d4NgLuENVKkycw/q37YsIxxRwDBOEX26YT awdcqhesaWO9/XSZyD0CRponbTRgysEo+xmyl28NcS26RwBZyaAAC4Y/FyTFByQKKA hTqRIhRfozeG87BEXwetr7ku8XhYWla7mLnHYt3Y3cwUC6RocDUthIow/ft0heH740 g+SqMOf1BGKkQ== Message-ID: <0aeac8a80da719c2c3b7301668e0c59e.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <874jm3lzce.fsf@oltmanns.dev> References: <20230617131041.18313-1-frank@oltmanns.dev> <874jm3lzce.fsf@oltmanns.dev> Subject: Re: [PATCH v5 0/2] clk: fractional-divider: Improve approximation when zero based and export From: Stephen Boyd Cc: A.s. Dong , Abel Vesa , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Elaine Zhang To: Frank Oltmanns , Michael Turquette Date: Wed, 19 Jul 2023 15:12:47 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230719_151250_774874_F823A9CE X-CRM114-Status: GOOD ( 18.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Frank Oltmanns (2023-07-17 01:24:49) > Hi, > > On 2023-06-17 at 15:10:39 +0200, Frank Oltmanns wrote: > > The fractional divider approximation does not utilize the full available > > range for clocks that are flagged CLK_FRAC_DIVIDER_ZERO_BASED. This > > patchset aims to fix that. > > > > It also adds test cases for the edge cases of fractional divider clocks > > with and without the CLK_FRAC_DIVIDER_ZERO_BASED flag to highlight the > > changes. > > > > Finally, it also exports clk_fractional_divider_general_approximation so > > that the test cases (but also other users like rockchip clk driver) can > > be compiled as a module. > > > > Unfortunately, I have no boards to test this patch. So all we have are > > the unit tests. It seems the only user of this flag in mainline is > > drivers/clk/imx/clk-composite-7ulp.c, therefore I'm cc-ing > > get_maintainers.pl --git-blame -f drivers/clk/imx/clk-composite-7ulp.c > > in the hopes of a wider audience. > > Are there remarks or questions on this patchset? Anything that needs to > be improved? > I haven't taken a look yet. You sent this almost exactly when I started a weeks long trip with minimal network access. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel