From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29BBEC48291 for ; Mon, 5 Feb 2024 10:32:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RDi5pFZORvI6kpsvpJAzSy160R97w8eWexWVjPW0VUE=; b=ZvBIjCUm8w27fL Ez1s3GIl/9xK8vRMadWGYiuN/f+u5biGzVI0uRnuRFo8lVTWsO4RZ66M3CNSMgvhQQmSOpdTfv8iA Rp3S4XG3x999vIPu/JtGBBOUm2M/+6sAg4qiEDCGa2ZxA8/foitk19IxKt2NzHyM9NJ45yIjE9ygC FUgrwP4iy0yBJxDHXdfxsanjcJUyuwxunqTbwfnBW/rriCMbfe9/6C8fMtruW04L81I715FQFq/R6 xZwAcm7m6PP67LIyJm56D3e0vIBUwQW2oBc5gjndSgdNai5ycerXcmPFKSFWRodgMe6ZiM7Q82iJ9 /T9aVxsvo9W+oBiEgp9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWwGb-00000002oSZ-2WuY; Mon, 05 Feb 2024 10:31:57 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWwGY-00000002oQd-2HYs for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 10:31:56 +0000 Received: from epcas5p1.samsung.com (unknown [182.195.41.39]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20240205103142epoutp02e7c04610fdb3ae4867237f661824cced~w8N_ww5eZ1059210592epoutp02Q for ; Mon, 5 Feb 2024 10:31:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20240205103142epoutp02e7c04610fdb3ae4867237f661824cced~w8N_ww5eZ1059210592epoutp02Q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1707129102; bh=ThRoMmfiYoM24Fp+fJLEawYDXh7ivnt6G8khMvmeQkE=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=qfPdkHZZAGaBlcXYXEaWyds4jR58anlODDrN1TWTmeWbLEJMPaCkSQeEaM6eEic1I lNrEgkQo7jMqHNw9cO3mopzI5u91Y/xxywmKqDl7sX1R4X04Rxkyh+F+B+ZicrPBLO ckisJeiNEX7P66sbkAj/X1ovhLEAugj3gykKcMj0= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas5p2.samsung.com (KnoxPortal) with ESMTP id 20240205103141epcas5p2c3365024bcd0597248233122ead0a40a~w8N_RuH-R2557825578epcas5p2W; Mon, 5 Feb 2024 10:31:41 +0000 (GMT) Received: from epsmgec5p1-new.samsung.com (unknown [182.195.38.180]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4TT2jm0NHpz4x9Pr; Mon, 5 Feb 2024 10:31:40 +0000 (GMT) Received: from epcas5p2.samsung.com ( [182.195.41.40]) by epsmgec5p1-new.samsung.com (Symantec Messaging Gateway) with SMTP id 86.08.19369.B09B0C56; Mon, 5 Feb 2024 19:31:39 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas5p2.samsung.com (KnoxPortal) with ESMTPA id 20240205081157epcas5p21f5ba2b907d8b3875234886be6290bda~w6T95omHX0475404754epcas5p2_; Mon, 5 Feb 2024 08:11:57 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240205081157epsmtrp2628a371872ef3ef1c741990e70fbbcaf~w6T94xzex1746517465epsmtrp2w; Mon, 5 Feb 2024 08:11:57 +0000 (GMT) X-AuditID: b6c32a50-c99ff70000004ba9-d2-65c0b90b3b90 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id DA.C4.08817.D4890C56; Mon, 5 Feb 2024 17:11:57 +0900 (KST) Received: from FDSFTE048 (unknown [107.116.189.46]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240205081155epsmtip2260adc9144a0bf0f6939162c39d8c638~w6T8D59AY2177221772epsmtip2Q; Mon, 5 Feb 2024 08:11:55 +0000 (GMT) From: "Tamseel Shams" To: "'Krzysztof Kozlowski'" , , , , , , , Cc: , , , , In-Reply-To: Subject: RE: [PATCH 1/2] serial: samsung: honor fifosize from dts at first Date: Mon, 5 Feb 2024 13:41:54 +0530 Message-ID: <0b2201da580a$fcb94b10$f62be130$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Content-Language: en-in Thread-Index: AQKjNt2jyU8K8pSm5ip8/e5tj0DOhQL1DmltAaJhYTSvROveMA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMJsWRmVeSWpSXmKPExsWy7bCmhi73zgOpBps+W1s8mLeNzWLN3nNM FvOPnGO1aF68ns3i3VwZi74XD5kt9r7eym6x6fE1VouHr8ItLu+aw2Yx4/w+Joszi3vZLVr3 HmF34PXYtKqTzePOtT1sHvvnrmH32Lyk3qNvyypGj39Nc9k9Pm+SC2CPyrbJSE1MSS1SSM1L zk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMAbpVSaEsMacUKBSQWFyspG9n U5RfWpKqkJFfXGKrlFqQklNgUqBXnJhbXJqXrpeXWmJlaGBgZApUmJCdcfvuN7aCbsGKq5d6 WBoYZ/F1MXJwSAiYSHzfwNHFyMUhJLCHUWLj5ZMsEM4nRom5c7ugnG+MEut7epm6GDnBOnbf X8QGkdjLKPFh8w1WCOcFo8Th/RfZQarYBLQl3u06ywSSEBH4wygxq+8jO4jDLLCRUeL44V42 kCpOATuJ0z0HWUBsYQEviV0XtoJ1swioSJxd+oURxOYVsJToa7vIBGELSpyc+QSsnllAXmL7 2znMEDcpSPx8uowVIi4ucfRnD1hcRMBJYuf0D2CLJQTOcEi8OfmDDaLBReLJpHaoZmGJV8e3 sEPYUhKf3+2FqkmXmPsQ5ukCiWW7vkPV2EscuDKHBRR8zAKaEut36UOEZSWmnlrHBHEDn0Tv 7ydQrbwSO+bB2IoS/3f3Q40Rl3i3YgrrBEalWUhem4XktVlI3pmFsG0BI8sqRqnUguLc9NRk 0wJD3bzUcnicJ+fnbmIEp2atgB2Mqzf81TvEyMTBeIhRgoNZSYRXfN2BVCHelMTKqtSi/Pii 0pzU4kOMpsAAn8gsJZqcD8wOeSXxhiaWBiZmZmYmlsZmhkrivK9b56YICaQnlqRmp6YWpBbB 9DFxcEo1MK1cM8kv0nKH5pWQXI4pzFs2O3kntWd7eUwovhjBZcOzc9KO7Ik6Xy7+CNJt/sHU 6x1U9+7oj3XPJ1VPrBDUlaxpYmqLkhXSPsX6/skSEybTHP3I7a5B348l1HN4NO4rnRI5o+aU 2pVpRk7s11+9rrA2LeJWlv18xk5M+XHnpYVXhM+uKzrVuls3MKbuxkdTs0m7+KI4LeY7ZwpU PwrSy803elOnZ2J1dZf/okx2v1mzj35sMzddPtlKcet5TZ1vTv0Le9y1+Bbp8a3JbnhtMun7 FFutA6qqnLnrZ06rDkt52bYm6d49lzrWe+J+KnxFDXEZE2M0tA0bHnuERBltNeaxWdCYM5Pj f6t1pbcSS3FGoqEWc1FxIgB397sGVgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsWy7bCSvK7vjAOpBksfyFk8mLeNzWLN3nNM FvOPnGO1aF68ns3i3VwZi74XD5kt9r7eym6x6fE1VouHr8ItLu+aw2Yx4/w+Joszi3vZLVr3 HmF34PXYtKqTzePOtT1sHvvnrmH32Lyk3qNvyypGj39Nc9k9Pm+SC2CP4rJJSc3JLEst0rdL 4Mq4ffcbW0G3YMXVSz0sDYyz+LoYOTkkBEwkdt9fxNbFyMUhJLCbUWLz828sEAlxiWm/9jNC 2MISK/89Z4coesYose7PNVaQBJuAtsS7XWeZQBIiAi1MEk+PrQPrYBbYyihxc1sxRMceRonG jltMIAlOATuJ0z0HwVYIC3hJ7LqwlR3EZhFQkTi79AtYM6+ApURf20UmCFtQ4uTMJywQQ7Ul eh+2Qi2Ql9j+dg4zxHkKEj+fLmOFiItLHP3ZAxYXEXCS2Dn9A/sERuFZSEbNQjJqFpJRs5C0 L2BkWcUomVpQnJueW2xYYJSXWq5XnJhbXJqXrpecn7uJERydWlo7GPes+qB3iJGJg/EQowQH s5II7wThvalCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeb+97k0REkhPLEnNTk0tSC2CyTJxcEo1 MFnxTng8xXlZ441w02ObEyScDz1/cW6eUDq345k7ry7FqnwL5S5hEzM5sue9a/vk5BNtPj0T p6Q/Ms35PG0DS6isb79nW7m6QITnuuS5PnuSvswy/mi3yqTO5O3Mrx+FfaJEfh1/nR5yfKfv AwGfxtMFb/+avX6c1X+Y7/uv42wOdx8/UTobJrnt2f8sgb1Ba9SvcTW1ZsbX1y8WPaPVNyPI VXfCpHzz/ukXA2WivvAWyPdf9dtldKD1g2h7Vcxt7bmXbh57czG34rRl0IZip18+v8oum+58 /lSzSoFXS+Vbo5j1149p16X///ytEc100EasIbRnztxGxfMvYyQ3i3U+b3fYm6y6pUPI9k21 iRJLcUaioRZzUXEiAL3av2E9AwAA X-CMS-MailID: 20240205081157epcas5p21f5ba2b907d8b3875234886be6290bda X-Msg-Generator: CA X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20240202212456epcas5p15589813cd79526e9d0c444082e2f0e51 References: <20240202212448.74840-1-m.shams@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_023154_901493_0E6AACF5 X-CRM114-Status: GOOD ( 24.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] > Sent: 05 February 2024 13:10 > To: Tamseel Shams ; alim.akhtar@samsung.com; > linux-fsd@tesla.com; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > gregkh@linuxfoundation.org; jirislaby@kernel.org > Cc: linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-serial@vger.kernel.org > Subject: Re: [PATCH 1/2] serial: samsung: honor fifosize from dts at first > > On 02/02/2024 22:24, Tamseel Shams wrote: > > Currently for platforms which passes UART fifosize from DT gets > > override by local driver structure "s3c24xx_serial_drv_data", which is > > not indentded. Change the code to honor fifosize from device tree at > > first. > > > > Signed-off-by: Tamseel Shams > > --- > > drivers/tty/serial/samsung_tty.c | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/tty/serial/samsung_tty.c > > b/drivers/tty/serial/samsung_tty.c > > index 71d17d804fda..e4c4c9f4f9b0 100644 > > --- a/drivers/tty/serial/samsung_tty.c > > +++ b/drivers/tty/serial/samsung_tty.c > > @@ -1990,8 +1990,7 @@ static int s3c24xx_serial_probe(struct > platform_device *pdev) > > } > > > > if (np) { > > - of_property_read_u32(np, > > - "samsung,uart-fifosize", &ourport->port.fifosize); > > + ret = of_property_read_u32(np, "samsung,uart-fifosize", > > +&ourport->port.fifosize); > > > > if (of_property_read_u32(np, "reg-io-width", &prop) == 0) { > > switch (prop) { > > @@ -2009,10 +2008,13 @@ static int s3c24xx_serial_probe(struct > platform_device *pdev) > > } > > } > > > > - if (ourport->drv_data->fifosize[index]) > > - ourport->port.fifosize = ourport->drv_data->fifosize[index]; > > - else if (ourport->info->fifosize) > > - ourport->port.fifosize = ourport->info->fifosize; > > I think ret is not initialized here. > > Thanks for review. Will fix it in the version. Thanks & Regards Tamseel Shams _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel