From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70B11C433DF for ; Thu, 30 Jul 2020 07:21:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39E5D206E6 for ; Thu, 30 Jul 2020 07:21:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o/rj8u9e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39E5D206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EIKQlHSt8DCJGNlZZmKzcRYY/EBlL4r7gdxRIZuxwhU=; b=o/rj8u9e6i7vzN0dO0lXHBmpm 7xmRgJvEQWlIwcRBwfrEcLaGfEdhF/7TG3+E72uvY8hvbWL3U9vWCo4mN/LCte8VBKjDwjp9pxDyZ xTCHw33U6zGue4G45mIK8VFceQ90sEftydSFvAlY0IS4YljBtQ1TYuOnBaSZm1V0pLIWKcB/TuXcg Y7uR9bnKzTgCrAWNGSl+tdj50mXQ/ZtNF3GZw1c+OE0A3EGLXkTKJiOGukSrzAVNOACWfTX3Ofkhl N4iJ7guflp/mzeSkyEkIbKMFuYpirY7BdvjJTNmYai6SWJ1djDXeUYSbsrxWn2WRSBtBNCkhg6hj8 6HAoPw0ow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k12qw-0006WG-9q; Thu, 30 Jul 2020 07:19:46 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k12qt-0006Vj-JN for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 07:19:44 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k12qZ-0000ZT-AD; Thu, 30 Jul 2020 09:19:23 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1k12qW-0003Ph-MV; Thu, 30 Jul 2020 09:19:20 +0200 Message-ID: <0b541063e66e29b1dd0dad70f77a18a8591f224b.camel@pengutronix.de> Subject: Re: [PATCH V3 3/3] pci: imx: Select RESET_IMX7 by default From: Philipp Zabel To: Anson Huang , Rob Herring Date: Thu, 30 Jul 2020 09:19:20 +0200 In-Reply-To: References: <1595254921-26050-1-git-send-email-Anson.Huang@nxp.com> <1595254921-26050-3-git-send-email-Anson.Huang@nxp.com> <0cdecff564215de6711ca04e063fa696a160fad9.camel@pengutronix.de> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_031943_721511_C41B5742 X-CRM114-Status: GOOD ( 27.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kunihiko Hayashi , Catalin Marinas , Bjorn Andersson , Jonathan Chocron , Vidya Sagar , Fabio Estevam , Lorenzo Pieralisi , Geert Uytterhoeven , Dilip Kota , Will Deacon , Krzysztof Kozlowski , dl-linux-imx , PCI , Thierry Reding , Sascha Hauer , Bjorn Helgaas , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , Leo Li , Vinod , Sascha Hauer , Olof Johansson , Shawn Guo , Andrew Murray Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anson, On Thu, 2020-07-30 at 02:11 +0000, Anson Huang wrote: > Hi, Philipp/Rob > > > Subject: Re: [PATCH V3 3/3] pci: imx: Select RESET_IMX7 by default > > > > On Wed, 2020-07-29 at 09:26 -0600, Rob Herring wrote: > > > On Mon, Jul 20, 2020 at 8:26 AM Anson Huang > > wrote: > > > > i.MX7 reset driver now supports module build and it is no longer > > > > built in by default, so i.MX PCI driver needs to select it > > > > explicitly due to it is NOT supporting loadable module currently. > > > > > > > > Signed-off-by: Anson Huang > > > > --- > > > > No change. > > > > --- > > > > drivers/pci/controller/dwc/Kconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/pci/controller/dwc/Kconfig > > > > b/drivers/pci/controller/dwc/Kconfig > > > > index 044a376..bcf63ce 100644 > > > > --- a/drivers/pci/controller/dwc/Kconfig > > > > +++ b/drivers/pci/controller/dwc/Kconfig > > > > @@ -90,6 +90,7 @@ config PCI_EXYNOS > > > > > > > > config PCI_IMX6 > > > > bool "Freescale i.MX6/7/8 PCIe controller" > > > > + select RESET_IMX7 > > > > > > This will break as select will not cause all of RESET_IMX7's > > > dependencies to be met. It also doesn't scale. Are you going to do the > > > same thing for clocks, pinctrl, gpio, etc.? > > > > > > You should make the PCI driver work as a module. > > > > Oh, also PCI_IMX6 is used on (surprise) i.MX6, which doesn't need > > RESET_IMX7 at all. > > > > How about hiding the RESET_IMX7 option and setting it default y if > > PCI_IMX6 is enabled, as an interim solution? > > Like below, RESET_IMX7 is already default y when SOC_IMX7D, now added PCI_IMX6, > let me know if it is OK for you, then I will send new patch for review. > > +++ b/drivers/reset/Kconfig > @@ -68,7 +68,7 @@ config RESET_IMX7 > tristate "i.MX7/8 Reset Driver" I was thinking something like tristate "i.MX7/8 Reset Driver" if COMPILE_TEST || !PCI_IMX6 > depends on HAS_IOMEM > depends on SOC_IMX7D || (ARM64 && ARCH_MXC) || COMPILE_TEST > - default y if SOC_IMX7D > + default y if (SOC_IMX7D || PCI_IMX6) Yes, although without the above I think it could still be disabled manually or via oldconfig. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel