From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85ACEC4345F for ; Sat, 20 Apr 2024 22:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u3K8U29/HO69pnDyUxwrpbei39rwz2yZkx20ZfyW3k0=; b=AeHvwgN8uiJtVY SAoTp++tUZQBvcC18/mFNgUOxTSRFwumwtqrUB9yB55d1QETlFNE3BF7mmddE2LnRwmggvGUqr9Zg 3JhcRMULPjAJQahEVeTFAJxI5ASxto21FbGEmt9+/Vzj4Lz2oMmT9oZvqLNZi81dZQMFTSfFTGhmF TFl4SdOUJF6PX9uQf2MLh4GBhoCFwDTHv1WOpVTz6gxJ1aRy9cDM94Akh35pzbfgSF7wfV8LQD9iz LvH/EjonCQR6c8Oxmi6F8nIk1/owarH2dzViecP6krcFUFREbmaV4Ec8kM52dNiBNPdoLl/nW1MC/ hlgAe3F6i1zBscqHGFqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryJUL-00000009JBj-1BuR; Sat, 20 Apr 2024 22:47:17 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryJUI-00000009JAQ-2Fvr for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2024 22:47:16 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-349c4505058so2378597f8f.3 for ; Sat, 20 Apr 2024 15:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713653226; x=1714258026; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fHqxIncYJ8egtEQrph9tKgbaWj8ag9453EB89pr+LvE=; b=Az6s3fKvRJTOAN8sOIRG/bPt9U0pQMy2ZPqqLxVFoA5cphQrGyak1FhKxW1N9p9jub x00QgGXPtVM+F7Y0rt2p/UfFXPT+/2IQwAnQzuIuHO7N3r1zXJpFQ5ODQOa3l1ESmG6c MqJy2VIl0M/5wwUmmXzDjaJsmBzwFoG8C5W6AfqsyiTHWaSXAP8iN2H39jHpV82pzQ7a oUCdiY2GREssUtpzseslKScGgTi4gOfPkEwSrXBWZJH+9Ag9iHWMsEj2aJw91Vzl2RN7 RQfkP/ONqYDUKtwchTakZlsUxXKRfbcZozv7hgWe3hkzuArK0w2h0ChVOCt9FQ1T/ary OsSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713653226; x=1714258026; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fHqxIncYJ8egtEQrph9tKgbaWj8ag9453EB89pr+LvE=; b=QvMupZbTCr2Yzbtan5cwq1p5W9fnSnzgs8FOFQ/MdH9NfIwh9G20tWB6dAw3+7zidJ FF980KROcYoIoYmp7AXkYrAkydbOpM6QxmAAmcnl/dgSIf6R27K6UehnworEtEs6Wlvt wZTW4FtFvq2YL9DD0tMiC7P+9kh1NDa3BpJxJ//ELdkulr9vCkxdSnvSYa0VCd1FCM7B wPhhFT/O5JipUb0QXv+syJVu/BtnmIzTY0kDOfBDqUGGdzOWeriMg8szc0Rf7SeiSNVG 9qtjZ6RtfAZP4ZQExEXeZuOoYPktkBiMlSsXgmBtlzbazQO+6jx1MwmFSjaannqxr1ao rbqw== X-Forwarded-Encrypted: i=1; AJvYcCVshA5kU6zvI/wYdaZvnU6GJxY7EsLiC/SQgaXSPa8Zmai/qj2D6zV6y4Tjy8Uh6CmykeCygovzoIcJdQB+eKdIpMVtisLmfhjTqxyuTRb9sApkQ0g= X-Gm-Message-State: AOJu0Yxe6c7hZfv5W3C3KJ0kI+1F/HhHeud8fObqzE572yJBDZyJiyNu 81Yty07Wi35z4+fBrOC4MVbiwtK99U3oPdud16u4tRMmKqoqfWQvaQBp62O9Hlg= X-Google-Smtp-Source: AGHT+IGtPzW/+9lmMVQCxqN2UztagHO9wsOjvQj41cl+HJwvySkknf0HE8sKI3A2uzyMihcZkv08Sw== X-Received: by 2002:a05:6000:2c2:b0:346:758e:5f29 with SMTP id o2-20020a05600002c200b00346758e5f29mr4624994wry.60.1713653226127; Sat, 20 Apr 2024 15:47:06 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id fc14-20020a05600c524e00b004161af729f4sm11399884wmb.31.2024.04.20.15.47.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Apr 2024 15:47:05 -0700 (PDT) Message-ID: <0b5c6091-e47c-4d24-a13a-2b5ad1b9cfb8@linaro.org> Date: Sat, 20 Apr 2024 23:47:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 23/26] media: venus: vdec: Make explicit the range of us_per_frame To: Ricardo Ribalda , Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> <20240419-fix-cocci-v2-23-2119e692309c@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240419-fix-cocci-v2-23-2119e692309c@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_154714_647321_ACB78763 X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/04/2024 10:48, Ricardo Ribalda wrote: > Unless the fps is smaller than 0.000232829 fps, this fits in a 32 bit > number. Make that explicit. > > Found by cocci: > drivers/media/platform/qcom/venus/vdec.c:488:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead. > > Signed-off-by: Ricardo Ribalda > --- > drivers/media/platform/qcom/venus/vdec.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > index 29130a9441e7..2b2874aedb2d 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c > @@ -464,7 +464,7 @@ static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) > struct venus_inst *inst = to_inst(file); > struct v4l2_captureparm *cap = &a->parm.capture; > struct v4l2_fract *timeperframe = &cap->timeperframe; > - u64 us_per_frame, fps; > + u64 us_per_frame; > > if (a->type != V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE && > a->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) > @@ -484,10 +484,7 @@ static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) > if (!us_per_frame) > return -EINVAL; > > - fps = (u64)USEC_PER_SEC; > - do_div(fps, us_per_frame); > - > - inst->fps = fps; > + inst->fps = USEC_PER_SEC / (u32)us_per_frame; > inst->timeperframe = *timeperframe; > > return 0; > Reviewed-by: Bryan O'Donoghue _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel