From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CB70CD13CF for ; Tue, 3 Sep 2024 12:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+cdIRXo5VTqWR2KdDzO1DTS+Vt8PiHUf2RGCvnaGFsQ=; b=H83deM+cD80SPNQdWaBDDkgWfE Q94ukwhsnS9PEU34cpUHErPg2q7Taq39K4H0jmpwAdbMQ2hveSlk3LmEnAt0G3suH+lKHp7uUoPej fPqhoiN+B6Xkk0GBkJa3ItL7xJCr1lgJLDkHgbiINeBqaNCarBMe8fZNbbvzXO0BEMjL+pU99Jf51 /2km8Fj1kXOoQEL0A3bM1A0zKN6F4YEEvW+77KNC7FWC1rW7THfW9dw/75tgPT+8YUBLSeAfm+X+W GeIARErwxA2VkHLA3Vg9gkBd6P1zwuHSpGcOHgnnlxjLeZnDOw0EDgU3WdTyjSPdhn2BOTdY6XmD+ m4751gtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slScb-0000000096O-2CTi; Tue, 03 Sep 2024 12:26:57 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slSbf-000000008rm-3WDK for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2024 12:26:01 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5bef295a429so5512411a12.2 for ; Tue, 03 Sep 2024 05:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1725366358; x=1725971158; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+cdIRXo5VTqWR2KdDzO1DTS+Vt8PiHUf2RGCvnaGFsQ=; b=XYYdW/Iv9JYnDmO+QL4O1b4gXJkCQommz9pB+GLwYh9WK35fb2nS9tFnxDUCCiLpuw axsQb2Yhu/fDHy6yHLSLJxlniPd3oz/c+1IJWNf7dZh94iklbT9faB9nA2nw8iwYc8Rp bSChuAMKeWUKxscyHhudkNiiXJ74XijjIApAlsVMvVnStTkv5kodsl8T0QM+zogrk32a mnLFP9Ls55cUaARkTN6Ipa7xlEc/KU7+Sz2W3LuIZKpKe5Sw4HT2nkOsc0nsbAkvlXhI Y7vdDcULaWuw8cmNJmZOVZIfW1JFSs4+NYKN5XNhjYKyTQci2FwcuFA8ocsFb8Y2YCwK tHqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725366358; x=1725971158; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+cdIRXo5VTqWR2KdDzO1DTS+Vt8PiHUf2RGCvnaGFsQ=; b=bKAyjgAOM2GU0oFynLLY18v52GS8x1UrkCwrWtLqndkn1v9o50e643jB/AY2GJ1uBO GFLlg4GrWWvfeZW5K4zQxMTCdg5pS2QxFIu7IJLAngRw9erzMLfgJtvY3og0Fst32Gs2 MVqJ1KHJ7ZK/hCVoNa3DHetnUJq8J+TQa34rl73cibLD7EGCqlOUeP3bS5DR+LMEIUo8 CcOYsLpd10cZPMEMiQibB3cp2CW+cZFKwSPc7N94X5uMNLAltcW/GRZn+L55gS5wnCQd 7MK8+iyvgGTXd9VyAMABj2p+svRBaVtyFczuMYzPCQu9MIHXk+a0ObbLjW3liG309iPw tgjg== X-Forwarded-Encrypted: i=1; AJvYcCUDQZBvoKIWG6qnHrejuICugOX8fR+Jisfwi10hmLBfD3YysDRZqR/iLFP7CAwq1iFAhFT9APugmIIaiRaBF7ZC@lists.infradead.org X-Gm-Message-State: AOJu0YzK90gMrmyoWIdJb5p5mwxL/e6XjBJVQlz/ay8IhJuWgeMsbuAw LtLvysxjD5cgNmngKS+exEsgdEh9+vnmHzuNngteQ7UgcX2TRAk7Rv7QovucKOs= X-Google-Smtp-Source: AGHT+IGCJSAfsQxh53LJgcY+qGaZ+a7jTX6q5V6OFCLQvyiQ7yrxNllyp0cepO9Zz23djK5zaAK9PQ== X-Received: by 2002:a05:6402:4310:b0:5a2:2654:7fc4 with SMTP id 4fb4d7f45d1cf-5c25c3a717amr5389144a12.8.1725366357788; Tue, 03 Sep 2024 05:25:57 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.144]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c226c6a3cdsm6412278a12.12.2024.09.03.05.25.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2024 05:25:57 -0700 (PDT) Message-ID: <0b73544b-0253-43b9-b631-6578b48eaca8@tuxon.dev> Date: Tue, 3 Sep 2024 15:25:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/16] Add initial USB support for the Renesas RZ/G3S SoC Content-Language: en-US To: Biju Das , Ulf Hansson Cc: "vkoul@kernel.org" , "kishon@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , "geert+renesas@glider.be" , "magnus.damm@gmail.com" , "gregkh@linuxfoundation.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , Yoshihiro Shimoda , "linux-phy@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-pm@vger.kernel.org" , Claudiu Beznea References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <5556d176-cca7-492c-ba21-48256d5d6338@tuxon.dev> <590a4fb2-24b2-432b-92db-534c5a52ed0b@tuxon.dev> <35dc7414-f5bd-4ed4-bfa1-f723f4f0078c@tuxon.dev> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240903_052559_990491_3BFB4AB8 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03.09.2024 15:00, Biju Das wrote: > > >> -----Original Message----- >> From: Biju Das >> Sent: Tuesday, September 3, 2024 12:07 PM >> To: Claudiu.Beznea ; Ulf Hansson >> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; >> p.zabel@pengutronix.de; geert+renesas@glider.be; magnus.damm@gmail.com; gregkh@linuxfoundation.org; >> mturquette@baylibre.com; sboyd@kernel.org; Yoshihiro Shimoda ; >> linux-phy@lists.infradead.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >> renesas-soc@vger.kernel.org; linux-usb@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >> clk@vger.kernel.org; linux-pm@vger.kernel.org; Claudiu Beznea >> Subject: RE: [PATCH 00/16] Add initial USB support for the Renesas RZ/G3S SoC >> >> Hi Claudiu, >> >>> -----Original Message----- >>> From: claudiu beznea >>> Sent: Tuesday, September 3, 2024 12:00 PM >>> Subject: Re: [PATCH 00/16] Add initial USB support for the Renesas >>> RZ/G3S SoC >>> >>> >>> >>> On 03.09.2024 13:31, Biju Das wrote: >>>>>> During boot clr USB PWR READY signal in TF-A. >>>>>> STR case, suspend set USB PWR READY signal in TF-A. >>>>>> STR case, resume clr USB PWR READY signal in TF-A. >>>>> As I said previously, it can be done in different ways. My point >>>>> was to let Linux set what it needs for all it's devices to work. I >>>>> think the way to go forward is a >>> maintainer decision. >>>> >>>> I agree, there can be n number of solution for a problem. >>>> >>>> Since you modelled system state signal (USB PWRRDY) as reset control >>>> signal, it is reset/DT maintainer's decision to say the final word >>>> whether this signal fits in reset >>> system framework or not? >>> >>> I was thinking: >>> 1/ Geert would be the best to say if he considers it OK to handle this >>> in Linux >> >> I agree Geert is the right person for taking SYSTEM decisions, since the signal is used only during >> state transitions (Table 41.6.4 AWO to ALL_ON and 41.6.3 ALL_ON to AWO) > > One more info, as per [1], this USB PWRRDY signal setting to be before Linux kernel boots. The "controlled by" column mentions CA-55 on PWRRDY signal control line and it is b/w steps "DDR exits from retention mode" and "clock start settings for system bus and peripheral modules". AFAICT, after DDR exists retention mode Linux is ready to run. E.g. on resume Linux doesn't sets the clocks of all peripheral in sequence and then runs the rest of settings for each peripheral, in turn it sets the clock of one peripheral along with all the other necessary peripheral settings and then continues with the rest of peripherals (including their clocks). > > All clocks/reset happens after setting USB PWRRDY signal > > https://pasteboard.co/qbz021q7KPyi.png > > Cheers, > Biju