From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23497C48BDF for ; Thu, 24 Jun 2021 10:19:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E398E61248 for ; Thu, 24 Jun 2021 10:19:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E398E61248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zKdoKzSa9ii2A5rUAXIlpct1PBf4Z18a71hZk7mHZw4=; b=PHabYOwU8SLcZs4am+4b7P2dGZ xHQjjcNNtiUhL8Y6aiaAZkvfzml9hSbLbEwtCMF71zBwhVYKUdfwES0C+HwDfsZYj/M8WYW7hI6ET GnA1FHqqrwv78AU7rOSutMz56oEoPoQq+hEOnNSYDwV0Vys7uApu4KmhRXEdtF+MIrg/ZEbJXXXbf eZMFj/3I3h/19RPElFlJaKzPE+kt9zwggEBDRHOVwfCGaVR1qYN1LQS3cOFTqBRR6pGxi8NnOQh1J sZpvZWFE21jIyCA2p4ySdsJCixkFUL3cTzO4WxPIo7xOULdqx4kCStKDjOZmc9axp8o1oSEy19Bry h5avUSYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwMQe-00E1A9-Ly; Thu, 24 Jun 2021 10:17:50 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwMQV-00E17b-1o for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 10:17:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624529857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4frsi0H+HBjHeCdKISuXJMG773wuFNrwEMxUF4xqOQU=; b=H1QmQf0HjgfEEO/YXFb07R4kp428RjM92oYJv9BIIfU1pd6duojaDyI7drSXXC1f8H2Ywn AvXBDSZI/lrCj8j/ASh1qhpRLH3p3oHWD1DEynMOa3UyttSPWHJ+KipgM4k9oOjf43gYiE MaEh2Ii3o4SFW6mTXKeDD9DV8UVUfwc= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-Nnj9Zx6WNP2oKHX4ExwQXA-1; Thu, 24 Jun 2021 06:17:35 -0400 X-MC-Unique: Nnj9Zx6WNP2oKHX4ExwQXA-1 Received: by mail-ej1-f71.google.com with SMTP id q14-20020a1709066aceb029049fa6bee56fso1802978ejs.21 for ; Thu, 24 Jun 2021 03:17:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4frsi0H+HBjHeCdKISuXJMG773wuFNrwEMxUF4xqOQU=; b=oF7G6m9H6Dgfjn3itsCuALqkI2uJcXL0gNv3mRVwP2qdoVpm+8xFiB7N7s5ZtiNqy5 pGKwx8fQsd/IHQttsNsIpkkVSVs7K639QTyDPay9eN63eDAhVj7VM429Vu677xe3MHrA WGTk1A+8S26TfvwXGmDryehkn0GYqUZNoAbIpjtjga+vJv83pUIwySTSjDwZsSP5fs6P nirIACdVy/29RYkyUFTIzkW1qeryKW3KKGlBs9ZtloNBHEtZjXuDhNSuDbptHPvbke40 TEJPrsXBzZCLuCL8vuOzG3zg+qZJNK3yjmRoGNEegYFk7023OjlcOWv8UtqIqv+9l6IM F8zw== X-Gm-Message-State: AOAM5310EecbtkM63ENNlUYanLKx4LWOfOwcYNYQGFmkNOBx1bHHHN3q tbYIGzVhHxjAF67xHTG021jnJER1sEHduMesmfbqpH+yyEK5wIDZ0eNbdkXBTaKWXw1E9dssWyf zlw5kMaYIpSSB3pjIj5rMOPlhLDZv/Vh4ehQ= X-Received: by 2002:a17:906:b254:: with SMTP id ce20mr4621423ejb.480.1624529854691; Thu, 24 Jun 2021 03:17:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxC6TqcAfZORfwKXJXCm8bql8vynsp6j3JYon1fQgnkpoL4xlG5zu/uVtJRITtzGjbxU3KFw== X-Received: by 2002:a17:906:b254:: with SMTP id ce20mr4621398ejb.480.1624529854552; Thu, 24 Jun 2021 03:17:34 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x21sm1600772edv.97.2021.06.24.03.17.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 03:17:33 -0700 (PDT) Subject: Re: [PATCH 3/6] KVM: x86/mmu: avoid struct page in MMU To: Marc Zyngier , Nicholas Piggin Cc: Aleksandar Markovic , Huacai Chen , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang , Alexandru Elisei , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, James Morse , Jim Mattson , Joerg Roedel , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sean Christopherson , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Will Deacon References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-4-stevensd@google.com> <1624524744.2sr7o7ix86.astroid@bobo.none> <87mtrfinks.wl-maz@kernel.org> From: Paolo Bonzini Message-ID: <0b7f9c30-eb12-35c5-191f-0e8e469e1b88@redhat.com> Date: Thu, 24 Jun 2021 12:17:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87mtrfinks.wl-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_031739_264250_36173C87 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/06/21 12:06, Marc Zyngier wrote: > On Thu, 24 Jun 2021 09:58:00 +0100, > Nicholas Piggin wrote: >> >> Excerpts from David Stevens's message of June 24, 2021 1:57 pm: >>> From: David Stevens >>> out_unlock: >>> if (is_tdp_mmu_root(vcpu->kvm, vcpu->arch.mmu->root_hpa)) >>> read_unlock(&vcpu->kvm->mmu_lock); >>> else >>> write_unlock(&vcpu->kvm->mmu_lock); >>> - kvm_release_pfn_clean(pfn); >>> + if (pfnpg.page) >>> + put_page(pfnpg.page); >>> return r; >>> } >> >> How about >> >> kvm_release_pfn_page_clean(pfnpg); > > I'm not sure. I always found kvm_release_pfn_clean() ugly, because it > doesn't mark the page 'clean'. I find put_page() more correct. > > Something like 'kvm_put_pfn_page()' would make more sense, but I'm so > bad at naming things that I could just as well call it 'bob()'. The best way to go would be to get rid of kvm_release_pfn_clean() and always go through a pfn_page. Then we could or could not introduce wrappers kvm_put_pfn_page{,_dirty}. I think for now it's best to limit the churn since these patches will go in the stable releases too, and clean up the resulting API once we have a clear idea of how all architectures are using kvm_pfn_page. Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel