linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Faraz Ata <faraz.ata@samsung.com>,
	devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	krzk+dt@kernel.org, robh@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, alim.akhtar@samsung.com,
	rosa.pila@samsung.com
Subject: Re: [PATCH] arm64: dts: exynosautov920: add DMA nodes
Date: Mon, 9 Dec 2024 08:34:28 +0100	[thread overview]
Message-ID: <0bac139b-c89c-43a7-978a-e5fe001d3dd2@kernel.org> (raw)
In-Reply-To: <20241204122335.1578-1-faraz.ata@samsung.com>

On 04/12/2024 13:23, Faraz Ata wrote:
> +
> +		spdma1: dma-controller@10190000 {
> +			compatible = "arm,pl330", "arm,primecell";
> +			reg = <0x10190000 0x1000>;
> +			interrupts = <GIC_SPI 917 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cmu_misc CLK_MOUT_MISC_NOC_USER>;
> +			clock-names = "apb_pclk";
> +			#dma-cells = <1>;
> +		};
> +
> +		pdma0: dma-controller@101A0000 {

Please do not send downstream code directly, but fix it to match
upstream. Lowercase hex everywhere.

Best regards,
Krzysztof


  parent reply	other threads:[~2024-12-09  8:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20241204122402epcas5p2412733eb46d495fadfa30e5af3c5ce83@epcas5p2.samsung.com>
2024-12-04 12:23 ` [PATCH] arm64: dts: exynosautov920: add DMA nodes Faraz Ata
2024-12-08  2:07   ` Alim Akhtar
2024-12-09  7:34   ` Krzysztof Kozlowski [this message]
2024-12-10 11:53     ` Faraz Ata
2024-12-09  7:43   ` Tudor Ambarus
2024-12-10 11:59     ` Faraz Ata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bac139b-c89c-43a7-978a-e5fe001d3dd2@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=faraz.ata@samsung.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rosa.pila@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).