From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A907BC433EF for ; Tue, 14 Jun 2022 01:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PrrocDf8MKTUBJXzx8kt75fv5XoNaDa09DYZqZuSZBE=; b=1htW4gJuve+YoO 9fIlOafIdWPSwQczLGptL2JY1abARE3BNjMKpF6TPOpy7m45YP73308vhP2T+B1IMVAXggCunCuYp Y4jXLhgP5YYEj+zN7Cx17tcpLjj7CO46j1iHuHM+QIY7TiXaSvr7PRsbhOo5vHCugfrtYumklFXNm Bi2RhkE7+KRhU77QZFWF8flDLHe3Mw5ic1yBvPiaPN47F/b5qei738/ztHCr+7+UFUminh84JQr+2 5+7T5XvqlO8w+1i2C/aCCfqOpjpGE/sFzgv4mrSAXCocX8gAJ0AD1Z+K0uXnGQlFa9q2TsOWDM8et Jjd5OIrGrhtbU1jb2mWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0vbV-006blZ-Le; Tue, 14 Jun 2022 01:44:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0vbS-006bkz-FU for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 01:44:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2A93623A; Mon, 13 Jun 2022 18:44:21 -0700 (PDT) Received: from [10.162.40.17] (unknown [10.162.40.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B8D463F792; Mon, 13 Jun 2022 18:44:16 -0700 (PDT) Message-ID: <0bc0f99d-41ad-3ce3-deeb-c4c713100e74@arm.com> Date: Tue, 14 Jun 2022 07:14:14 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 7/8] arm64/perf: Add BRBE driver Content-Language: en-US To: German Gomez , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, peterz@infradead.org, acme@kernel.org, mark.rutland@arm.com, will@kernel.org Cc: Catalin Marinas , James Clark , Rob Herring , Marc Zyngier , Ingo Molnar , linux-perf-users@vger.kernel.org References: <20220613100119.684673-1-anshuman.khandual@arm.com> <20220613100119.684673-8-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_184422_612474_87F1314C X-CRM114-Status: GOOD ( 13.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/13/22 17:46, German Gomez wrote: > Hi Anshuman, thanks for the update, > > As I mentioned offline, I have a perf test that I've been using for the > branch records and filters. I'll let you know the result using this set. Sure, thanks ! > > On 13/06/2022 11:01, Anshuman Khandual wrote: >> [...] >> >> + >> +static int brbe_fetch_perf_priv(u64 brbinf) >> +{ >> + int brbe_el = brbe_fetch_el(brbinf); >> + >> + switch (brbe_el) { >> + case BRBINF_EL_EL0: >> + return PERF_BR_PRIV_USER; >> + case BRBINF_EL_EL1: >> + return PERF_BR_PRIV_KERNEL; >> + case BRBINF_EL_EL2: >> + if (is_kernel_in_hyp_mode()) >> + return PERF_BR_PRIV_KERNEL; >> + return PERF_BR_PRIV_HV; >> + default: >> + pr_warn("unknown branch privilege captured\n"); >> + return -1; > > This looks like it should return PERF_BR_PRIV_UNKNOWN. Right, return from this function gets into perf branch record's priv element and '-1' is not something that can be parsed correctly in the user space tools as the corresponding enum itself starts with 0 i.e PERF_BR_PRIV_UNKNOWN. cpuc->brbe_entries[idx].priv = brbe_fetch_perf_priv(brbinf) Will change the return as PERF_BR_PRIV_UNKNOWN instead. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel