From: kgene@kernel.org (kgene at kernel.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: s3c24xx: get rid of custom <mach/gpio.h>
Date: Fri, 13 Dec 2013 18:18:12 +0900 [thread overview]
Message-ID: <0bc201cef7e4$3f2cae20$bd860a60$@kernel.org> (raw)
In-Reply-To: <201312130857.23890.heiko@sntech.de>
Heiko St?bner wrote:
>
> Am Donnerstag, 12. Dezember 2013, 15:06:50 schrieb Linus Walleij:
> > This isolates the custom S3C24xx GPIO definition table to
> > <linux/platform_data/gpio-samsung-s3x24xx.h> as this is
> > used in a few different places in the kernel, removing the
> > need to depend on the implicit inclusion of <mach/gpio.h>
> > from <linux/gpio.h> and thus getting rid of a few nasty
> > cross-dependencies.
> >
> > We also delete the nifty CONFIG_S3C24XX_GPIO_EXTRA stuff.
> > The biggest this can ever be for the S3C24XX is
> > CONFIG_S3C24XX_GPIO_EXTRA = 128, and then for CPU_S3C2443 or
> > CPU_S3C2416 32*12 GPIOs are added, so 32*12+128 = 512
> > is the absolute roof value on this platform. So we set
> > the size of ARCH_NR_GPIO to this and the GPIOs array will
> > fit any S3C24XX platform, as per pattern from other archs.
> >
> > Cc: Heiko Stuebner <heiko@sntech.de>
> > Cc: Tomasz Figa <tomasz.figa@gmail.com>
> > Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> > Cc: Ben Dooks <ben-linux@fluff.org>
> > Cc: Kukjin Kim <kgene.kim@samsung.com>
For this whole series:
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> > Cc: linux-samsung-soc at vger.kernel.org
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > ChangeLog v1->v2:
> > - Added an #ifdef ARCH_S3C24XX around the header inclusion
> > in drivers/gpio/gpio-samsung.c as we would otherwise
> > have colliding definitions when compiling S3C64XX.
> > - Rename inclusion guard in the header file.
> >
> > If one of the maintainers give me an ACK for this I will
> > take it through the GPIO tree.
> > ---
>
> I'm not the maintainer of s3c24xx, but this looks nice ;-)
>
> Acked-by: Heiko Stuebner <heiko@sntech.de>
Linus, please take this series with my ack.
Thanks,
Kukjin
next prev parent reply other threads:[~2013-12-13 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 14:06 [PATCH 1/2] ARM: s3c24xx: get rid of custom <mach/gpio.h> Linus Walleij
2013-12-13 7:57 ` Heiko Stübner
2013-12-13 8:20 ` Linus Walleij
2013-12-13 8:58 ` Heiko Stübner
2013-12-13 9:18 ` kgene at kernel.org [this message]
2013-12-13 10:30 ` Tomasz Figa
2013-12-13 12:42 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0bc201cef7e4$3f2cae20$bd860a60$@kernel.org' \
--to=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).