From: Michal Simek <michal.simek@amd.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Michal Simek <michal.simek@xilinx.com>
Cc: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: xiic: Remove some dead code
Date: Thu, 16 Feb 2023 10:12:57 +0100 [thread overview]
Message-ID: <0bc626c8-492b-78ab-b054-0ae9f40cb967@amd.com> (raw)
In-Reply-To: <9d36938de98dc491425a51a9c07367dd9e448e60.1676457464.git.christophe.jaillet@wanadoo.fr>
On 2/15/23 11:38, Christophe JAILLET wrote:
>
> wait_for_completion_timeout() never returns negative value.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/i2c/busses/i2c-xiic.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index 8503b5016aaf..5543f372ae60 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1038,10 +1038,6 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
> i2c->rx_msg = NULL;
> i2c->nmsgs = 0;
> err = -ETIMEDOUT;
> - } else if (err < 0) { /* Completion error */
> - i2c->tx_msg = NULL;
> - i2c->rx_msg = NULL;
> - i2c->nmsgs = 0;
> } else {
> err = (i2c->state == STATE_DONE) ? num : -EIO;
> }
> --
> 2.34.1
>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-16 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 10:38 [PATCH] i2c: xiic: Remove some dead code Christophe JAILLET
2023-02-16 9:12 ` Michal Simek [this message]
2023-02-17 21:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc626c8-492b-78ab-b054-0ae9f40cb967@amd.com \
--to=michal.simek@amd.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox