* [PATCH] memory: stm32_omm: Fix req2ack update test
@ 2025-08-06 15:32 Patrice Chotard
2025-08-07 6:00 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Patrice Chotard @ 2025-08-06 15:32 UTC (permalink / raw)
To: Krzysztof Kozlowski, Maxime Coquelin, Alexandre Torgue,
Christophe Kerello
Cc: Krzysztof Kozlowski, linux-kernel, linux-stm32, linux-arm-kernel,
stable, Patrice Chotard
Fix test which allows to compute req2ack value.
Cc: stable@vger.kernel.org
Fixes: 8181d061dcff ("memory: Add STM32 Octo Memory Manager driver")
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
drivers/memory/stm32_omm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/stm32_omm.c b/drivers/memory/stm32_omm.c
index 79ceb1635698f6bc8bd4a39fdeaced1ec318e1f6..9efc56a85b5ecca49eb6dfc0ef83880f89591cd1 100644
--- a/drivers/memory/stm32_omm.c
+++ b/drivers/memory/stm32_omm.c
@@ -247,7 +247,7 @@ static int stm32_omm_configure(struct device *dev)
if (mux & CR_MUXEN) {
ret = of_property_read_u32(dev->of_node, "st,omm-req2ack-ns",
&req2ack);
- if (!ret && !req2ack) {
+ if (!ret && req2ack) {
req2ack = DIV_ROUND_UP(req2ack, NSEC_PER_SEC / clk_rate_max) - 1;
if (req2ack > 256)
---
base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
change-id: 20250806-upstream_omm_fix_req2ack_test_condition-77e8fb0d13d8
Best regards,
--
Patrice Chotard <patrice.chotard@foss.st.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memory: stm32_omm: Fix req2ack update test
2025-08-06 15:32 [PATCH] memory: stm32_omm: Fix req2ack update test Patrice Chotard
@ 2025-08-07 6:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-07 6:00 UTC (permalink / raw)
To: Patrice Chotard, Maxime Coquelin, Alexandre Torgue,
Christophe Kerello
Cc: Krzysztof Kozlowski, linux-kernel, linux-stm32, linux-arm-kernel,
stable
On 06/08/2025 17:32, Patrice Chotard wrote:
> Fix test which allows to compute req2ack value.
What is the bug, how does it affect users? Please read stable kernel
rules and submitting patches.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-07 6:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-06 15:32 [PATCH] memory: stm32_omm: Fix req2ack update test Patrice Chotard
2025-08-07 6:00 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).