From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A0B4C433FE for ; Wed, 9 Nov 2022 08:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=alHgu1Nse05c2LITgi9w5tYfvQhknpjv0JO1i/7Z8mg=; b=irCcHQ4YWSQm5/ BV81+MSQD3b+O+6MwX4tA0jNZeUS2jJsUlzhMEK830iA0phhRB0np0F2WwwyWMddD1xw61zpCYdKQ 8g2o8n27vF2JvKob3dYbiqCoqH3CrnlGUb/TEkgXiAJe8HW09iMnAJ6erQnTuXPZ4JImexMmO10MJ NQan9l8Hdid8mxJS/LxOWz5sQu+5uXKhTKLB9hJkcPiGTBTyrS82uOwgd20bMO1Cbb2upBA3ROVLB Ze34YmIflr7Nkmr/NQuOIvSdTG6NinWC8jQJaTPU0ZVaTUOOvokkbMDGW7n4gIOx4jGtUEFGOjhaM qVBPsxL7j5G+ozfiflNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osglw-00C0hB-Dw; Wed, 09 Nov 2022 08:49:24 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osglt-00C0fC-7u for linux-arm-kernel@lists.infradead.org; Wed, 09 Nov 2022 08:49:22 +0000 Received: by mail-lj1-x22c.google.com with SMTP id t10so24788077ljj.0 for ; Wed, 09 Nov 2022 00:49:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7vBkkfZQWcT2BPYsBX069quROkBYsnlhEC9tn5FlJtY=; b=ozMeYcbthVydFqMEaUf3m/kOWrFanjiFpobFaL089YHMZlW2jxw4BLT9lWYY3y1Bqs Sl9ZCkgKygyOnYUxVIeUanR05mhyScLLevs48wNpCdDUfnfyhg72PRuD+pwavp73dSYe QdocdUAfHPUFAgDjebTvxlVkr1zXRSJOUc1iv2F3XeZNcySNZr+PD5kuzrkNXcUr6OUT nvFeYjYmMZUOY91cXf5YlAUYnN01MYBiQvr+twguS1/19xhBK1ecZuBDf1w95Jk8Slw8 LCPsKgfJdnUjSRXIcuXv000fCd2FuOjOFaetftqSrJZTNNdRNVulqWGYt3kNDwmqIrjZ TVZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7vBkkfZQWcT2BPYsBX069quROkBYsnlhEC9tn5FlJtY=; b=GK4rF14KUpLPQNqRL7+UulIcDbD5xSaHXtPwd6SF5OQoGUxJJ2k83kswfgCq5m17iH 7aWbr7qJu4vf+E06V0ag/XRbMJbDpfATvstRBpVugynNWk8NIMkPoR+sC9DLfXdImo4/ Uywz+91vJbD7UJRQ6fCSABwv2f9zPv6EDyli2SOUTe8tzVdtnZ99VQEQ+8a00phgC7Rn LhDxsrdlnF01f2ntfx5PnDpbDwybjSvhLoq4+k3PtsBa0Ykd0vs/H/TosI9OZ27wN70/ QjpEGz90MSphNETmz5n6VIQG1UrrLW+QR2uDeOncQA36Zsv4DcPT2EmbZ3/CKLov8+PQ N6Kw== X-Gm-Message-State: ACrzQf2huYkRmqaMPGbkJkMZlx3LVnqqstywyskafiJvDw1QTqUQpRIi mvns4e0kCJkbw4vQmjUk2+s6tw== X-Google-Smtp-Source: AMsMyM4QTrn7WKvNp/FF7kJKkIOQR2e9NmHjjrrZaLB2cpuG6r0mVHyT23yAuPI4kNeJb/4SbsAOxw== X-Received: by 2002:a05:651c:12c2:b0:26c:13b9:a694 with SMTP id 2-20020a05651c12c200b0026c13b9a694mr21557955lje.79.1667983759758; Wed, 09 Nov 2022 00:49:19 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id k4-20020ac257c4000000b004b1793520a0sm2129255lfo.36.2022.11.09.00.49.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 00:49:19 -0800 (PST) Message-ID: <0bf46e8b-334d-7a50-ff6f-ef336d6d1a51@linaro.org> Date: Wed, 9 Nov 2022 09:49:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 3/7] rtc: rtc-tps6594x: Add support for TPS6594X PMIC RTC Content-Language: en-US To: Matt Ranostay , brgl@bgdev.pl, lee@kernel.org, linus.walleij@linaro.org, kristo@kernel.org, alexandre.belloni@bootlin.com, a.zummo@towertech.it, krzysztof.kozlowski+dt@linaro.org, robh@kernel.org, vigneshr@ti.com Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-gpio@vger.kernel.org, Keerthy References: <20221109065546.24912-1-mranostay@ti.com> <20221109065546.24912-4-mranostay@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20221109065546.24912-4-mranostay@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221109_004921_319618_471B91CB X-CRM114-Status: GOOD ( 23.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/11/2022 07:55, Matt Ranostay wrote: > From: Keerthy > > Add support for TPS6594X PMIC RTC. However, currently only get/set of > time + date functionality is supported. > > Signed-off-by: Keerthy > Signed-off-by: Matt Ranostay > --- > drivers/rtc/Kconfig | 10 ++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-tps6594x.c | 181 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 192 insertions(+) > create mode 100644 drivers/rtc/rtc-tps6594x.c > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index 35298c651730..0adb2c2570b8 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -588,6 +588,16 @@ config RTC_DRV_TPS65910 > This driver can also be built as a module. If so, the module > will be called rtc-tps65910. > > +config RTC_DRV_TPS6594X > + tristate "TI TPS6594X RTC driver" > + depends on MFD_TPS6594X Perhaps: || COMPILE_TEST (and test it) > + help > + If you say yes here you get support for the RTC of TI TPS6594X series PMIC > + chips. > + > + This driver can also be built as a module. If so, the module > + will be called rtc-tps6594x. > + (...) > + > +static int tps6594x_rtc_probe(struct platform_device *pdev) > +{ > + struct tps6594x *tps6594x = dev_get_drvdata(pdev->dev.parent); > + struct tps6594x_rtc *tps6594x_rtc = NULL; > + int ret; > + > + tps6594x_rtc = devm_kzalloc(&pdev->dev, sizeof(struct tps6594x_rtc), GFP_KERNEL); That's not Linux coding style. Line is too long - wrapping is at 80. sizeof(*), not struct. > + if (!tps6594x_rtc) > + return -ENOMEM; > + > + tps6594x_rtc->dev = &pdev->dev; > + platform_set_drvdata(pdev, tps6594x_rtc); > + > + /* Start RTC */ > + ret = regmap_update_bits(tps6594x->regmap, TPS6594X_RTC_CTRL_1, > + TPS6594X_RTC_CTRL_REG_STOP_RTC, > + TPS6594X_RTC_CTRL_REG_STOP_RTC); > + if (ret < 0) { > + dev_err(&pdev->dev, "RTC_CTRL write failed, err = %d\n", ret); > + return ret; > + } > + > + tps6594x_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, > + &tps6594x_rtc_ops, THIS_MODULE); > + if (IS_ERR(tps6594x_rtc->rtc)) { > + ret = PTR_ERR(tps6594x_rtc->rtc); > + dev_err(&pdev->dev, "RTC register failed, err = %d\n", ret); > + return ret; return dev_err_probe Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel