From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82FBBC433E2 for ; Fri, 10 Jul 2020 12:58:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D94120720 for ; Fri, 10 Jul 2020 12:58:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HheSdCju" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D94120720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L6iEmFFlDa+i/c7a5IicGH4rCtJh2BeoWXm1o/C/e+c=; b=HheSdCjuy+N7gTwr6qexgKg9z 5B2l9AWG8LEdIoDrOEx0fhIVaOTe5VELsUtBfGWnPZzPgcJD1cw019xJ8UkNrUG0bFJfm0lCm12y9 jWy81tUptPaW/CFnrmpLv+YaEYJ6KnGPdzzY73kheUqOY5t/oqJNHLteDdqIVsU6zR2iIj6A8jEMI wmxQqRicXcR/OPheJBwyCgFXYmg989wgBDyjsMlXd/aDLsu/wQdPtRzeWPfdr/lP+JbBdk+CrWIJh suakvBQsLNF0v96LszWVeeQBLICzD6D97xxB/K9NzkU68pRSaYfadypsfCcp5X0TfYd6rXrEtfz0A t7Hjhn/uw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtsa7-00077O-1D; Fri, 10 Jul 2020 12:56:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtsa3-00075L-Ef for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 12:56:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A0381FB; Fri, 10 Jul 2020 05:56:38 -0700 (PDT) Received: from [10.37.12.58] (unknown [10.37.12.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4FC3C3F8C6; Fri, 10 Jul 2020 05:56:35 -0700 (PDT) Subject: Re: [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold To: Krzysztof Kozlowski References: <20200708153420.29484-1-lukasz.luba@arm.com> <20200708153420.29484-2-lukasz.luba@arm.com> <20200710124503.GB22897@pi3> From: Lukasz Luba Message-ID: <0bfb4332-9a2e-9ff9-1a86-d9875a8f34bb@arm.com> Date: Fri, 10 Jul 2020 13:56:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200710124503.GB22897@pi3> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_085643_617100_FDBBFA35 X-CRM114-Status: GOOD ( 24.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, s.nawrocki@samsung.com, linux-pm@vger.kernel.org, k.konieczny@samsung.com, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, Chanwoo Choi , kyungmin.park@samsung.com, willy.mh.wolff.ml@gmail.com, myungjoo.ham@samsung.com, chanwoo@kernel.org, kgene@kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/10/20 1:45 PM, Krzysztof Kozlowski wrote: > On Fri, Jul 10, 2020 at 09:34:45AM +0100, Lukasz Luba wrote: >> Hi Chanwoo, >> >> On 7/9/20 5:08 AM, Chanwoo Choi wrote: >>> Hi Lukasz, >>> >>> On 7/9/20 12:34 AM, Lukasz Luba wrote: >>>> In order to react faster and make better decisions under some workloads, >>>> benchmarking the memory subsystem behavior, adjust the polling interval >>>> and upthreshold value used by the simple_ondemand governor. >>>> >>>> Reported-by: Willy Wolff >>>> Signed-off-by: Lukasz Luba >>>> --- >>>> drivers/memory/samsung/exynos5422-dmc.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c >>>> index 93e9c2429c0d..e03ee35f0ab5 100644 >>>> --- a/drivers/memory/samsung/exynos5422-dmc.c >>>> +++ b/drivers/memory/samsung/exynos5422-dmc.c >>>> @@ -1466,10 +1466,10 @@ static int exynos5_dmc_probe(struct platform_device *pdev) >>>> * Setup default thresholds for the devfreq governor. >>>> * The values are chosen based on experiments. >>>> */ >>>> - dmc->gov_data.upthreshold = 30; >>>> + dmc->gov_data.upthreshold = 10; >>>> dmc->gov_data.downdifferential = 5; >>>> - exynos5_dmc_df_profile.polling_ms = 500; >>>> + exynos5_dmc_df_profile.polling_ms = 100; >>>> } >>>> >>> >>> Reviewed-by: Chanwoo Choi >>> >> >> Thank you for the review. Do you think this patch could go through >> your tree together with your patches? >> >> I don't know Krzysztof's opinion about the patch 2/2, but >> I would expect, assuming the patch itself is correct, he would >> like to take it into his next/dt branch. > > In the cover letter you mentioned that this is a follow up for the > Chanwoo's patchset. But are these patches really depending on it? Can > they be picked up independently? They are not heavily dependent on Chanwoo's patches. Yes, they can be picked up independently. I just wanted to mention that the patch 1/2 was produced on the code base which had already applied Chanwoo's patch for DMC. If you like to take both 1/2 and 2/2 into your tree, it's good. Thank you for having a look on this. Regards, Lukasz > > The DTS patch must go through arm soc, so I will take it. If it really > depends on driver changes, then it has to wait for next release. > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel