From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1368C43334 for ; Thu, 16 Jun 2022 02:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D77kOQDVrNOgfKxHIHnhvNA+FKfcph9jM6M6YlzM0g8=; b=BthrSqbU6i2df7b934x1+gNNPU 7Kgwf6cY/PpSp1Fw+XXtis2YGGeVcW2dkkEzUZh7rhfA9bS+PyOEvaG1jxf8NgTECjeEs20j/kKDS 6jb4D18ATQspEjgILSAe1O9crnFdPjOTcSL0VuDmF0GwwSAo0JUJ72gEOPw0wYxei+Nhqc8FjjsPn hUDAwdxLfgj6TB9LBL+D4EVbvrt9iHvY/TA1OU8R8A7eLxvM66L7X4y3KXVzqTY+1eJHJUYU1stBj aHoua1uRVOORAIGvBNVwpGqoXeTKnk3+1TDBLry90uY8uDLmJfD3xbaA1ONBFHq/ijZzx5Qd+LMVK rg8BPRjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1exT-00Haz0-L1; Thu, 16 Jun 2022 02:10:07 +0000 Received: from mga06b.intel.com ([134.134.136.31] helo=mga06.intel.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1exP-00HaxN-Pd; Thu, 16 Jun 2022 02:10:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655345403; x=1686881403; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=u/polTrCcfTR/bnfvj7XjWWQORpzgrJJNnRIhd6+LYo=; b=CWL4Tv3lJxN6IJhTfEFP/sNgYNAoUUTkhmQ/h13Jbo3eXE+WOH5CdPsa eCanR1HL4jeAKNMF6TYWcDJwgYbQU6S11JPfEnp5n6zMgdMV/gtrt/G4S +z0cVl2eXZuQ3tbpmo1cQ9HPLj5vvZOWrZodF+lwh2EcCy2BXpfJ/i2W7 wqa4nq/fFLiL+W6psHq6V9gYBvimbEQvaXID8B4USqPiLUJ7QkeohVgn3 0Sbi3cEZJB0eVnDiWh100Nxr8q4aIYpqG0eWQJNRh94nzfT3cJ6Vhcb9S oeBDTtzzairwkSEWEnyEOyQ6z7Gf2BO+064yQKREOVQPreogQ1cNWoZ/j g==; X-IronPort-AV: E=McAfee;i="6400,9594,10379"; a="340800672" X-IronPort-AV: E=Sophos;i="5.91,302,1647327600"; d="scan'208";a="340800672" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2022 19:09:59 -0700 X-IronPort-AV: E=Sophos;i="5.91,302,1647327600"; d="scan'208";a="831355596" Received: from yuefengs-mobl.ccr.corp.intel.com (HELO [10.255.30.105]) ([10.255.30.105]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2022 19:09:51 -0700 Message-ID: <0c0e6ec8-725d-93e8-44f1-db6c8a673a97@linux.intel.com> Date: Thu, 16 Jun 2022 10:09:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Content-Language: en-US To: Nicolin Chen , joro@8bytes.org, will@kernel.org, marcan@marcan.st, sven@svenpeter.dev, robin.murphy@arm.com, robdclark@gmail.com, matthias.bgg@gmail.com, orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, jean-philippe@linaro.org, alex.williamson@redhat.com, jgg@nvidia.com, kevin.tian@intel.com References: <20220616000304.23890-1-nicolinc@nvidia.com> <20220616000304.23890-2-nicolinc@nvidia.com> From: Baolu Lu In-Reply-To: <20220616000304.23890-2-nicolinc@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_191003_964844_8BD6662E X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mjrosato@linux.ibm.com, jordan@cosmicpenguin.net, thierry.reding@gmail.com, alyssa@rosenzweig.io, linux-s390@vger.kernel.org, saiprakash.ranjan@codeaurora.org, kvm@vger.kernel.org, jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, yangyingliang@huawei.com, gerald.schaefer@linux.ibm.com, linux-arm-msm@vger.kernel.org, john.garry@huawei.com, christophe.jaillet@wanadoo.fr, thunder.leizhen@huawei.com, linux-tegra@vger.kernel.org, tglx@linutronix.de, virtualization@lists.linux-foundation.org, yong.wu@mediatek.com, isaacm@codeaurora.org, chenxiang66@hisilicon.com, cohuck@redhat.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, suravee.suthikulpanit@amd.com, linux-mediatek@lists.infradead.org, dwmw2@infradead.org, baolu.lu@linux.intel.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/6/16 08:03, Nicolin Chen wrote: > diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c > index 44016594831d..0dd13330fe12 100644 > --- a/drivers/iommu/intel/iommu.c > +++ b/drivers/iommu/intel/iommu.c > @@ -4323,7 +4323,7 @@ static int prepare_domain_attach_device(struct iommu_domain *domain, > return -ENODEV; > > if (dmar_domain->force_snooping && !ecap_sc_support(iommu->ecap)) > - return -EOPNOTSUPP; > + return -EMEDIUMTYPE; > > /* check if this iommu agaw is sufficient for max mapped address */ > addr_width = agaw_to_width(iommu->agaw); > @@ -4331,10 +4331,10 @@ static int prepare_domain_attach_device(struct iommu_domain *domain, > addr_width = cap_mgaw(iommu->cap); > > if (dmar_domain->max_addr > (1LL << addr_width)) { > - dev_err(dev, "%s: iommu width (%d) is not " > + dev_dbg(dev, "%s: iommu width (%d) is not " > "sufficient for the mapped address (%llx)\n", > __func__, addr_width, dmar_domain->max_addr); > - return -EFAULT; > + return -EMEDIUMTYPE; > } > dmar_domain->gaw = addr_width; Can we simply remove the dev_err()? As the return value has explicitly explained the failure reason, putting a print statement won't help much. Best regards, baolu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel