From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A7CCC38142 for ; Mon, 23 Jan 2023 08:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jZlW5QRyjg2MJ064J9nInG5TgNb6kMDkGCoR1B28WAs=; b=3dbqSyzINGdxkw xFxudgmG+VJi1ZpMDdmXUHDta9WG1Rzc6ag5qt98g99gkGfOrWHBZUnaz+Hq5IajA1DlskNaqWTeF E0ATdY3LYmMvz509CQhfIXWSjH5XQAB9B5enzMe1gk//UZ7rqzBzo966bxtxSKoMf5Gbvpg1jNVu0 dxjFSpDxNKb0jbgnTIKH8St2+sybRxrTi3y/cp5ZdWT8MUdd78I1dok5770KJX0iXoAiRL1upgUCg u3DFd0lRM845qG8X5C/YgMA7lBRlxQgbSA1YYgi22ksEOSd3n7si54Wov1oXK8a6MzyDhpSjIga56 gPqmFN5nYdnoz6PEZ5sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJrvB-00GJAk-35; Mon, 23 Jan 2023 08:11:17 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJrv8-00GJ9W-6I for linux-arm-kernel@lists.infradead.org; Mon, 23 Jan 2023 08:11:15 +0000 Received: by mail-wm1-x329.google.com with SMTP id k16so8308425wms.2 for ; Mon, 23 Jan 2023 00:11:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e7s9saYfKQc1Lv+pPmApBZHnSW8je2cMqPGzEWMmsU8=; b=U36nOcrJP5Lav7NaP7ggUfWX03/gtcJ4qyVtPgbUHc7ogn/HdK9JGEZqNKSN1R2S0B LHPIGKa+ZpahcQj0V8tqixMwn2w7byk5pMvpFvVu8qFw2IJX3Ttnl4YKEVc3ErWmLJ8o TJxNhTl7BMXqz8ugDh+FCqKItYZuU2B0o1yaa1uk2vxZ3JQRT7E/EP/KbMU2GKrAQMFm HRw/IGL9HeYf/aNOeKYV9maeVq+BO9UkqDIC6oPoFJr+5dPk8gg48LgQWlNzN2iVwzF7 asjU1SR+IFhVawGBPm1/kzh+DICQba71vpE5y12HDDmklyZr5HChWhtEmWB5nTxP8idp iuWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e7s9saYfKQc1Lv+pPmApBZHnSW8je2cMqPGzEWMmsU8=; b=gQTQl3/Bofr0wXYKwQwS7ST5cTHnWBmR9NxPbBl8XtF+pkiByfh1/9ETEhqYFx7w5n bakOqXZ7za5oL5BtcceG8RAd8ZTZhp9ooSsFxEzl1PVsA6pNPHpylVHqx1dyOFWOREq8 widq80NHGGdJ8dJd737PlBKJWX+2ZmdA0iwtX+O6vSLwgY/gFWu7sFRGPziNa/JzuUF6 PD33c0MdgWw9xbt8uoTexX3FKjpjCqqE0ICEmkf8S0G97XVmOihPnlhXcoel3sNg2WGP cAseXwQZWthQI3HyT5GBvRJpWg5jiprlvSTLPI4DOzlzMLJdYbQgvfq16Y3Uo3EyTcvt Pozw== X-Gm-Message-State: AFqh2kqb9bh/LxpO8ws2CL4nqHj6RBgoXULaup+X1QTk4b4NsIekDOi3 s1AX2nrvAGU8igjzNIKfCqcVSw== X-Google-Smtp-Source: AMrXdXsrI6xUDZcUDl7hloTWyhkrOc4Xd9fNlHdIaE1cAD7LpvXhPrVzG5UikQ15bShCvE55WGPofQ== X-Received: by 2002:a05:600c:1da6:b0:3da:107e:a1e6 with SMTP id p38-20020a05600c1da600b003da107ea1e6mr23059216wms.17.1674461471409; Mon, 23 Jan 2023 00:11:11 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id t15-20020a05600c198f00b003db32ccf4bfsm9969922wmq.41.2023.01.23.00.11.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 00:11:10 -0800 (PST) Message-ID: <0c19efb4-3bca-f500-ca24-14b9d24369ef@linaro.org> Date: Mon, 23 Jan 2023 09:11:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 07/15] dt-bindings: clock: Add Ambarella clock bindings Content-Language: en-US To: Li Chen , Li Chen , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski Cc: "moderated list:ARM/Ambarella SoC support" , "open list:COMMON CLK FRAMEWORK" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-8-lchen@ambarella.com> From: Krzysztof Kozlowski In-Reply-To: <20230123073305.149940-8-lchen@ambarella.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_001114_285980_CE573E33 X-CRM114-Status: GOOD ( 18.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/01/2023 08:32, Li Chen wrote: > This patch introduce clock bindings for Ambarella. > > Signed-off-by: Li Chen > Change-Id: I29018a23ed3a5b79a1103e859a5c7ed7bb83a261 All the same problems plus new: Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > --- > .../clock/ambarella,composite-clock.yaml | 52 ++++++++++++++++ > .../bindings/clock/ambarella,pll-clock.yaml | 59 +++++++++++++++++++ > MAINTAINERS | 2 + > 3 files changed, 113 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/ambarella,composite-clock.yaml > create mode 100644 Documentation/devicetree/bindings/clock/ambarella,pll-clock.yaml > > diff --git a/Documentation/devicetree/bindings/clock/ambarella,composite-clock.yaml b/Documentation/devicetree/bindings/clock/ambarella,composite-clock.yaml > new file mode 100644 > index 000000000000..fac1cb9379c4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/ambarella,composite-clock.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/ambarella,composite-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ambarella Composite Clock > + > +maintainers: > + - Li Chen > + Missing description. > +properties: > + compatible: > + items: Drop items. > + - const: ambarella,composite-clock Missing SoC specific compatible. This is anyway not really correct compatible... > + > + clocks: true No, needs constraints. > + assigned-clocks: true > + assigned-clock-parents: true > + assigned-clock-rates: true Drop these three. > + clock-output-names: true Missing constraints. > + amb,mux-regmap: true NAK. It's enough. The patches have very, very poor quality. Missing description, missing type/$ref, wrong prefix. > + amb,div-regmap: true > + amb,div-width: true > + amb,div-shift: true These two are arguments to phandle. > + > + '#clock-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - '#clock-cells' > + > +additionalProperties: false So why you decided to add it here and not in other places? > + > +examples: > + - | > + gclk_uart0: gclk-uart0 { Wrong indentation. > + #clock-cells = <0>; > + compatible = "ambarella,composite-clock"; > + clocks = <&osc>, <&gclk_core>, <&pll_out_enet>, <&pll_out_sd>; > + clock-output-names = "gclk_uart0"; > + assigned-clocks = <&gclk_uart0>; > + assigned-clock-parents = <&osc>; > + assigned-clock-rates = <24000000>; > + amb,mux-regmap = <&rct_syscon 0x1c8>; > + amb,div-regmap = <&rct_syscon 0x038>; > + amb,div-width = <24>; > + amb,div-shift = <0>; > + }; > diff --git a/Documentation/devicetree/bindings/clock/ambarella,pll-clock.yaml b/Documentation/devicetree/bindings/clock/ambarella,pll-clock.yaml > new file mode 100644 > index 000000000000..65c1feb60041 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/ambarella,pll-clock.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/ambarella,pll-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ambarella PLL Clock > + > +maintainers: > + - Li Chen > + > +properties: > + compatible: > + enum: > + - ambarella,pll-clock > + - ambarella,clkpll-v0 > + > +if: No, this does not work like that. It sits under "allOf", located after "required:". > + properties: > + compatible: > + const: ambarella,pll-clock > + > +then: > + properties: > + clocks: > + maxItems: 1 > + > + clock-output-names: true > + amb,clk-regmap: true > + amb,frac-mode: true > + assigned-clocks: true > + assigned-clock-rates: true Same problems. > + gclk_axi: gclk-axi { > + #clock-cells = <0>; > + compatible = "fixed-factor-clock"; What is this example about? Not related at all. Provide real example. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel