Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] gpio: samsung: Skip registration if pinctrl driver is present on Exynos4x12
Date: Wed, 07 Nov 2012 13:41:44 +0900	[thread overview]
Message-ID: <0c5301cdbca2$30320240$909606c0$%kim@samsung.com> (raw)
In-Reply-To: <CACRpkdYNDSp0K3wpvUem9ecsW-JQ9L6aKqaOmHNUR65DQTMNHA@mail.gmail.com>

Linus Walleij wrote:
> 
> On Wed, Oct 24, 2012 at 4:37 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> 
> > This patch modifies the Samsung GPIO driver to check for pinctrl driver
> > presence earlier and use generic matching instead of a single compatible
> > value.
> >
> > This allows us to fix warning about unrecognized SoC in case of
> > Exynos4x12, which is not supported by this driver.
> >
> > Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Tell me if there is something you want merged through
> the GPIO or pinctrl tree. I have this Samsung branch on the
> pinctrl tree...
> 
Hi Linus, 

A commit 1b6056d6 ("pinctrl: samsung: Include bank-specific eint offset in
bank struct") which is in your pinctrl tree (samsung branch) changed
macro(EXYNOS_PIN_BANK_EINTG) to add offset. Eventually, this series(due to
3rd patch, pinctrl: samsung: Add support for Exynos4x12) breaks compilation
without the commit. So if you don't have a plan to rebase samsung branch of
your pinctrl tree, I'd like to merge it in my tree. Is it ok to you?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2012-11-07  4:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 14:37 [PATCH 0/4] pinctrl: samsung: Add support for Exynos4x12 SoCs Tomasz Figa
2012-10-24 14:37 ` [PATCH 1/4] ARM: EXYNOS: Skip wakeup-int setup if pinctrl driver is used on Exynos4x12 Tomasz Figa
2012-10-24 14:37 ` [PATCH 2/4] gpio: samsung: Skip registration if pinctrl driver is present " Tomasz Figa
2012-10-28 19:11   ` Linus Walleij
2012-11-07  4:41     ` Kukjin Kim [this message]
2012-11-08 21:12       ` Linus Walleij
2012-11-09 10:09         ` Kukjin Kim
2012-11-11 18:35           ` Linus Walleij
2012-11-12  5:03             ` Kukjin Kim
2012-10-24 14:37 ` [PATCH 3/4] pinctrl: samsung: Add support for Exynos4x12 Tomasz Figa
2012-10-28 19:12   ` Linus Walleij
2012-10-29  0:30     ` Kyungmin Park
2012-10-29 10:28       ` Tomasz Figa
2012-10-29 11:27         ` Kukjin Kim
2012-10-30  9:29           ` Linus Walleij
2012-10-24 14:37 ` [PATCH 4/4] ARM: dts: exynos4x12: Add nodes for pin controllers Tomasz Figa
2012-10-28 19:13   ` Linus Walleij
2012-10-30  2:58 ` [PATCH 0/4] pinctrl: samsung: Add support for Exynos4x12 SoCs Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='0c5301cdbca2$30320240$909606c0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox