From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC57FC4361A for ; Fri, 4 Dec 2020 00:56:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EC2F224B1 for ; Fri, 4 Dec 2020 00:56:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EC2F224B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cH1fGaa5jMRnRd3TJNS185odu0Btnzs8KHMOEuV21Ng=; b=youqjrVc5WGQ6CtIT7nBXgk5o pNHu3icKlDM5mbFvJL9pL8dDeRxhVXD3M+feF9SbFuXiei0EipQcp/UXOGfr6EaNX758BwMSH1Dye TC6x6FSAMpCC6FHVICqZT5OhPOjS5NIZr3Ja+up/XFJ/tLRSBWUZCVMZNHYNoNiU9OgSmVvXFe6Ri uFedW5wy0IO3kHcBkmlxzmAONyYMrA4i/UkfShGnOkwQlnwhkbzyw9hCSlh0CrsKNBa19gX1JDAGy jx6D69VP7rayTvwT74NFkzLKLZcALbbQvOqV1EYH9BDDQ3/ivfcDfR0ubyGVPW7esK2gpBFZKT/hr kAjxUhkEg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkzNR-0001Dj-MN; Fri, 04 Dec 2020 00:55:13 +0000 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174] helo=mx0b-0016f401.pphosted.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkzNP-0001BB-CG for linux-arm-kernel@lists.infradead.org; Fri, 04 Dec 2020 00:55:12 +0000 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0B40pjM3019464; Thu, 3 Dec 2020 16:54:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=pfpt0220; bh=m6eO/hFVA2YpDNjX/QhlZNEXqMq7TJmb+zciqwtBOP8=; b=FtPX0fI8j7ymBNZypLmV9sO32F53lkGthigLvZXnGp4h1QolfPtWTKtVveTGsD17V5v9 vep29u8z3IWshao9OCUhvHkTT1zjjz+cxWNUymuvVZ6KlbP+wwaewJ85kSnv/0nZ4zwu jc1nuwOcLmxyHME0XPCCDJnrLT4/cClCVRNX8NEIHb5x+g6typPOO5fjaLB30W5olUmo iHmSJed8jGmFMi8rGLiqmuuDFu9AsYXdx9D1jOpPD6qqGzbO4f4q+2S5/askYoGPI/Q8 HirayU50JF1GDAWmgW5DaSkZyb3h9w4sTY10cRPcyvmmLkPKmv3zQKWKj+XFDYSmPBbO TQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 3568jfeewb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 03 Dec 2020 16:54:32 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 3 Dec 2020 16:54:31 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 3 Dec 2020 16:54:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EuBnRfdTttQZdwl3XHI5qGWZFw5KFocI8k2h5bhj7JxWA3QxCM0uW2+BLA0h2NdaMJanCWuzbUcYW58wv7kyu7LRDXSwWkAvF7Se1BF/LEaiLALtug0A7VH5K0p701qEwL6eayLORai9vhG/wUxlqpgqb7dCN0upp5AudObg18tiQUIJmysU3mxiHL6u2eDsnDILvuJ8JAJSamCQCroHZ6qa3tVw/wbqruJSkj2mrvb0w9TIKpviqC5PvA/pk+jnXhc0Iu16s9Du79oNpgyAE86urU8ohY/rnh6giA3HNE97k8BByWFEAZfz2+i64/OBnD0/v4J35bLwfrVPLOxGgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m6eO/hFVA2YpDNjX/QhlZNEXqMq7TJmb+zciqwtBOP8=; b=FZJBdCeVuwKI0NyE4VwCveKcMSanMxZggMK06ow5bTOcBB/VTNpiSqMPgGeKNB217Qjm2bdwAVf+euBriNfLsMaIRPJ45y9xAfT6shRPK+oDzcH71nLx6gd5vvLPT3msaYgg4p3QFEUJou+pTFMG7vNJIHDqYuJrZlqXN1wfJ5pPvWe8dlf7hDVf7ngq3oDdmTKMef5eRDwVpPZWUIA7zCLUZLO+M4PBXwM7S/iL3YdFL9BjbWFgDa2BlPSmE7TXm7nK4JX0Whd28x4Mz7uKVHyuWMzaH3kxNjJGjAbcJ+JlPGaO4KBT7ktKsfUGRUdfUptq2tvuqucqpOYWPl69sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m6eO/hFVA2YpDNjX/QhlZNEXqMq7TJmb+zciqwtBOP8=; b=Rcw9gQtmUPOfir+ZmHtVOXVDQsr6bCt8gt534taRNYBWovJON8d1PcQQ1Oy6FX+uhylJpixNA/kdO16m51bpqueq9BUm9Xqv5sjnXEagHijBkyHcnqKHthxjpT6PQ/JQcuInUNVxpHDetH+/z+EOIqSOPut1wrBJkm6drHQ4u9c= Received: from MW2PR18MB2267.namprd18.prod.outlook.com (2603:10b6:907:3::11) by MWHPR1801MB1967.namprd18.prod.outlook.com (2603:10b6:301:63::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.25; Fri, 4 Dec 2020 00:54:30 +0000 Received: from MW2PR18MB2267.namprd18.prod.outlook.com ([fe80::24e2:8566:bf62:b363]) by MW2PR18MB2267.namprd18.prod.outlook.com ([fe80::24e2:8566:bf62:b363%6]) with mapi id 15.20.3632.020; Fri, 4 Dec 2020 00:54:30 +0000 From: Alex Belits To: "mark.rutland@arm.com" Subject: Re: [EXT] Re: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu() Thread-Topic: [EXT] Re: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu() Thread-Index: AQHWwcI7UCf8Z8jL1UuRW32Ea/eUhKnj6RKAgAJDc4A= Date: Fri, 4 Dec 2020 00:54:29 +0000 Message-ID: <0c56e388c18187874ff23167d6927fed97e106b7.camel@marvell.com> References: <8d887e59ca713726f4fcb25a316e1e932b02823e.camel@marvell.com> <76ed0b222d2f16fb5aebd144ac0222a7f3b87fa1.camel@marvell.com> <20201202142033.GD66958@C02TD0UTHF1T.local> In-Reply-To: <20201202142033.GD66958@C02TD0UTHF1T.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [173.228.7.197] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34a97b3b-038c-4e28-af9b-08d897ef283f x-ms-traffictypediagnostic: MWHPR1801MB1967: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:935; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: knkNgc1zUHPYsPZWUnVzGpUesG7/TyAKY8FizbNteLBMZmKRqMxI7CB2Wzsg809m0X7bJjn//kObbXTmuzG1xDYRgfAYq0CwOygnztoQ/YfUkNYhVzyZfwsy1lW0UCMXwYmC2R1M3uUWBXNYRO2h4TiywAYE0SJCGvzLNfW2lor7Got/dIi8kSIqoLz3CN+qa9HysKLrSuiRavmArjDUekX7AU5NaiXNMaz3GPlCbvz/kO3ug2+IclgJjo4+RD2kEeu9xIhPyPZG7WPqaClHtxDlnKmHYmNgS903EWISY1HXFWBFM6VXEQeQI95HG0eG2xgYmYbkshw/GcW2dGfAGw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2267.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(366004)(396003)(136003)(6512007)(66556008)(66946007)(64756008)(6916009)(5660300002)(36756003)(6506007)(83380400001)(86362001)(91956017)(2616005)(186003)(26005)(66476007)(4326008)(316002)(71200400001)(66446008)(6486002)(8936002)(478600001)(7416002)(8676002)(76116006)(54906003)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?RXdEM3h1WVNxV3RMZ3B2d015MUFXVkhtZ0t0aXBtNVZoQmJBQ3hNRWgzZ1RE?= =?utf-8?B?NmJ6Qi9BWVpFNDZtT2dIdEwrV2pjUjVHQUtFdDhrSVhyd3ZkdC9NSTJseFdp?= =?utf-8?B?WGZpUkM2UFVuT0QzbHVTSlNBVXNWd1VUU0dOYkZUdHVOR0Vubys5NS9yQjBm?= =?utf-8?B?a2t6b1pjN1ZBaEIzZjFOcEhTckZqN1ovVDN3clpZYkRDbFVCcDhncnBML2VO?= =?utf-8?B?WXJMY1ZhVVZvb2Y0blI1ejE4STVoamxUenlEMFZUYWRUenJVK0dBQjNBb2I2?= =?utf-8?B?VkhBSnFRcjl3WUFpRENoNVNyR1phWVZPZWRzandPSit6a3NUSmZyRmJRcmRW?= =?utf-8?B?bHlCeWFZT2FFcU94Q1EzUXFvWksvazRBWGFoUDg4akJ3NTdwakc0SUhyYVFx?= =?utf-8?B?QUdjWERsdy92YVcyTEs4M2lVYmV6M01FUVkxcTExT05sME1kd3ZhR3VjRHFh?= =?utf-8?B?SG9QVFZrTzdyejQrYVNMNDdOZDhwTXJZdWJNc1BxYkJIOUg2TDFPYnJqM0lT?= =?utf-8?B?UmpFUzR5eHREbWdOTmhZNVpvNGtZWHZEU0h0ZmNkY09mdXhLZm44UGpJaVQx?= =?utf-8?B?eVFsVFVxOXNFVDl1V3QyVUhoaWZUNTVwWjN0ZG5DOUtML0d5aFQzMCtjemdh?= =?utf-8?B?bmdnTmFGcmhGNENrRk94TEcrSlkvaWJpS0VGY3MwamM0TVRSQkgvZU5veTlq?= =?utf-8?B?YVA2T29CcndubXkwcTRvbzJMdkhWenYrMFBMNUp4WGtLY3h2UHE4bXF2SW15?= =?utf-8?B?V0doQTAyZENZd0wyckpSYWpiWGh2UkIvVjBJZ0huMEJDSkhqemo1ZEViUFh1?= =?utf-8?B?LytVRS81cHQxMmpNdDFRSiswL0F1SlR5S1dEV1VXMnR2WElXYURqMnJGMWZD?= =?utf-8?B?a3hRSlhCa21OemdxY29lbGU1MEh2N1JpT0ZEYjZMZUw0cmxtWmFYTmF0Z3k1?= =?utf-8?B?SWZlbkNvODRDOEdJN1NuU0hENjNuSHJ3OGF2V0h4N3FPSXVLNmM0ak5nQk1J?= =?utf-8?B?YlR1a3BzNVVuQUg3UTlGVW5xOGNNQnNINU05OGI2ZXZQQ2N2RUh4YzJqdkxI?= =?utf-8?B?cC8rNGVyblY4ZnBhUTRPU1JDS09SWGUrcGZmaUNqS2JOWEhCYjVQOHBXVVp1?= =?utf-8?B?UVJUOFM0L2M4aVEzMCtJazVkU3VZT3ZldFEweU9sdHJuZVU3bStpRHJwNU9B?= =?utf-8?B?YTMycEVDSG9XR1o5cDl4YjA2ZURYd3ZSOE93YkdLczdHd010NTg5SWNWUVBj?= =?utf-8?B?NmhJbDd2ZHJleFVhTGpLclRKOElvZTJxR1BtQkR0Ukt0eFl4MFdEYmNyeExP?= =?utf-8?Q?9NIHyHJzrZgSm4tDdPIOMM/NHV5nBcBaPE?= Content-ID: <6657F20FD545E340B4845A5BDC34EF8D@namprd18.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2267.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34a97b3b-038c-4e28-af9b-08d897ef283f X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2020 00:54:29.9386 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NQJoS6rPR9guKEVqFKSPFpqOypfL9UNmyzX+udkTYRI6rYdNvqflPNGSfzBN3OEbC9TaIUXeZUOnavYZCrR80w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1967 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-12-03_15:2020-12-03, 2020-12-03 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201203_195511_562638_EF5AB76B X-CRM114-Status: GOOD ( 26.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-arch@vger.kernel.org" , "nitesh@redhat.com" , "pauld@redhat.com" , "catalin.marinas@arm.com" , "peterz@infradead.org" , Prasun Kapoor , "frederic@kernel.org" , "mtosatti@redhat.com" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "davem@davemloft.net" , "leon@sidebranch.com" , "netdev@vger.kernel.org" , "peterx@redhat.com" , "trix@redhat.com" , "tglx@linutronix.de" , "linux-api@vger.kernel.org" , "will@kernel.org" , "mingo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-12-02 at 14:20 +0000, Mark Rutland wrote: > External Email > > ------------------------------------------------------------------- > --- > On Mon, Nov 23, 2020 at 05:58:22PM +0000, Alex Belits wrote: > > From: Yuri Norov > > > > For nohz_full CPUs the desirable behavior is to receive interrupts > > generated by tick_nohz_full_kick_cpu(). But for hard isolation it's > > obviously not desirable because it breaks isolation. > > > > This patch adds check for it. > > > > Signed-off-by: Yuri Norov > > [abelits@marvell.com: updated, only exclude CPUs running isolated > > tasks] > > Signed-off-by: Alex Belits > > --- > > kernel/time/tick-sched.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c > > index a213952541db..6c8679e200f0 100644 > > --- a/kernel/time/tick-sched.c > > +++ b/kernel/time/tick-sched.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -268,7 +269,8 @@ static void tick_nohz_full_kick(void) > > */ > > void tick_nohz_full_kick_cpu(int cpu) > > { > > - if (!tick_nohz_full_cpu(cpu)) > > + smp_rmb(); > > What does this barrier pair with? The commit message doesn't mention > it, > and it's not clear in-context. With barriers in task_isolation_kernel_enter() and task_isolation_exit_to_user_mode(). -- Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel