From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudeep.holla@arm.com (Sudeep Holla) Date: Thu, 4 Jan 2018 11:46:49 +0000 Subject: [PATCH v5 4/9] drivers: base cacheinfo: Add support for ACPI based firmware tables In-Reply-To: <3c3bf8a4-a13a-ce71-4bd2-71dd11b45521@arm.com> References: <20171201222330.18863-1-jeremy.linton@arm.com> <20171201222330.18863-5-jeremy.linton@arm.com> <2078459.JrYtfXc8fv@aspire.rjw.lan> <5024a041-2ef4-3912-994f-b5fcc945e916@arm.com> <9bb1c58a-8d48-9952-e292-60b2bcb87a51@arm.com> <3c3bf8a4-a13a-ce71-4bd2-71dd11b45521@arm.com> Message-ID: <0c7e176a-cdd4-aceb-7f38-cda38acb89c1@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/01/18 14:21, Sudeep Holla wrote: > On 12/12/17 23:37, Jeremy Linton wrote: >> On 12/12/2017 05:02 PM, Rafael J. Wysocki wrote: > > [...] > >>> >>> So call this field "token" or similar.? Don't call it "of_node" and >>> don't introduce another "firmware_node" thing in addition to that. >>> That just is a mess, sorry. > > I completely agree. Both me and Lorenzo pointed that out in previous > revisions and fair enough you have a valid concern it's use with PPTT. > >> >> I sort of agree, I think I can just change the whole of_node to a >> generic 'void *firmware_unique' which works fine for the PPTT code, it >> should also work for the DT code in cache_leaves_are_shared(). >> > > Should be fine. > Just to let you know, I don't have much to add. I will wait for the patches that replace of_node with firmware cookie or something similar. -- Regards, Sudeep