From: Josua Mayer <josua@solid-run.com>
To: Peng Fan <peng.fan@nxp.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Frank Li" <frank.li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Daniel Scally" <dan.scally@ideasonboard.com>,
"Marco Felsch" <m.felsch@pengutronix.de>,
"Gilles Talis" <gilles.talis@gmail.com>,
"Viorel Suman" <viorel.suman@nxp.com>,
"S.J. Wang" <shengjiu.wang@nxp.com>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Manoj Sai" <abbaraju.manojsai@amarulasolutions.com>,
"matteo.lisi" <matteo.lisi@engicam.com>,
"Ray Chang" <ray.chang@technexion.com>,
"Richard Hu" <richard.hu@technexion.com>,
"Heiko Schocher" <hs@denx.de>,
"Martyn Welch" <martyn.welch@collabora.com>,
"Goran Rađenović" <goran.radni@gmail.com>,
"Börge Strümpfel" <boerge.struempfel@gmail.com>,
"Christoph Niedermaier" <cniedermaier@dh-electronics.com>,
"Marek Vasut" <marex@denx.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@dh-electronics.com" <kernel@dh-electronics.com>
Subject: Re: [PATCH v2 09/12] arm64: dts: imx8mp-sr-som: Correct PAD settings for PMIC_nINT
Date: Thu, 26 Mar 2026 12:33:22 +0000 [thread overview]
Message-ID: <0ca7eed9-b528-4405-aca0-1ce9e415b067@solid-run.com> (raw)
In-Reply-To: <PAXPR04MB845972866AB6A7E85D1570CB8856A@PAXPR04MB8459.eurprd04.prod.outlook.com>
Hi Peng,
Am 26.03.26 um 10:55 schrieb Peng Fan:
>> Subject: Re: [PATCH v2 09/12] arm64: dts: imx8mp-sr-som: Correct
>> PAD settings for PMIC_nINT
>>> --- a/arch/arm64/boot/dts/freescale/imx8mp-sr-som.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-sr-som.dtsi
>>> @@ -174,7 +174,7 @@ pmic: pmic@25 {
>>> pinctrl-0 = <&pmic_pins>;
>>> pinctrl-names = "default";
>>> interrupt-parent = <&gpio1>;
>>> - interrupts = <3 GPIO_ACTIVE_LOW>;
>>> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>> This is a good change, but it should be mentioned in the commit
>> message, or split to a separate patch. Same for other patches in this
>> series where you make the same change.
> Thanks, waiting to see if any board owners would give a test.
> Then I will update in V3.
>
> Thanks,
> Peng.
Looks correct to me.
Reviewed-by: Josua Mayer <josua@solid-run.com>
next prev parent reply other threads:[~2026-03-26 12:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 7:28 [PATCH v2 00/12] arm64: dts: imx8mp: Correct PAD settings for PMIC_nINT Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 01/12] arm64: dts: imx8mp-debix-model-a: " Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 02/12] arm64: dts: imx8mp-debix-som-a: " Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 03/12] arm64: dts: imx8mp-navqp: " Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 04/12] arm64: dts: imx8mp-ab2: " Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 05/12] arm64: dts: imx8mp-icore-mx8mp: " Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 06/12] arm64: dts: imx8mp-edm-g: " Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 07/12] arm64: dts: imx8mp-aristainetos3a-som-v1: " Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 08/12] arm64: dts: imx8mp-nitrogen-som: " Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 09/12] arm64: dts: imx8mp-sr-som: " Peng Fan (OSS)
2026-03-26 8:58 ` Laurent Pinchart
2026-03-26 9:55 ` Peng Fan
2026-03-26 12:33 ` Josua Mayer [this message]
2026-03-26 7:28 ` [PATCH v2 10/12] arm64: dts: imx8mp-ultra-mach-sbc: " Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 11/12] arm64: dts: imx8mp-dhcom-som: " Peng Fan (OSS)
2026-03-26 7:28 ` [PATCH v2 12/12] arm64: dts: imx8mp-data-modul-edm-sbc: " Peng Fan (OSS)
2026-03-27 14:32 ` [PATCH v2 00/12] arm64: dts: imx8mp: " Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ca7eed9-b528-4405-aca0-1ce9e415b067@solid-run.com \
--to=josua@solid-run.com \
--cc=abbaraju.manojsai@amarulasolutions.com \
--cc=boerge.struempfel@gmail.com \
--cc=cniedermaier@dh-electronics.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=gilles.talis@gmail.com \
--cc=goran.radni@gmail.com \
--cc=hs@denx.de \
--cc=imx@lists.linux.dev \
--cc=jagan@amarulasolutions.com \
--cc=kernel@dh-electronics.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=marex@denx.de \
--cc=martyn.welch@collabora.com \
--cc=matteo.lisi@engicam.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=ray.chang@technexion.com \
--cc=richard.hu@technexion.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox